From da784b20710aca6eb15de447ff5151536477c527 Mon Sep 17 00:00:00 2001 From: avt613 <47078235+avt613@users.noreply.github.com> Date: Tue, 26 Apr 2022 16:50:45 +0100 Subject: [PATCH 1/2] Given names to the 2 'Variable' sections --- docs/documentation/form/general.html | 2 ++ 1 file changed, 2 insertions(+) diff --git a/docs/documentation/form/general.html b/docs/documentation/form/general.html index f6c0214b..d8696933 100644 --- a/docs/documentation/form/general.html +++ b/docs/documentation/form/general.html @@ -1095,6 +1095,7 @@ variables_keys: {% include elements/snippet.html content=disabled_fields_example %} {% include components/variables.html + anchor_name='Control variables' type='element' variables_keys=page.variables_control_keys custom_message=custom_message @@ -1103,6 +1104,7 @@ variables_keys: %} {% include components/variables.html + anchor_name='Form variables' type='element' variables_keys=page.variables_keys folder='elements' From 895b77b3a9c2cfd199b97d2cd602213ee76dac2e Mon Sep 17 00:00:00 2001 From: Jean Lecordier <47030586+jlecordier@users.noreply.github.com> Date: Fri, 25 Feb 2022 00:10:38 +0100 Subject: [PATCH 2/2] Remove useless if in js example MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit If the length is 0, then the forEach call does nothing anyway Could we remove the slice part as well ? If IE support is required, can’t we just use Array.prototype.forEach ? Can’t we just remove IE support all together to promote clean and up to date code ? Polyfills and code transpilation are here to help support IE --- docs/documentation/components/navbar.html | 24 ++++++++++------------- 1 file changed, 10 insertions(+), 14 deletions(-) diff --git a/docs/documentation/components/navbar.html b/docs/documentation/components/navbar.html index efae333b..f2e64941 100644 --- a/docs/documentation/components/navbar.html +++ b/docs/documentation/components/navbar.html @@ -565,24 +565,20 @@ document.addEventListener('DOMContentLoaded', () => { // Get all "navbar-burger" elements const $navbarBurgers = Array.prototype.slice.call(document.querySelectorAll('.navbar-burger'), 0); - // Check if there are any navbar burgers - if ($navbarBurgers.length > 0) { + // Add a click event on each of them + $navbarBurgers.forEach( el => { + el.addEventListener('click', () => { - // Add a click event on each of them - $navbarBurgers.forEach( el => { - el.addEventListener('click', () => { + // Get the target from the "data-target" attribute + const target = el.dataset.target; + const $target = document.getElementById(target); - // Get the target from the "data-target" attribute - const target = el.dataset.target; - const $target = document.getElementById(target); + // Toggle the "is-active" class on both the "navbar-burger" and the "navbar-menu" + el.classList.toggle('is-active'); + $target.classList.toggle('is-active'); - // Toggle the "is-active" class on both the "navbar-burger" and the "navbar-menu" - el.classList.toggle('is-active'); - $target.classList.toggle('is-active'); - - }); }); - } + }); }); {% endcapture %}