When using a color modifier for a navbar (e.g., is-dark) the burger icon does not change the color. This commit adds the color modification for the navbar burger icon.
* Add a navbar-breakpoint variable (as yet unused)
* Replace hard-coded +touch, +desktop with $navbar-breakpoint variable
Using the fine +until and +from mixins, respectively.
It looks like Bulma's accessibility profile is very slowly improving but will never (unless given infinite timeline) match that of Bootstrap’s. For those of us that are legally required to meet a11y guidelines (US Government/Education), this is an important point that should be highlighted.
The example code that a user copies doesn't match the code that runs in the browser. This is confusing for new users and fails to demonstrate the actual library.
* Remove unnecessary use of @extend inside mixins
* Revert changes to +unselectable, +delete, and +loader
* Move @extend selector styling to their related mixin.
All javascript breaks if Vimeo fails to load or is blocked. Checking for `Vimeo` before accessing it should fix it. This can easily be reproduced using [uMatrix](https://github.com/gorhill/uMatrix).
* <!-- PLEASE READ THE FOLLOWING INSTRUCTIONS -->
<!-- DO NOT REBUILD THE CSS OUTPUT IN YOUR PR -->
<!-- Choose one of the following: -->
This is a bugfix
<!-- New feature? Update the CHANGELOG.md too, and eventually the Docs. -->
<!-- Improvement? Explain how and why. -->
<!-- Bugfix? Reference that issue as well. -->
If a form field is disabled and that form field uses has add-on element ( has-addons ), hover state is overlapping to add-on element.
### Proposed solution
<!-- Which specific problem does this PR solve and how? -->
<!-- If it fixes a particular Issue, add "Fixes #ISSUE_NUMBER" in your title -->
This solution excludes disabled form elements hover state which is used within has-addons fields wrapper.
Fixes#1992
### Tradeoffs
<!-- What are the drawbacks of this solution? Are there alternative ones? -->
<!-- Think of performance, build time, usability, complexity, coupling…) -->
No tradeoffs.
### Testing Done
I checkout out master and changed the lines.
* Disabled form elements hover state is overlapping, if control has add-ons elements
If a form field is disabled and that form field uses has add-on element ( has-addons ), hover state is overlapping to add-on element.
* Disabled form elements hover state is overlapping, if control has add-ons elements
If a form field is disabled and that form field uses has add-on element ( has-addons ), hover state is overlapping to add-on element.
