From 320bdb2926d28376a308333c08918def44f3e1f6 Mon Sep 17 00:00:00 2001 From: George Michael Brower Date: Mon, 18 Apr 2011 17:35:27 -0700 Subject: [PATCH 1/2] Pass only a single parameter to gui.add to automatically add all of its properties --- index.html | 2 +- src/DAT/GUI/ControllerNumber.js | 8 ++++---- src/DAT/GUI/GUI.js | 8 ++++++++ 3 files changed, 13 insertions(+), 5 deletions(-) diff --git a/index.html b/index.html index 94a8f87..450f659 100644 --- a/index.html +++ b/index.html @@ -30,9 +30,9 @@ prettyPrint(); var fizzyText = new FizzyText("dat.gui"); - var gui = new DAT.GUI(); + // Text field gui.add(fizzyText, "message"); diff --git a/src/DAT/GUI/ControllerNumber.js b/src/DAT/GUI/ControllerNumber.js index 191a86c..dc555eb 100644 --- a/src/DAT/GUI/ControllerNumber.js +++ b/src/DAT/GUI/ControllerNumber.js @@ -116,7 +116,7 @@ DAT.GUI.ControllerNumber = function() { numberField.addEventListener('mousewheel', function(e) { e.preventDefault(); - _this.setValue(_this.getValue() + Math.abs(e.wheelDeltaY) / e.wheelDeltaY * step); + _this.setValue(_this.getValue() + Math.abs(e.wheelDeltaY) / e.wheelDeltaY * _this.getStep()); return false; }, false); @@ -140,11 +140,11 @@ DAT.GUI.ControllerNumber = function() { _this.setValue(newVal); break; case 38: // up - newVal = _this.getValue() + step; + newVal = _this.getValue() + _this.getStep(); _this.setValue(newVal); break; case 40: // down - newVal = _this.getValue() - step; + newVal = _this.getValue() - _this.getStep(); _this.setValue(newVal); break; } @@ -192,7 +192,7 @@ DAT.GUI.ControllerNumber = function() { draggedNumberField = true; e.preventDefault(); - var newVal = _this.getValue() + dy * step; + var newVal = _this.getValue() + dy * _this.getStep(); _this.setValue(newVal); return false; diff --git a/src/DAT/GUI/GUI.js b/src/DAT/GUI/GUI.js index 28ee4f1..6693c18 100644 --- a/src/DAT/GUI/GUI.js +++ b/src/DAT/GUI/GUI.js @@ -275,6 +275,14 @@ DAT.GUI = function(parameters) { this.add = function() { + if (arguments.length == 1) { + var toReturn = []; + for (var i in arguments[0]) { + toReturn.push(_this.add(arguments[0], i)); + } + return toReturn; + } + var object = arguments[0]; var propertyName = arguments[1]; From 904157f062e0ba8b11ca3dde6b0e5c092af43ba7 Mon Sep 17 00:00:00 2001 From: George Michael Brower Date: Mon, 18 Apr 2011 17:41:02 -0700 Subject: [PATCH 2/2] wtf? why did my GUI.js get overwritten... --- src/DAT/GUI/GUI.js | 53 ++++++++++++++++++++-------------------------- 1 file changed, 23 insertions(+), 30 deletions(-) diff --git a/src/DAT/GUI/GUI.js b/src/DAT/GUI/GUI.js index d71e804..617ad37 100644 --- a/src/DAT/GUI/GUI.js +++ b/src/DAT/GUI/GUI.js @@ -6,6 +6,10 @@ DAT.GUI = function(parameters) { parameters = {}; } + if (parameters.height == undefined) { + parameters.height = 300; + } + var MIN_WIDTH = 240; var MAX_WIDTH = 500; @@ -19,11 +23,9 @@ DAT.GUI = function(parameters) { // Sum total of heights of controllers in this gui var controllerHeight; - var curControllerContainerHeight = 0; - var _this = this; - var open = false; + var open = true; var width = 280; // Prevents checkForOverflow bug in which loaded gui appearance @@ -45,9 +47,10 @@ DAT.GUI = function(parameters) { this.domElement.setAttribute('class', 'guidat'); this.domElement.style.width = width + 'px'; + var curControllerContainerHeight = parameters.height; var controllerContainer = document.createElement('div'); controllerContainer.setAttribute('class', 'guidat-controllers'); - controllerContainer.style.height = '0px'; + controllerContainer.style.height = curControllerContainerHeight + 'px'; // Firefox hack to prevent horizontal scrolling controllerContainer.addEventListener('DOMMouseScroll', function(e) { @@ -71,11 +74,10 @@ DAT.GUI = function(parameters) { }, false); - var toggleButton = document.createElement('a'); toggleButton.setAttribute('class', 'guidat-toggle'); toggleButton.setAttribute('href', '#'); - toggleButton.innerHTML = openString; + toggleButton.innerHTML = open ? closeString : openString; var toggleDragged = false; var dragDisplacementY = 0; @@ -273,14 +275,6 @@ DAT.GUI = function(parameters) { this.add = function() { - if (arguments.length == 1) { - var toReturn = []; - for (var i in arguments[0]) { - toReturn.push(_this.add(arguments[0], i)); - } - return toReturn; - } - var object = arguments[0]; var propertyName = arguments[1]; @@ -308,7 +302,7 @@ DAT.GUI = function(parameters) { return; } - var args = [this]; // Set first arg (parent) to this + var args = [this]; // Set first arg (parent) to this for (var j = 0; j < arguments.length; j++) { args.push(arguments[j]); } @@ -365,13 +359,10 @@ DAT.GUI = function(parameters) { 'function': DAT.GUI.ControllerFunction }; - this.reset = function() { // TODO ... Set all values back to their initials. } - // DAT.GUI ... DAT.GUI - this.toggle = function() { open ? this.close() : this.open(); }; @@ -381,6 +372,7 @@ DAT.GUI = function(parameters) { resizeTo = openHeight; clearTimeout(resizeTimeout); beginResize(); + adaptToScrollbar(); open = true; } @@ -389,6 +381,7 @@ DAT.GUI = function(parameters) { resizeTo = 0; clearTimeout(resizeTimeout); beginResize(); + adaptToScrollbar(); open = false; } @@ -404,13 +397,12 @@ DAT.GUI = function(parameters) { var beginResize = function() { + curControllerContainerHeight = controllerContainer.offsetHeight; curControllerContainerHeight += (resizeTo - curControllerContainerHeight) * 0.6; if (Math.abs(curControllerContainerHeight - resizeTo) < 1) { curControllerContainerHeight = resizeTo; - adaptToScrollbar(); - } else { resizeTimeout = setTimeout(beginResize, 1000 / 30); } @@ -421,15 +413,14 @@ DAT.GUI = function(parameters) { } var adaptToScrollbar = function() { - // Clears lingering slider column - _this.domElement.style.width = (width + 1) + 'px'; + // Clears lingering scrollbar column + _this.domElement.style.width = (width - 1) + 'px'; setTimeout(function() { _this.domElement.style.width = width + 'px'; }, 1); }; - // Load saved appearance: if (DAT.GUI.guiIndex < DAT.GUI.savedAppearanceVars.length) { @@ -461,10 +452,12 @@ DAT.GUI = function(parameters) { DAT.GUI.allGuis.push(this); // Add hide listener if this is the first DAT.GUI. + if (DAT.GUI.allGuis.length == 1) { + window.addEventListener('keyup', function(e) { // Hide on 'H' - if (e.keyCode == 72) { + if (!DAT.GUI.supressHotKeys && e.keyCode == 72) { DAT.GUI.toggleHide(); } }, false); @@ -490,6 +483,7 @@ DAT.GUI.autoPlaceContainer = null; DAT.GUI.allControllers = []; DAT.GUI.allGuis = []; +DAT.GUI.supressHotKeys = false; DAT.GUI.toggleHide = function() { if (DAT.GUI.hidden) { @@ -540,8 +534,7 @@ DAT.GUI.savedAppearanceVars = []; DAT.GUI.getSaveString = function() { - var vals = [], - i; + var vals = [], i; vals.push(DAT.GUI.allGuis.length); vals.push(document.body.scrollTop); @@ -686,19 +679,19 @@ DAT.GUI.extendController = function(clazz) { DAT.GUI.addClass = function(domElement, className) { if (DAT.GUI.hasClass(domElement, className)) return; domElement.className += ' ' + className; -}; +} DAT.GUI.hasClass = function(domElement, className) { return domElement.className.indexOf(className) != -1; -}; +} DAT.GUI.removeClass = function(domElement, className) { var reg = new RegExp(' ' + className, 'g'); domElement.className = domElement.className.replace(reg, ''); -}; +} if (DAT.GUI.getVarFromURL('saveString') != null) { DAT.GUI.load(DAT.GUI.getVarFromURL('saveString')); } -window["DAT.GUI"] = DAT.GUI; +window['DAT'] = DAT; \ No newline at end of file