Use LuaJIT md5 ffi feature optionally #4

Open
opened 2015-02-06 03:02:20 +00:00 by josefnpat · 7 comments
josefnpat commented 2015-02-06 03:02:20 +00:00 (Migrated from github.com)

It would be nice to add an MD5 that takes advantage of LuaJIT's bitops!

It would speed up the performance somewhat!

https://github.com/Wiladams/LAPHLibs/blob/master/MD5.lua

It would be nice to add an MD5 that takes advantage of LuaJIT's bitops! It would speed up the performance somewhat! https://github.com/Wiladams/LAPHLibs/blob/master/MD5.lua
pablomayobre commented 2015-02-08 02:22:39 +00:00 (Migrated from github.com)

Unfortunately the library @josefnpat pointed out doesnt work right. So I modified @kikito 's library to use bitops where available, you can grab it here, I also made a pull request to Kikito so maybe he merges it (who knows?)

Unfortunately the library @josefnpat pointed out doesnt work right. So I modified @kikito 's library to use bitops where available, you can grab it [here](https://github.com/Positive07/md5.lua/blob/patch-1/md5.lua), I also made [a pull request](https://github.com/kikito/md5.lua/pull/2) to Kikito so maybe he merges it (who knows?)
pablomayobre commented 2015-02-08 04:44:54 +00:00 (Migrated from github.com)

PS: I forgot to mention it but with these minor modifications it works from 300 to 500 times faster

PS: I forgot to mention it but with these minor modifications it works from 300 to 500 times faster
josefnpat commented 2015-02-08 06:38:01 +00:00 (Migrated from github.com)

👍

:+1:
pablomayobre commented 2015-02-09 17:56:24 +00:00 (Migrated from github.com)

Okey, Kikito merged the pull request so I recommend you update MD5.lua to it's latest version (1.0.0) 😄

Okey, Kikito merged the pull request so I recommend you update MD5.lua to it's latest version (1.0.0) :smile:
kikito commented 2015-02-09 18:14:35 +00:00 (Migrated from github.com)

👍 :godmode: 👍

:+1: :godmode: :+1:
mbrovko commented 2015-02-10 10:33:42 +00:00 (Migrated from github.com)

Nice work, peeps!

Nice work, peeps!
pablomayobre commented 2015-03-01 20:53:34 +00:00 (Migrated from github.com)

I think this issue has been solved so, shall it be closed?

I think this issue has been solved so, shall it be closed?
This repo is archived. You cannot comment on issues.
No Milestone
No project
No Assignees
1 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: library-mirrors/gamejoltlua#4
No description provided.