From 0627eb3645009d868ae20a27d0a283acd5797a1f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Scott=20Gonz=C3=A1lez?= Date: Tue, 11 Oct 2016 09:59:32 -0400 Subject: [PATCH] Form: Rename from `.form()` to `._form()` since its not for public use Fixes #15074 Closes gh-1760 --- tests/unit/core/core.js | 2 +- ui/form-reset-mixin.js | 2 +- ui/form.js | 2 +- ui/widgets/checkboxradio.js | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/unit/core/core.js b/tests/unit/core/core.js index 9d00d61b6..770ea4138 100644 --- a/tests/unit/core/core.js +++ b/tests/unit/core/core.js @@ -180,7 +180,7 @@ QUnit.test( "Labels", function( assert ) { QUnit.test( name + this.id.replace( /_/g, " " ), function( assert ) { var ready = assert.async(); assert.expect( 1 ); - var form = input.form(); + var form = input._form(); // If input has a form the value should reset to "" if not it should be "changed" var value = form.length ? "" : "changed"; diff --git a/ui/form-reset-mixin.js b/ui/form-reset-mixin.js index a14c82ee6..5d182186a 100644 --- a/ui/form-reset-mixin.js +++ b/ui/form-reset-mixin.js @@ -42,7 +42,7 @@ return $.ui.formResetMixin = { }, _bindFormResetHandler: function() { - this.form = this.element.form(); + this.form = this.element._form(); if ( !this.form.length ) { return; } diff --git a/ui/form.js b/ui/form.js index cfb4bd280..fb0a3c6cf 100644 --- a/ui/form.js +++ b/ui/form.js @@ -13,7 +13,7 @@ // Support: IE8 Only // IE8 does not support the form attribute and when it is supplied. It overwrites the form prop // with a string, so we need to find the proper form. -return $.fn.form = function() { +return $.fn._form = function() { return typeof this[ 0 ].form === "string" ? this.closest( "form" ) : $( this[ 0 ].form ); }; diff --git a/ui/widgets/checkboxradio.js b/ui/widgets/checkboxradio.js index 19ae92811..228c9fab9 100644 --- a/ui/widgets/checkboxradio.js +++ b/ui/widgets/checkboxradio.js @@ -161,7 +161,7 @@ $.widget( "ui.checkboxradio", [ $.ui.formResetMixin, { // Not inside a form, check all inputs that also are not inside a form group = $( nameSelector ).filter( function() { - return $( this ).form().length === 0; + return $( this )._form().length === 0; } ); }