library-mirrors/jquery-ui
1
0
Fork 0
mirror of https://github.com/jquery/jquery-ui.git synced 2024-11-21 11:04:24 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Button: Adding quotes to the attribute selector for labels - Fixes #7534 - Button label selector omits quotes / fails for ids with ":"

Browse Source 
(cherry picked from commit 065aef537b)

Conflicts:

	ui/jquery.ui.button.js
This commit is contained in:
Corey Frang 2011-08-03 22:19:29 -05:00
parent 14ab4f4f37
commit 07d5271f7e
2 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
tests/unit/button/button_tickets.js
View File

@ -50,4 +50,10 @@ test( "#7092 - button creation that requires a matching label does not find labe
ok( group.find( "label" ).is( ".ui-button" ) ); ok( group.find( "label" ).is( ".ui-button" ) );
}); });
test( "#7534 - Button label selector works for ids with \":\"", function() {
var group = $( "<span><input type='checkbox' id='check:7534'><label for='check:7534'>Label</label></span>" );
group.find( "input" ).button();
ok( group.find( "label" ).is( ".ui-button" ), "Found an id with a :" );
});
})( jQuery ); })( jQuery );

2
ui/jquery.ui.button.js vendored
View File

@ -227,7 +227,7 @@ $.widget( "ui.button", {
// we don't search against the document in case the element // we don't search against the document in case the element
// is disconnected from the DOM // is disconnected from the DOM
var ancestor = this.element.parents().filter(":last"), var ancestor = this.element.parents().filter(":last"),
labelSelector = "label[for=" + this.element.attr("id") + "]"; labelSelector = "label[for='" + this.element.attr("id") + "']";
this.buttonElement = ancestor.find( labelSelector ); this.buttonElement = ancestor.find( labelSelector );
if ( !this.buttonElement.length ) { if ( !this.buttonElement.length ) {
ancestor = ancestor.length ? ancestor.siblings() : this.element.siblings(); ancestor = ancestor.length ? ancestor.siblings() : this.element.siblings();