From 0b18671d2819bbd9b0ff9f020a5b5b9372cace3d Mon Sep 17 00:00:00 2001 From: gnarf Date: Wed, 2 Mar 2011 19:46:19 -0600 Subject: [PATCH] Should add a visual test for the standard show/hide method to make sure we don't break it by overriding it --- tests/visual/effects.all.html | 6 ++++++ tests/visual/effects.all.js | 16 +++++++++++++--- 2 files changed, 19 insertions(+), 3 deletions(-) diff --git a/tests/visual/effects.all.html b/tests/visual/effects.all.html index 6fd07fb39..074ebcca6 100644 --- a/tests/visual/effects.all.html +++ b/tests/visual/effects.all.html @@ -174,6 +174,12 @@ +
  • +
    +

    hide/show (jQuery)

    +
    +
  • + diff --git a/tests/visual/effects.all.js b/tests/visual/effects.all.js index 0479c47ac..b11c13183 100644 --- a/tests/visual/effects.all.js +++ b/tests/visual/effects.all.js @@ -1,5 +1,6 @@ $(function() { + var duration = 1000, wait = 500; $("div.effect") .hover(function() { $(this).addClass("hover"); }, @@ -13,15 +14,24 @@ $(function() { $(el).bind("click", function() { - $(this).addClass("current").hide(n, o, 1000, function() { + $(this).addClass("current").hide(n, o, duration, function() { var self = this; window.setTimeout(function() { - $(self).show(n, o, 1000, function() { $(this).removeClass("current"); }); - },500); + $(self).show(n, o, duration, function() { $(this).removeClass("current"); }); + }, wait); }); }); }; + + $("#hide").click(function() { + var el = $(this); + el.addClass("current").hide(duration, function() { + setTimeout(function() { + el.show(duration, function() { el.removeClass("current") }); + }, wait); + }) + }) effect("#blindHorizontally", "blind", { direction: "horizontal" }); effect("#blindVertically", "blind", { direction: "vertical" });