library-mirrors/jquery-ui
1
0
Fork 0
mirror of https://github.com/jquery/jquery-ui.git synced 2024-11-21 11:04:24 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Theme: Revert three theme commits that are causing styling issues (#1983)

Browse Source 
* Revert "Theme: Removes css for ui-state-checked its not used any more"

This reverts commit 1b0e947f46.

* Revert "Theme: Replace missing definition for default icons"

This reverts commit dde9b83df6.

* Revert "Theme: Switch icon background to use bgColorContent"

This reverts commit 265b8f5e53.

This reverts three commits:

* Theme: Removes css for ui-state-checked its not used any more 1b0e947f46 (https://github.com/jquery/jquery-ui/pull/1753)
* Theme: Replace missing definition for default icons dde9b83df6
* Theme: Switch icon background to use bgColorContent 265b8f5e53

which caused styling issues when compared to UI 1.12.1.

This unfixes a few issues:

* https://github.com/jquery/download.jqueryui.com/issues/335
* https://bugs.jqueryui.com/ticket/15059
* https://forum.jquery.com/topic/checkboxradio-widget-checkbox-click-doesn-t-work-with-ui-lightness-theme-22-9-2016

However, old & known issues are better than new & unknown ones, especially with our current very limited resources.

Closes gh-1983
This commit is contained in:
Michał Gołębiowski-Owczarek 2021-09-26 00:03:44 +02:00 committed by GitHub
parent 87656cdf57
commit 0fe05e5223
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
themes/base/theme.css
View File

@ -116,9 +116,10 @@ a.ui-button:active,
font-weight: normal/*{fwDefault}*/; font-weight: normal/*{fwDefault}*/;
color: #ffffff/*{fcActive}*/; color: #ffffff/*{fcActive}*/;
} }
.ui-icon-background { .ui-icon-background,
border: #dddddd/*{borderColorContent}*/; .ui-state-active .ui-icon-background {
background-color: #ffffff/*{bgColorContent}*/; border: #003eff/*{borderColorActive}*/;
background-color: #ffffff/*{fcActive}*/;
} }
.ui-state-active a, .ui-state-active a,
.ui-state-active a:link, .ui-state-active a:link,
@ -136,6 +137,10 @@ a.ui-button:active,
background: #fffa90/*{bgColorHighlight}*/ /*{bgImgUrlHighlight}*/ /*{bgHighlightXPos}*/ /*{bgHighlightYPos}*/ /*{bgHighlightRepeat}*/; background: #fffa90/*{bgColorHighlight}*/ /*{bgImgUrlHighlight}*/ /*{bgHighlightXPos}*/ /*{bgHighlightYPos}*/ /*{bgHighlightRepeat}*/;
color: #777620/*{fcHighlight}*/; color: #777620/*{fcHighlight}*/;
} }
.ui-state-checked {
border: 1px solid #dad55e/*{borderColorHighlight}*/;
background: #fffa90/*{bgColorHighlight}*/;
}
.ui-state-highlight a, .ui-state-highlight a,
.ui-widget-content .ui-state-highlight a, .ui-widget-content .ui-state-highlight a,
.ui-widget-header .ui-state-highlight a { .ui-widget-header .ui-state-highlight a {
@ -214,8 +219,7 @@ a.ui-button:active,
.ui-state-error-text .ui-icon { .ui-state-error-text .ui-icon {
background-image: url("images/ui-icons_cc0000_256x240.png")/*{iconsError}*/; background-image: url("images/ui-icons_cc0000_256x240.png")/*{iconsError}*/;
} }
.ui-button .ui-icon, .ui-button .ui-icon {
.ui-state-default .ui-icon {
background-image: url("images/ui-icons_777777_256x240.png")/*{iconsDefault}*/; background-image: url("images/ui-icons_777777_256x240.png")/*{iconsDefault}*/;
} }