library-mirrors/jquery-ui
1
0
Fork 0
mirror of https://github.com/jquery/jquery-ui.git synced 2024-11-21 11:04:24 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Dialog: Work around subpixel issues in dialog resizable test

Browse Source 
Switching to checking the size of the content element. We should be
checking the dimensions of the .ui-dialog element, but that currently
fails in Chromium-based browsers. Once we start using box-sizing:
border-box, we should try to revert this change.

Ref #9845
This commit is contained in:
Jörn Zaefferer 2014-02-20 17:54:48 +01:00
parent e7c932ee2b
commit 122b913743
1 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
tests/unit/dialog/dialog_test_helpers.js
View File

@ -24,17 +24,20 @@ TestHelpers.dialog = {
actualDY = offsetAfter.top - offsetBefore.top; actualDY = offsetAfter.top - offsetBefore.top;
ok( expectedDX - actualDX <= 1 && expectedDY - actualDY <= 1, "dragged[" + expectedDX + ", " + expectedDY + "] " + msg); ok( expectedDX - actualDX <= 1 && expectedDY - actualDY <= 1, "dragged[" + expectedDX + ", " + expectedDY + "] " + msg);
}, },
// TODO switch back to checking the size of the .ui-dialog element (var d)
// once we switch to using box-sizing: border-box (#9845) that should work fine
// using the element's dimensions to avoid subpixel errors
shouldResize: function(element, dw, dh, msg) { shouldResize: function(element, dw, dh, msg) {
var heightAfter, widthAfter, actual, expected, var heightAfter, widthAfter, actual, expected,
d = element.dialog("widget"), d = element.dialog("widget"),
handle = $(".ui-resizable-se", d), handle = $(".ui-resizable-se", d),
heightBefore = d.height(), heightBefore = element.height(),
widthBefore = d.width(); widthBefore = element.width();
TestHelpers.dialog.drag(element, handle, 50, 50); TestHelpers.dialog.drag(element, handle, 50, 50);
heightAfter = d.height(); heightAfter = element.height();
widthAfter = d.width(); widthAfter = element.width();
msg = msg ? msg + "." : ""; msg = msg ? msg + "." : "";
actual = { width: widthAfter, height: heightAfter }, actual = { width: widthAfter, height: heightAfter },