library-mirrors/jquery-ui
1
0
Fork 0
mirror of https://github.com/jquery/jquery-ui.git synced 2025-01-07 20:34:24 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Dialog: Ensure all animations finish and clean up themselve when destroying dialog. Fixes #5860 - Dialog: Destroying a dialog during animated close leaves .ui-effects-wrapper in DOM.

Browse Source
This commit is contained in:
Jörn Zaefferer 2012-11-30 13:08:56 +01:00
parent 548a6ce7f9
commit 13505e5945
3 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tests/unit/dialog/dialog.html
View File

@ -23,6 +23,8 @@
"ui/jquery.ui.draggable.js", "ui/jquery.ui.draggable.js",
"ui/jquery.ui.resizable.js", "ui/jquery.ui.resizable.js",
"ui/jquery.ui.button.js", "ui/jquery.ui.button.js",
"ui/jquery.ui.effect.js",
"ui/jquery.ui.effect-clip.js",
"ui/jquery.ui.dialog.js" "ui/jquery.ui.dialog.js"
] ]
}); });

9
tests/unit/dialog/dialog_options.js
View File

@ -212,6 +212,15 @@ test("height", function() {
el.remove(); el.remove();
}); });
asyncTest( "hide, #5860 - don't leave effects wrapper behind", function() {
expect( 1 );
$( "#dialog1" ).dialog({ hide: "clip" }).dialog( "close" ).dialog( "destroy" );
setTimeout(function() {
equal( $( ".ui-effects-wrapper" ).length, 0 );
start();
}, 500);
});
test("maxHeight", function() { test("maxHeight", function() {
expect(3); expect(3);

2
ui/jquery.ui.dialog.js vendored
View File

@ -131,7 +131,7 @@ $.widget("ui.dialog", {
// without detaching first, the following becomes really slow // without detaching first, the following becomes really slow
.detach(); .detach();
this.uiDialog.remove(); this.uiDialog.stop( true, true ).remove();
if ( this.originalTitle ) { if ( this.originalTitle ) {
this.element.attr( "title", this.originalTitle ); this.element.attr( "title", this.originalTitle );