mirror of
https://github.com/jquery/jquery-ui.git
synced 2024-11-21 11:04:24 +00:00
Dialog: Finish refactoring _setOption, getting rid of unnecessary switch (no fallthroughs).
This commit is contained in:
parent
7e964be80c
commit
16a79c1b9c
31
ui/jquery.ui.dialog.js
vendored
31
ui/jquery.ui.dialog.js
vendored
@ -578,22 +578,23 @@ $.widget("ui.dialog", {
|
||||
this._createButtons();
|
||||
}
|
||||
|
||||
switch ( key ) {
|
||||
case "closeText":
|
||||
// ensure that we always pass a string
|
||||
if ( key === "closeText" ) {
|
||||
this.uiDialogTitlebarClose.button({
|
||||
// ensure that we always pass a string
|
||||
label: "" + value
|
||||
});
|
||||
break;
|
||||
case "disabled":
|
||||
}
|
||||
|
||||
if ( key === "disabled" ) {
|
||||
// TODO use toggleClass( "ui-dialog-disabled", value )
|
||||
if ( value ) {
|
||||
uiDialog.addClass( "ui-dialog-disabled" );
|
||||
} else {
|
||||
uiDialog.removeClass( "ui-dialog-disabled" );
|
||||
}
|
||||
break;
|
||||
case "draggable":
|
||||
}
|
||||
|
||||
if ( key === "draggable" ) {
|
||||
isDraggable = uiDialog.is( ":data(ui-draggable)" );
|
||||
if ( isDraggable && !value ) {
|
||||
uiDialog.draggable( "destroy" );
|
||||
@ -602,11 +603,13 @@ $.widget("ui.dialog", {
|
||||
if ( !isDraggable && value ) {
|
||||
this._makeDraggable();
|
||||
}
|
||||
break;
|
||||
case "position":
|
||||
}
|
||||
|
||||
if ( key === "position" ) {
|
||||
this._position( value );
|
||||
break;
|
||||
case "resizable":
|
||||
}
|
||||
|
||||
if ( key === "resizable" ) {
|
||||
// currently resizable, becoming non-resizable
|
||||
isResizable = uiDialog.is( ":data(ui-resizable)" );
|
||||
if ( isResizable && !value ) {
|
||||
@ -622,13 +625,13 @@ $.widget("ui.dialog", {
|
||||
if ( !isResizable && value !== false ) {
|
||||
this._makeResizable( value );
|
||||
}
|
||||
break;
|
||||
case "title":
|
||||
}
|
||||
|
||||
if ( key === "title" ) {
|
||||
// convert whatever was passed in to a string, for html() to not throw up
|
||||
// TODO deduplicate this (see _create)
|
||||
$( ".ui-dialog-title", this.uiDialogTitlebar )
|
||||
.html( "" + ( value || " " ) );
|
||||
break;
|
||||
}
|
||||
},
|
||||
|
||||
|
Loading…
Reference in New Issue
Block a user