library-mirrors/jquery-ui
1
0
Fork 0
mirror of https://github.com/jquery/jquery-ui.git synced 2024-11-21 11:04:24 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Dialog: Remove animation stopping in destroy

Browse Source 
Effects wrappers are no longer used, so the workaround and test are no
longer necessary.

This fixes tests in IE8 with jQuery 1.7.

Effectively a complete revert of 13505e5945

Closes gh-1481
This commit is contained in:
Scott González 2015-03-10 15:40:49 -04:00
parent a6a18d1ed8
commit 1f9821c000
3 changed files with 1 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
tests/unit/dialog/dialog.html
View File

@ -22,7 +22,6 @@
"ui/button.js",
"ui/effect.js",
"ui/effect-blind.js",
"ui/effect-clip.js",
"ui/effect-explode.js",
"ui/dialog.js"
]

9
tests/unit/dialog/dialog_options.js
View File

@ -283,15 +283,6 @@ test("height", function() {
element.remove();
});
asyncTest( "hide, #5860 - don't leave effects wrapper behind", function() {
expect( 1 );
$( "#dialog1" ).dialog({ hide: "clip" }).dialog( "close" ).dialog( "destroy" );
setTimeout(function() {
equal( $( ".ui-effects-wrapper" ).length, 0 );
start();
}, 500);
});
test("maxHeight", function() {
expect(3);

2
ui/dialog.js
View File

@ -168,7 +168,7 @@ return $.widget( "ui.dialog", {
// Without detaching first, the following becomes really slow
.detach();
this.uiDialog.stop( true, true ).remove();
this.uiDialog.remove();
if ( this.originalTitle ) {
this.element.attr( "title", this.originalTitle );