library-mirrors/jquery-ui
1
0
Fork 0
mirror of https://github.com/jquery/jquery-ui.git synced 2024-11-21 11:04:24 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Tests: Fix selectmenu width tests in Firefox with jQuery 3.0 & 3.1

Browse Source 
jQuery 3.0 & 3.1 used `getBoundingClientRect()` in its `width`/`height`
calculations and that causes minor differences in fractional width computations.
Allow a tiny delta in tests to fix those tests breaking in Firefox.

Ref jquery/jquery#3561
Closes gh-2159
This commit is contained in:
Michał Gołębiowski-Owczarek 2023-05-10 10:56:02 +02:00 committed by GitHub
parent 7adb13ac7c
commit 23655f0dbd
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
tests/unit/selectmenu/options.js
View File

@ -101,7 +101,7 @@ QUnit.test( "width", function( assert ) {
assert.equal( button[ 0 ].style.width, "", "no inline style" ); assert.equal( button[ 0 ].style.width, "", "no inline style" );
element.selectmenu( "option", "width", null ); element.selectmenu( "option", "width", null );
assert.equal( button.outerWidth(), element.outerWidth(), "button width auto" ); assert.close( button.outerWidth(), element.outerWidth(), 0.01, "button width auto" );
element.outerWidth( 100 ); element.outerWidth( 100 );
element.selectmenu( "refresh" ); element.selectmenu( "refresh" );
@ -117,7 +117,8 @@ QUnit.test( "width", function( assert ) {
.append( $( "<option>", { text: "Option with a little longer text" } ) ) .append( $( "<option>", { text: "Option with a little longer text" } ) )
.selectmenu( "option", "width", null ) .selectmenu( "option", "width", null )
.selectmenu( "refresh" ); .selectmenu( "refresh" );
assert.equal( button.outerWidth(), element.outerWidth(), "button width with long option" ); assert.close( button.outerWidth(), element.outerWidth(), 0.01,
"button width with long option" );
element.parent().outerWidth( 300 ); element.parent().outerWidth( 300 );
element element