Widget: define a null default for the create callback.

tests/unit/accordion/accordion_defaults.js

@@ -14,6 +14,7 @@ commonWidgetTests( "accordion", {
 
 		// callbacks
 		activate: null,
-		beforeActivate: null
+		beforeActivate: null,
+		create: null
 	}
 });

tests/unit/accordion/accordion_defaults_deprecated.js

@@ -22,6 +22,7 @@ commonWidgetTests( "accordion", {
 		activate: null,
 		beforeActivate: null,
 		change: null,
-		changestart: null
+		changestart: null,
+		create: null
 	}
 });

tests/unit/autocomplete/autocomplete_defaults.js

@@ -15,6 +15,7 @@ commonWidgetTests( "autocomplete", {
 		// callbacks
 		change: null,
 		close: null,
+		create: null,
 		focus: null,
 		open: null,
 		response: null,

tests/unit/button/button_defaults.js

@@ -1,15 +1,14 @@
-/*
+commonWidgetTests( "button", {
- * button_defaults.js
+	defaults: {
- */
+		disabled: null,
+		icons: {
+			primary: null,
+			secondary: null
+		},
+		label: null,
+		text: true,
 
-var button_defaults = {
+		// callbacks
-	disabled: null,
+		create: null
-	text: true,
-	label: null,
-	icons: {
-		primary: null,
-		secondary: null
 	}
-};
+});
-
-commonWidgetTests('button', { defaults: button_defaults });

tests/unit/dialog/dialog_defaults.js

@@ -1,35 +1,34 @@
-/*
+commonWidgetTests( "dialog", {
- * dialog_defaults.js
+	defaults: {
- */
+		autoOpen: true,
+		buttons: {},
+		closeOnEscape: true,
+		closeText: 'close',
+		disabled: false,
+		dialogClass: '',
+		draggable: true,
+		height: 'auto',
+		hide: null,
+		maxHeight: false,
+		maxWidth: false,
+		minHeight: 150,
+		minWidth: 150,
+		modal: false,
+		position: {
+			my: 'center',
+			at: 'center',
+			of: window,
+			collision: 'fit',
+			using: $.ui.dialog.prototype.options.position.using
+		},
+		resizable: true,
+		show: null,
+		stack: true,
+		title: '',
+		width: 300,
+		zIndex: 1000,
 
-var dialog_defaults = {
+		// callbacks
-	autoOpen: true,
+		create: null
-	buttons: {},
+	}
-	closeOnEscape: true,
+});
-	closeText: 'close',
-	disabled: false,
-	dialogClass: '',
-	draggable: true,
-	height: 'auto',
-	hide: null,
-	maxHeight: false,
-	maxWidth: false,
-	minHeight: 150,
-	minWidth: 150,
-	modal: false,
-	position: {
-		my: 'center',
-		at: 'center',
-		of: window,
-		collision: 'fit',
-		using: $.ui.dialog.prototype.options.position.using
-	},
-	resizable: true,
-	show: null,
-	stack: true,
-	title: '',
-	width: 300,
-	zIndex: 1000
-};
-
-commonWidgetTests('dialog', { defaults: dialog_defaults });

tests/unit/dialog/dialog_options.js

@@ -180,7 +180,7 @@ test("height", function() {
 	expect(3);
 
 	el = $('<div></div>').dialog();
-		equals(dlg().height(), dialog_defaults.minHeight, "default height");
+		equals(dlg().height(), 150, "default height");
 	el.remove();
 
 	el = $('<div></div>').dialog({ height: 237 });
@@ -431,7 +431,7 @@ test("width", function() {
 	expect(3);
 
 	el = $('<div></div>').dialog();
-		equals(dlg().width(), dialog_defaults.width, "default width");
+		equals(dlg().width(), 300, "default width");
 	el.remove();
 
 	el = $('<div></div>').dialog({width: 437 });

tests/unit/menu/menu_defaults.js

@@ -1,13 +1,12 @@
-/*
+commonWidgetTests( "menu", {
- * menu_defaults.js
+	defaults: {
- */
+		disabled: false,
+		position: {
+			my: "left top",
+			at: "right top"
+		},
 
-var menu_defaults = {
+		// callbacks
-	disabled: false,
+		create: null
-	position: {
-		my: "left top",
-		at: "right top"
 	}
-};
+});
-
-commonWidgetTests('menu', { defaults: menu_defaults });

tests/unit/progressbar/progressbar_defaults.js

@@ -1,11 +1,10 @@
-/*
+commonWidgetTests( "progressbar", {
- * progressbar_defaults.js
+	defaults: {
- */
+		disabled: false,
+		value: 0,
+		max: 100,
 
-var progressbar_defaults = {
+		//callbacks
-	disabled: false,
+		create: null
-	value: 0,
+	}
-	max: 100
+});
-};
-
-commonWidgetTests('progressbar', { defaults: progressbar_defaults });

tests/unit/slider/slider_defaults.js

@@ -1,20 +1,19 @@
-/*
+commonWidgetTests( "slider", {
- * slider_defaults.js
+	defaults: {
- */
+		animate: false,
+		cancel: function() {},
+		delay: 0,
+		disabled: false,
+		distance: 0,
+		max: 100,
+		min: 0,
+		orientation: 'horizontal',
+		range: false,
+		step: 1,
+		value: 0,
+		values: null,
 
-var slider_defaults = {
+		// callbacks
-	animate: false,
+		create: null
-	cancel: function() {},
+	}
-	delay: 0,
+});
-	disabled: false,
-	distance: 0,
-	max: 100,
-	min: 0,
-	orientation: 'horizontal',
-	range: false,
-	step: 1,
-	value: 0,
-	values: null
-};
-
-commonWidgetTests('slider', { defaults: slider_defaults });

tests/unit/spinner/spinner_defaults.js

@@ -1,16 +1,15 @@
-/*
+commonWidgetTests( "spinner", {
- * spinner_defaults.js
+	defaults: {
- */
+		disabled: false,
+		incremental: true,
+		max: null,
+		min: null,
+		numberformat: null,
+		page: 10,
+		step: null,
+		value: null,
 
-var spinner_defaults = {
+		// callbacks
-	disabled: false,
+		create: null
-	incremental: true,
+	}
-	max: null,
+});
-	min: null,
-	numberformat: null,
-	page: 10,
-	step: null,
-	value: null
-};
-
-commonWidgetTests('spinner', { defaults: spinner_defaults });

tests/unit/tabs/tabs_defaults.js

@@ -10,6 +10,7 @@ commonWidgetTests( "tabs", {
 		activate: null,
 		beforeActivate: null,
 		beforeLoad: null,
+		create: null,
 		load: null
 	}
 });

tests/unit/tabs/tabs_defaults_deprecated.js

@@ -18,6 +18,7 @@ commonWidgetTests( "tabs", {
 		add: null,
 		beforeActivate: null,
 		beforeLoad: null,
+		create: null,
 		disable: null,
 		enable: null,
 		load: null,

tests/unit/tooltip/tooltip_defaults.js

@@ -1,16 +1,15 @@
-/*
+commonWidgetTests( "tooltip", {
- * tooltip_defaults.js
+	defaults: {
- */
+		disabled: false,
+		items: "[title]",
+		content: $.ui.tooltip.prototype.options.content,
+		position: {
+			my: "left center",
+			at: "right center",
+			offset: "15 0"
+		},
 
-var tooltip_defaults = {
+		// callbacks
-	disabled: false,
+		create: null
-	items: "[title]",
-	content: $.ui.tooltip.prototype.options.content,
-	position: {
-		my: "left center",
-		at: "right center",
-		offset: "15 0"
 	}
-};
+});
-
-commonWidgetTests('tooltip', { defaults: tooltip_defaults });

tests/unit/widget/widget_core.js

@@ -202,6 +202,7 @@ test( "merge multiple option arguments", function() {
 	$.widget( "ui.testWidget", {
 		_create: function() {
 			same( this.options, {
+				create: null,
 				disabled: false,
 				option1: "value1",
 				option2: "value2",
@@ -249,6 +250,7 @@ test( "._getCreateOptions()", function() {
 		},
 		_create: function() {
 			same( this.options, {
+				create: null,
 				disabled: false,
 				option1: "override1",
 				option2: "value2",
@@ -418,6 +420,7 @@ test( ".option() - getter", function() {
 
 	var options = div.testWidget( "option" );
 	same( options, {
+		create: null,
 		disabled: false,
 		foo: "bar",
 		baz: 5,

ui/jquery.ui.widget.js

@@ -155,7 +155,10 @@ $.Widget.prototype = {
 	widgetEventPrefix: "",
 	defaultElement: "<div>",
 	options: {
-		disabled: false
+		disabled: false,
+
+		// callbacks
+		create: null
 	},
 	_createWidget: function( options, element ) {
 		element = $( element || this.defaultElement || this )[ 0 ];