library-mirrors/jquery-ui
1
0
Fork 0
mirror of https://github.com/jquery/jquery-ui.git synced 2024-11-21 11:04:24 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Tests: Solve a frequent race condition in tests in Chrome/Safari

Browse Source 
Closes gh-1916
This commit is contained in:
Michał Gołębiowski-Owczarek 2020-05-16 08:28:26 +02:00 committed by GitHub
parent d37ebc624d
commit 579bedd7d2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
tests/unit/sortable/options.js
View File

@ -372,7 +372,8 @@ test("{ placeholder: false }, default", function() {
QUnit.test( "{ placeholder: false } img", function( assert ) { QUnit.test( "{ placeholder: false } img", function( assert ) {
assert.expect( 3 ); assert.expect( 3 );
var element = $( "#sortable-images" ).sortable( { var done = assert.async(),
element = $( "#sortable-images" ).sortable( {
start: function( event, ui ) { start: function( event, ui ) {
assert.ok( ui.placeholder.attr( "src" ).indexOf( "images/jqueryui_32x32.png" ) > 0, "placeholder img has correct src" ); assert.ok( ui.placeholder.attr( "src" ).indexOf( "images/jqueryui_32x32.png" ) > 0, "placeholder img has correct src" );
assert.equal( ui.placeholder.height(), 32, "placeholder has correct height" ); assert.equal( ui.placeholder.height(), 32, "placeholder has correct height" );
@ -380,9 +381,14 @@ QUnit.test( "{ placeholder: false } img", function( assert ) {
} }
} ); } );
// Give browsers some time to load the image if cache is disabled.
// This resolves a frequent issue in Chrome/Safari.
setTimeout( function() {
element.find( "img" ).eq( 0 ).simulate( "drag", { element.find( "img" ).eq( 0 ).simulate( "drag", {
dy: 1 dy: 1
} ); } );
done();
}, 500 );
} ); } );
QUnit.test( "{ placeholder: String }", function( assert ) { QUnit.test( "{ placeholder: String }", function( assert ) {