library-mirrors/jquery-ui
1
0
Fork 0
mirror of https://github.com/jquery/jquery-ui.git synced 2024-10-05 01:44:18 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Update Widget data naming/usage. Remove unnecessary fallbacks, update .removeData to use full name.

Browse Source
This commit is contained in:
Jörn Zaefferer 2012-03-01 15:03:30 +01:00
parent d901cd4160
commit 5e51b8db28
2 changed files with 7 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
tests/unit/widget/widget_core.js
View File

@ -82,7 +82,7 @@ test( "custom selector expression", function() {
});
test( "jQuery usage", function() {
expect( 15 );
expect( 16 );
var shouldCreate = false;
@ -140,6 +140,9 @@ test( "jQuery usage", function() {
ret = elem.testWidget( "jQueryObject" );
equal( ret[ 0 ], document.body, "returned jQuery object" );
equal( ret.end(), elem, "stack preserved" );
elem.testWidget( "destroy" );
equal( elem.data( "ui-testWidget" ), null );
});
test( "direct usage", function() {

10
ui/jquery.ui.widget.js vendored
View File

@ -163,9 +163,7 @@ $.widget.bridge = function( name, object ) {
if ( isMethodCall ) {
this.each(function() {
// 1.9 BC for #7810
// TODO remove fallback to name
var instance = $.data( this, fullName ) || $.data( this, name );
var instance = $.data( this, fullName );
if ( !instance ) {
return $.error( "cannot call methods on " + name + " prior to initialization; " +
"attempted to call method '" + options + "'" );
@ -183,9 +181,7 @@ $.widget.bridge = function( name, object ) {
});
} else {
this.each(function() {
// 1.9 BC for #7810
// TODO remove fallback to name
var instance = $.data( this, fullName ) || $.data( this, name );
var instance = $.data( this, fullName );
if ( instance ) {
instance.option( options || {} )._init();
} else {
@ -252,7 +248,7 @@ $.Widget.prototype = {
// all event bindings should go through this._bind()
this.element
.unbind( "." + this.widgetName )
.removeData( this.widgetName );
.removeData( this.widgetFullName );
this.widget()
.unbind( "." + this.widgetName )
.removeAttr( "aria-disabled" )