library-mirrors/jquery-ui
1
0
Fork 0
mirror of https://github.com/jquery/jquery-ui.git synced 2024-11-21 11:04:24 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Slider: Modified to allow value to reach max value with float step

Browse Source 
Fixes #11286
Closes gh-1465
This commit is contained in:
Ablay Keldibek 2015-03-04 18:23:17 +06:00 committed by Scott González
parent af4c35df9d
commit 60c00cd4ec
2 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
tests/unit/slider/slider_methods.js
View File

@ -62,7 +62,7 @@ test( "disable", function() {
}); });
test( "value", function() { test( "value", function() {
expect( 17 ); expect( 18 );
$( [ false, "min", "max" ] ).each(function() { $( [ false, "min", "max" ] ).each(function() {
var element = $( "<div></div>" ).slider({ var element = $( "<div></div>" ).slider({
range: this, range: this,
@ -88,6 +88,16 @@ test( "value", function() {
equal( element.slider( "value" ), 1, "value method get respects max" ); equal( element.slider( "value" ), 1, "value method get respects max" );
equal( element.slider( "value", 2 ), element, "value method is chainable" ); equal( element.slider( "value", 2 ), element, "value method is chainable" );
equal( element.slider( "option", "value" ), 1, "value method set respects max" ); equal( element.slider( "option", "value" ), 1, "value method set respects max" );
// set max value with step 0.01
element.slider( "option", {
min: 2,
value: 2,
max: 2.4,
step: 0.01
});
element.slider( "option", "value", 2.4 );
equal( element.slider( "value" ), 2.4, "value is set to max with 0.01 step" );
}); });
//test( "values", function() { //test( "values", function() {

2
ui/slider.js
View File

@ -558,7 +558,7 @@ return $.widget( "ui.slider", $.ui.mouse, {
var max = this.options.max, var max = this.options.max,
min = this._valueMin(), min = this._valueMin(),
step = this.options.step, step = this.options.step,
aboveMin = Math.floor( ( max - min ) / step ) * step; aboveMin = Math.floor( ( +( max - min ).toFixed( this._precision() ) ) / step ) * step;
max = aboveMin + min; max = aboveMin + min;
this.max = parseFloat( max.toFixed( this._precision() ) ); this.max = parseFloat( max.toFixed( this._precision() ) );
}, },