From 639da64b3482fd717f76fb7d36e8d43d3b584945 Mon Sep 17 00:00:00 2001 From: Richard Worth Date: Mon, 23 Feb 2009 12:57:33 +0000 Subject: [PATCH] slider: only return false on handle keydown if one of arrow keys or pgup/down are pressed (otherwise tab is broken) --- ui/ui.slider.js | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/ui/ui.slider.js b/ui/ui.slider.js index ff7d1ce0c..05582e414 100644 --- a/ui/ui.slider.js +++ b/ui/ui.slider.js @@ -88,6 +88,8 @@ $.widget("ui.slider", $.extend({}, $.ui.mouse, { this.handles.keydown(function(event) { + var ret = true; + var index = $(this).data("index.ui-slider-handle"); if (self.options.disabled) @@ -100,6 +102,7 @@ $.widget("ui.slider", $.extend({}, $.ui.mouse, { case $.ui.keyCode.RIGHT: case $.ui.keyCode.DOWN: case $.ui.keyCode.LEFT: + ret = false; if (!self._keySliding) { self._keySliding = true; $(this).addClass("ui-state-active"); @@ -136,7 +139,7 @@ $.widget("ui.slider", $.extend({}, $.ui.mouse, { self._slide(event, index, newVal); - return false; + return ret; }).keyup(function(event) {