library-mirrors/jquery-ui
1
0
Fork 0
mirror of https://github.com/jquery/jquery-ui.git synced 2024-11-21 11:04:24 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Spinner: Fixed double firing of change event when setting the value option directly.

Browse Source
This commit is contained in:
Scott González 2011-08-07 12:38:01 -04:00
parent 6c9dac29a5
commit 6c84531d7c
2 changed files with 8 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
demos/spinner/default.html
View File

@ -6,6 +6,7 @@
<link type="text/css" href="../../themes/base/jquery.ui.all.css" rel="stylesheet" /> <link type="text/css" href="../../themes/base/jquery.ui.all.css" rel="stylesheet" />
<script type="text/javascript" src="../../jquery-1.6.2.js"></script> <script type="text/javascript" src="../../jquery-1.6.2.js"></script>
<script type="text/javascript" src="../../external/jquery.mousewheel-3.0.4.js"></script> <script type="text/javascript" src="../../external/jquery.mousewheel-3.0.4.js"></script>
<script type="text/javascript" src="../../external/jquery.global.js"></script>
<script type="text/javascript" src="../../ui/jquery.ui.core.js"></script> <script type="text/javascript" src="../../ui/jquery.ui.core.js"></script>
<script type="text/javascript" src="../../ui/jquery.ui.widget.js"></script> <script type="text/javascript" src="../../ui/jquery.ui.widget.js"></script>
<script type="text/javascript" src="../../ui/jquery.ui.button.js"></script> <script type="text/javascript" src="../../ui/jquery.ui.button.js"></script>
@ -13,7 +14,11 @@
<link type="text/css" href="../demos.css" rel="stylesheet" /> <link type="text/css" href="../demos.css" rel="stylesheet" />
<script type="text/javascript"> <script type="text/javascript">
$(function() { $(function() {
$("#spinner").spinner(); $("#spinner").spinner({
change: function() {
console.log( "change" );
}
});
$("#disable").toggle(function() { $("#disable").toggle(function() {
$("#spinner").spinner("disable"); $("#spinner").spinner("disable");

11
ui/jquery.ui.spinner.js vendored
View File

@ -287,7 +287,7 @@ $.widget( "ui.spinner", {
_setOption: function( key, value ) { _setOption: function( key, value ) {
if ( key === "value" ) { if ( key === "value" ) {
return this._setOptionValue( value ); return this._value( value );
} }
this._super( "_setOption", key, value ); this._super( "_setOption", key, value );
@ -303,14 +303,6 @@ $.widget( "ui.spinner", {
} }
}, },
_setOptionValue: function( value ) {
var previous = this.options.value;
this._value( value );
if ( previous !== this.options.value ) {
this._trigger( "change" );
}
},
_setOptions: modifier(function( options ) { _setOptions: modifier(function( options ) {
this._super( "_setOptions", options ); this._super( "_setOptions", options );
@ -342,6 +334,7 @@ $.widget( "ui.spinner", {
_value: function( value ) { _value: function( value ) {
this.options.value = this._trimValue( this._parse(value) ); this.options.value = this._trimValue( this._parse(value) );
this._format(); this._format();
this._aria();
}, },
destroy: function() { destroy: function() {