Fixes #6979 - Several components are leaking variables into the global scope.

This commit is contained in:
felix 2012-03-29 14:59:19 -07:00 committed by Scott González
parent c45911c98d
commit 6fb584e700
5 changed files with 5 additions and 6 deletions

View File

@ -419,7 +419,7 @@ $.extend($.effects, {
setTransition: function(element, list, factor, value) { setTransition: function(element, list, factor, value) {
value = value || {}; value = value || {};
$.each(list, function(i, x){ $.each(list, function(i, x){
unit = element.cssUnit(x); var unit = element.cssUnit(x);
if (unit[0] > 0) value[x] = unit[0] * factor + unit[1]; if (unit[0] > 0) value[x] = unit[0] * factor + unit[1];
}); });
return value; return value;

View File

@ -15,8 +15,8 @@
$.effects.pulsate = function(o) { $.effects.pulsate = function(o) {
return this.queue(function() { return this.queue(function() {
var elem = $(this), var elem = $(this),
mode = $.effects.setMode(elem, o.options.mode || 'show'); mode = $.effects.setMode(elem, o.options.mode || 'show'),
times = ((o.options.times || 5) * 2) - 1; times = ((o.options.times || 5) * 2) - 1,
duration = o.duration ? o.duration / 2 : $.fx.speeds._default / 2, duration = o.duration ? o.duration / 2 : $.fx.speeds._default / 2,
isVisible = elem.is(':visible'), isVisible = elem.is(':visible'),
animateTo = 0; animateTo = 0;

View File

@ -140,7 +140,7 @@ $.effects.size = function(o) {
hProps = hProps.concat(['marginLeft','marginRight']); // Add margins hProps = hProps.concat(['marginLeft','marginRight']); // Add margins
props2 = props.concat(vProps).concat(hProps); // Concat props2 = props.concat(vProps).concat(hProps); // Concat
el.find("*[width]").each(function(){ el.find("*[width]").each(function(){
child = $(this); var child = $(this);
if (restore) $.effects.save(child, props2); if (restore) $.effects.save(child, props2);
var c_original = {height: child.height(), width: child.width()}; // Save original var c_original = {height: child.height(), width: child.width()}; // Save original
child.from = {height: c_original.height * factor.from.y, width: c_original.width * factor.from.x}; child.from = {height: c_original.height * factor.from.y, width: c_original.width * factor.from.x};

View File

@ -594,7 +594,7 @@ $.widget("ui.menu", {
} }
var base = this.active.offset().top, var base = this.active.offset().top,
height = this.element.height(); height = this.element.height(),
result = this.element.children(".ui-menu-item").filter(function() { result = this.element.children(".ui-menu-item").filter(function() {
var close = $(this).offset().top - base + height - $(this).height(); var close = $(this).offset().top - base + height - $(this).height();
// TODO improve approximation // TODO improve approximation

View File

@ -733,7 +733,6 @@ $.extend( $.ui.tabs.prototype, {
} }
} }
: function( e ) { : function( e ) {
t = o.selected;
rotate(); rotate();
}); });