library-mirrors/jquery-ui
1
0
Fork 0
mirror of https://github.com/jquery/jquery-ui.git synced 2025-01-07 20:34:24 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Controlgroup: Rename excludeInvisible to onlyVisible

Browse Source 
Gets rid of the double negative.
This commit is contained in:
Jörn Zaefferer 2015-09-30 15:38:42 +02:00 committed by Alexander Schmitz
parent 42daa77f90
commit 6fc2cb3c7c
4 changed files with 11 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tests/unit/controlgroup/common.js
View File

@ -17,7 +17,7 @@ common.testWidget( "controlgroup", {
"controlgroupLabel": ".ui-controlgroup-label" "controlgroupLabel": ".ui-controlgroup-label"
}, },
direction: "horizontal", direction: "horizontal",
excludeInvisible: true, onlyVisible: true,
classes: {}, classes: {},
// Callbacks // Callbacks

6
tests/unit/controlgroup/methods.js
View File

@ -83,7 +83,7 @@ $.each( tests, function( widget, html ) {
} }
// Hide each element and check the corner classes // Hide each element and check the corner classes
function iterateHidden( excludeInvisible ) { function iterateHidden( onlyVisible ) {
for ( i = 0; i < 4; i++ ) { for ( i = 0; i < 4; i++ ) {
$( controls ).each( showElements ); $( controls ).each( showElements );
@ -91,7 +91,7 @@ $.each( tests, function( widget, html ) {
controls[ i ][ widget ]( "widget" ).hide(); controls[ i ][ widget ]( "widget" ).hide();
currentClasses = classes.slice( 0 ); currentClasses = classes.slice( 0 );
if ( excludeInvisible ) { if ( onlyVisible ) {
if ( i === 0 ) { if ( i === 0 ) {
currentClasses[ i + 1 ] = classes[ i ]; currentClasses[ i + 1 ] = classes[ i ];
currentClasses[ i ] = false; currentClasses[ i ] = false;
@ -128,7 +128,7 @@ $.each( tests, function( widget, html ) {
iterateHidden( true ); iterateHidden( true );
// Set the exclude option to false so we no longer care about hidden // Set the exclude option to false so we no longer care about hidden
element.controlgroup( "option", "excludeInvisible", false ); element.controlgroup( "option", "onlyVisible", false );
// Iterate hiding the elements again and check their corner classes // Iterate hiding the elements again and check their corner classes
iterateHidden(); iterateHidden();

10
tests/unit/controlgroup/options.js
View File

@ -73,21 +73,21 @@ test( "items: custom widget", function() {
"Custom widget called" ); "Custom widget called" );
} ); } );
test( "excludeInvisible", function( assert ) { test( "onlyVisible", function( assert ) {
expect( 4 ); expect( 4 );
var element = $( ".controlgroup" ).controlgroup( { var element = $( ".controlgroup" ).controlgroup( {
excludeInvisible: false onlyVisible: false
} ), } ),
buttons = element.children( ".ui-button" ); buttons = element.children( ".ui-button" );
assert.lacksClassStart( buttons.eq( 1 ), "ui-corner" ); assert.lacksClassStart( buttons.eq( 1 ), "ui-corner" );
assert.hasClasses( buttons.eq( 0 ), "ui-corner-left", assert.hasClasses( buttons.eq( 0 ), "ui-corner-left",
"ExcludeInvisible: false: First button hidden second button doesn't get a corner class" ); "onlyVisible: false: First button hidden second button doesn't get a corner class" );
element.controlgroup( "option", "excludeInvisible", true ); element.controlgroup( "option", "onlyVisible", true );
assert.lacksClassStart( buttons.eq( 0 ), "ui-corner" ); assert.lacksClassStart( buttons.eq( 0 ), "ui-corner" );
assert.hasClasses( buttons.eq( 1 ), "ui-corner-left", assert.hasClasses( buttons.eq( 1 ), "ui-corner-left",
"ExcludeInvisible: true: First button is hidden second button get corner class" ); "onlyVisible: true: First button is hidden second button get corner class" );
} ); } );
test( "direction", function( assert ) { test( "direction", function( assert ) {

4
ui/widgets/controlgroup.js
View File

@ -36,7 +36,7 @@ return $.widget( "ui.controlgroup", {
options: { options: {
direction: "horizontal", direction: "horizontal",
disabled: null, disabled: null,
excludeInvisible: true, onlyVisible: true,
items: { items: {
"button": "input[type=button], input[type=submit], input[type=reset], button, a", "button": "input[type=button], input[type=submit], input[type=reset], button, a",
"controlgroupLabel": ".ui-controlgroup-label", "controlgroupLabel": ".ui-controlgroup-label",
@ -209,7 +209,7 @@ return $.widget( "ui.controlgroup", {
children = this.childWidgets; children = this.childWidgets;
// We filter here because we need to track all childWidgets not just the visible ones // We filter here because we need to track all childWidgets not just the visible ones
if ( this.options.excludeInvisible ) { if ( this.options.onlyVisible ) {
children = children.filter( ":visible" ); children = children.filter( ":visible" );
} }