Autocomplete: Added appendTo option. Fixes #5836 - Autocomplete: add appendTo option.

This commit is contained in:
Scott González 2010-07-21 14:54:20 -04:00
parent 245b932933
commit 74e0d4f473
4 changed files with 39 additions and 4 deletions

View File

@ -36,8 +36,8 @@
<div id="main" style="position: absolute; top: -10000px; left: -10000px;"> <div id="main" style="position: absolute; top: -10000px; left: -10000px;">
<div><input id="autocomplete" class="foo" /></div> <div id="ac-wrap1" class="ac-wrap"></div>
<div id="ac-wrap2" class="ac-wrap"><input id="autocomplete" class="foo" /></div>
</div> </div>
</body> </body>

View File

@ -3,6 +3,7 @@
*/ */
var autocomplete_defaults = { var autocomplete_defaults = {
appendTo: "body",
delay: 300, delay: 300,
disabled: false, disabled: false,
minLength: 1, minLength: 1,

View File

@ -68,6 +68,36 @@ test("cache: false", function() {
var data = ["c++", "java", "php", "coldfusion", "javascript", "asp", "ruby", "python", "c", "scala", "groovy", "haskell", "perl"]; var data = ["c++", "java", "php", "coldfusion", "javascript", "asp", "ruby", "python", "c", "scala", "groovy", "haskell", "perl"];
test( "appendTo", function() {
var ac = $( "#autocomplete" ).autocomplete();
same( ac.autocomplete( "widget" ).parent()[0], document.body, "defaults to body" );
ac.autocomplete( "destroy" );
ac.autocomplete({
appendTo: "#ac-wrap2"
});
same( ac.autocomplete( "widget" ).parent()[0], $( "#ac-wrap2" )[0], "id" );
ac.autocomplete( "destroy" );
ac.autocomplete({
appendTo: ".ac-wrap"
});
same( ac.autocomplete( "widget" ).parent()[0], $( "#ac-wrap1" )[0], "class" );
same( $( "#ac-wrap2 .ui-autocomplete").length, 0, "class - only appends to one element")
ac.autocomplete( "destroy" );
ac.autocomplete({
appendTo: null
});
same( ac.autocomplete( "widget" ).parent()[0], document.body, "null" );
ac.autocomplete( "destroy" );
ac.autocomplete().autocomplete( "option", "appendTo", "#ac-wrap1" );
same( ac.autocomplete( "widget" ).parent()[0], $( "#ac-wrap1" )[0], "modified after init" );
ac.autocomplete( "destroy" );
});
test("delay", function() { test("delay", function() {
var ac = $("#autocomplete").autocomplete({ var ac = $("#autocomplete").autocomplete({
source: data, source: data,

View File

@ -16,6 +16,7 @@
$.widget( "ui.autocomplete", { $.widget( "ui.autocomplete", {
options: { options: {
appendTo: "body",
delay: 300, delay: 300,
minLength: 1, minLength: 1,
position: { position: {
@ -104,7 +105,7 @@ $.widget( "ui.autocomplete", {
}; };
this.menu = $( "<ul></ul>" ) this.menu = $( "<ul></ul>" )
.addClass( "ui-autocomplete" ) .addClass( "ui-autocomplete" )
.appendTo( "body", doc ) .appendTo( $( this.options.appendTo || "body", doc )[0] )
// prevent the close-on-blur in case of a "slow" click on the menu (long mousedown) // prevent the close-on-blur in case of a "slow" click on the menu (long mousedown)
.mousedown(function() { .mousedown(function() {
// use another timeout to make sure the blur-event-handler on the input was already triggered // use another timeout to make sure the blur-event-handler on the input was already triggered
@ -166,11 +167,14 @@ $.widget( "ui.autocomplete", {
$.Widget.prototype.destroy.call( this ); $.Widget.prototype.destroy.call( this );
}, },
_setOption: function( key ) { _setOption: function( key, value ) {
$.Widget.prototype._setOption.apply( this, arguments ); $.Widget.prototype._setOption.apply( this, arguments );
if ( key === "source" ) { if ( key === "source" ) {
this._initSource(); this._initSource();
} }
if ( key === "appendTo" ) {
this.menu.element.appendTo( $( value || "body", this.element.ownerDocument )[0] )
}
}, },
_initSource: function() { _initSource: function() {