library-mirrors/jquery-ui
1
0
Fork 0
mirror of https://github.com/jquery/jquery-ui.git synced 2025-01-07 20:34:24 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Draggable: Only apply ui-draggable-handle within the draggable instance

Browse Source 
Fixes #10212
Closes gh-1284
This commit is contained in:
TJ VanToll 2014-07-15 13:38:00 -04:00
parent 2447cabd59
commit 7594a31425
2 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
tests/unit/draggable/draggable_core.js
View File

@ -274,15 +274,19 @@ asyncTest( "#4261: active element should blur when mousing down on a draggable",
});
test( "ui-draggable-handle assigned to appropriate element", function() {
expect( 4 );
expect( 5 );
var element = $( "<div><p></p></div>" ).appendTo( "#qunit-fixture" ).draggable();
var p = $( "<p>" ).appendTo( "#qunit-fixture" ),
element = $( "<div><p></p></div>" ).appendTo( "#qunit-fixture" ).draggable();
ok( element.hasClass( "ui-draggable-handle" ), "handle is element by default" );
element.draggable( "option", "handle", "p" );
ok( !element.hasClass( "ui-draggable-handle" ), "removed from element" );
ok( element.find( "p" ).hasClass( "ui-draggable-handle" ), "added to handle" );
ok( !p.hasClass( "ui-draggable-handle" ),
"ensure handle class name is constrained within the draggble (#10212)" );
element.draggable( "destroy" );
ok( !element.find( "p" ).hasClass( "ui-draggable-handle" ), "removed in destroy()" );
});

4
ui/draggable.js
View File

@ -314,8 +314,10 @@ $.widget("ui.draggable", $.ui.mouse, {
},
_setHandleClassName: function() {
var handle = this.options.handle ?
this.element.find( this.options.handle ) : this.element;
this._removeHandleClassName();
$( this.options.handle || this.element ).addClass( "ui-draggable-handle" );
handle.addClass( "ui-draggable-handle" );
},
_removeHandleClassName: function() {