library-mirrors/jquery-ui
1
0
Fork 0
mirror of https://github.com/jquery/jquery-ui.git synced 2024-11-21 11:04:24 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Tabs: Allow non-latin characters for ids. Fixes #4581 - title attribute for remote tabs does not support foreign languages.

Browse Source
This commit is contained in:
Scott González 2010-09-03 11:35:10 -04:00
parent ddb9a783a8
commit 78540e2c0c
3 changed files with 13 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
tests/unit/tabs/tabs.html
View File

@ -61,6 +61,7 @@
<li><a href="#colon:test"><span>1</span></a></li> <li><a href="#colon:test"><span>1</span></a></li>
<li><a href="#inline-style"><span>2</span></a></li> <li><a href="#inline-style"><span>2</span></a></li>
<li><a href="data/test.html#test"><span>3</span></a></li> <li><a href="data/test.html#test"><span>3</span></a></li>
<li><a href="data/test.html" title="∫ßáö Սե"<span>4</span></a></li>
</ul> </ul>
<div id="colon:test"></div> <div id="colon:test"></div>
<div style="height: 300px;" id="inline-style"></div> <div style="height: 300px;" id="inline-style"></div>

12
tests/unit/tabs/tabs_tickets.js
View File

@ -70,7 +70,6 @@ test('#5069 - ui.tabs.add creates two tab panels when using a full URL', functio
}); });
test('#5893 - Sublist in the tab list are considered as tab', function() { test('#5893 - Sublist in the tab list are considered as tab', function() {
// http://dev.jqueryui.com/ticket/5893 // http://dev.jqueryui.com/ticket/5893
expect(1); expect(1);
@ -80,5 +79,16 @@ test('#5893 - Sublist in the tab list are considered as tab', function() {
}); });
asyncTest( "#4581 - title attribute for remote tabs does not support foreign languages", function() {
expect( 1 );
$( "#tabs2" ).tabs({
selected: 3,
load: function( event, ui ) {
equal( ui.panel.id, "∫ßáö_Սե", "proper title" );
start();
}
});
});
})(jQuery); })(jQuery);

2
ui/jquery.ui.tabs.js vendored
View File

@ -63,7 +63,7 @@ $.widget( "ui.tabs", {
}, },
_tabId: function( a ) { _tabId: function( a ) {
return a.title && a.title.replace( /\s/g, "_" ).replace( /[^A-Za-z0-9\-_:\.]/g, "" ) || return a.title && a.title.replace( /\s/g, "_" ).replace( /[^\w\u00c0-\uFFFF-]/g, "" ) ||
this.options.idPrefix + getNextTabId(); this.options.idPrefix + getNextTabId();
}, },