library-mirrors/jquery-ui
1
0
Fork 0
mirror of https://github.com/jquery/jquery-ui.git synced 2024-11-21 11:04:24 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Dialog: Fix IE tests about interactions with other dialogs

Browse Source 
The workaround triggering a second delayed focus to a tabbable element was
applied in jQueries 3.4 & 3.5 to fix IE issues. It also needs to be applied
in jQuery 3.6 which this commit adds.

This will no longer be needed in jQuery 3.7 and jQuery 3.x-git tests are
already passing because of that.

Closes gh-2160
This commit is contained in:
Michał Gołębiowski-Owczarek 2023-05-10 10:55:40 +02:00 committed by GitHub
parent 020828e7ff
commit 7adb13ac7c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
ui/widgets/dialog.js
View File

@ -881,12 +881,15 @@ $.widget( "ui.dialog", {
event.preventDefault(); event.preventDefault();
instance._focusTabbable(); instance._focusTabbable();
// Support: jQuery >=3.4 <3.6 only // Support: jQuery >=3.4 <3.7 only
// Focus re-triggering in jQuery 3.4/3.5 makes the original element // In jQuery 3.4-3.6, there are multiple issues with focus/blur
// have its focus event propagated last, breaking the re-targeting. // trigger chains or when triggering is done on a hidden element
// Trigger focus in a delay in addition if needed to avoid the issue // at least once.
// Trigger focus in a delay in addition if needed to avoid the issues.
// See https://github.com/jquery/jquery/issues/4382 // See https://github.com/jquery/jquery/issues/4382
if ( jqMinor === "3.4." || jqMinor === "3.5." ) { // See https://github.com/jquery/jquery/issues/4856
// See https://github.com/jquery/jquery/issues/4950
if ( jqMinor === "3.4." || jqMinor === "3.5." || jqMinor === "3.6." ) {
instance._delay( instance._restoreTabbableFocus ); instance._delay( instance._restoreTabbableFocus );
} }
} }