library-mirrors/jquery-ui
1
0
Fork 0
mirror of https://github.com/jquery/jquery-ui.git synced 2024-11-21 11:04:24 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

sortable: Use addClass in _setHandleClassName to improve performance

Browse Source 
This addresses #2062 and is relevant for large lists with more than 1000 items.
The solution to the issue was suggested at
https://stackoverflow.com/a/46925710/1119601 (credits to @Ernst).

At the end this commit restores the function's behaviour of previous 1.11.x
version.
This commit is contained in:
naitsirch 2022-03-31 09:25:21 +02:00
parent e21a2543b5
commit 7e7a6c4a0d
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
ui/widgets/sortable.js
View File

@ -118,19 +118,19 @@ return $.widget( "ui.sortable", $.ui.mouse, {
}, },
_setHandleClassName: function() { _setHandleClassName: function() {
var that = this;
this._removeClass( this.element.find( ".ui-sortable-handle" ), "ui-sortable-handle" ); this._removeClass( this.element.find( ".ui-sortable-handle" ), "ui-sortable-handle" );
$.each( this.items, function() { $.each( this.items, function() {
that._addClass(
this.instance.options.handle ? // We use addClass() here, instead of _addClass(), because it is much faster.
( this.instance.options.handle ?
this.item.find( this.instance.options.handle ) : this.item.find( this.instance.options.handle ) :
this.item, this.item
"ui-sortable-handle" ).addClass( "ui-sortable-handle" );
);
} ); } );
}, },
_destroy: function() { _destroy: function() {
this.element.find( ".ui-sortable-handle" ).removeClass( "ui-sortable-handle" );
this._mouseDestroy(); this._mouseDestroy();
for ( var i = this.items.length - 1; i >= 0; i-- ) { for ( var i = this.items.length - 1; i >= 0; i-- ) {