library-mirrors/jquery-ui
1
0
Fork 0
mirror of https://github.com/jquery/jquery-ui.git synced 2024-11-21 11:04:24 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Datepicker: Fixed current instance memory leak and added unit testcases

Browse Source
This commit is contained in:
jigar gala 2018-02-01 01:15:58 +05:30 committed by Felix Nagel
parent 0c860b0d92
commit 817ce38555
2 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
tests/unit/datepicker/methods.js
View File

@ -8,8 +8,17 @@ define( [
QUnit.module( "datepicker: methods" ); QUnit.module( "datepicker: methods" );
QUnit.test( "destroy", function( assert ) { QUnit.test( "destroy", function( assert ) {
assert.expect( 33 ); assert.expect( 35 );
var inl, var inl,
inp = testHelper.init( "#inp" ),
dp = $( "#ui-datepicker-div" );
// Destroy and clear active reference
inp.datepicker( "show" );
assert.equal( dp.css( "display" ), "block", "Datepicker - visible" );
inp.datepicker( "hide" ).datepicker( "destroy" );
assert.ok( $.datepicker._curInst == null, "Datepicker - destroyed and cleared reference" );
inp = testHelper.init( "#inp" ); inp = testHelper.init( "#inp" );
assert.ok( inp.is( ".hasDatepicker" ), "Default - marker class set" ); assert.ok( inp.is( ".hasDatepicker" ), "Default - marker class set" );
assert.ok( $.data( inp[ 0 ], testHelper.PROP_NAME ), "Default - instance present" ); assert.ok( $.data( inp[ 0 ], testHelper.PROP_NAME ), "Default - instance present" );

1
ui/widgets/datepicker.js
View File

@ -408,6 +408,7 @@ $.extend( Datepicker.prototype, {
if ( datepicker_instActive === inst ) { if ( datepicker_instActive === inst ) {
datepicker_instActive = null; datepicker_instActive = null;
this._curInst = null;
} }
}, },