library-mirrors/jquery-ui
1
0
Fork 0
mirror of https://github.com/jquery/jquery-ui.git synced 2024-11-21 11:04:24 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Slider: Properly handle value and value methods as setters. Fixes #4881 - Slider: value and values methods as setters aren't chainable.

Browse Source 
(cherry picked from commit 2197c61f1f)
This commit is contained in:
Scott González 2011-03-28 17:34:04 -04:00
parent eb3d955438
commit 8310d185b3
2 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
tests/unit/slider/slider_methods.js
View File

@ -74,7 +74,7 @@ test("value", function() {
value: 5 value: 5
}); });
equals(el.slider('value'), 5, 'range: ' + this + ' slider method get'); equals(el.slider('value'), 5, 'range: ' + this + ' slider method get');
el.slider('value', 10); equals(el.slider('value', 10), el, 'value method is chainable');
equals(el.slider('value'), 10, 'range: ' + this + ' slider method set'); equals(el.slider('value'), 10, 'range: ' + this + ' slider method set');
el.remove(); el.remove();
}); });
@ -85,13 +85,13 @@ test("value", function() {
el.slider('option', 'value', -2); el.slider('option', 'value', -2);
equals(el.slider('option', 'value'), -2, 'value option does not respect min'); equals(el.slider('option', 'value'), -2, 'value option does not respect min');
equals(el.slider('value'), -1, 'value method get respects min'); equals(el.slider('value'), -1, 'value method get respects min');
el.slider('value', -2); equals(el.slider('value', -2), el, 'value method is chainable');
equals(el.slider('option', 'value'), -1, 'value method set respects min'); equals(el.slider('option', 'value'), -1, 'value method set respects min');
// max with value option vs value method // max with value option vs value method
el.slider('option', 'value', 2); el.slider('option', 'value', 2);
equals(el.slider('option', 'value'), 2, 'value option does not respect max'); equals(el.slider('option', 'value'), 2, 'value option does not respect max');
equals(el.slider('value'), 1, 'value method get respects max'); equals(el.slider('value'), 1, 'value method get respects max');
el.slider('value', 2); equals(el.slider('value', 2), el, 'value method is chainable');
equals(el.slider('option', 'value'), 1, 'value method set respects max'); equals(el.slider('option', 'value'), 1, 'value method set respects max');
}); });

2
ui/jquery.ui.slider.js vendored
View File

@ -466,6 +466,7 @@ $.widget( "ui.slider", $.ui.mouse, {
this.options.value = this._trimAlignValue( newValue ); this.options.value = this._trimAlignValue( newValue );
this._refreshValue(); this._refreshValue();
this._change( null, 0 ); this._change( null, 0 );
return;
} }
return this._value(); return this._value();
@ -480,6 +481,7 @@ $.widget( "ui.slider", $.ui.mouse, {
this.options.values[ index ] = this._trimAlignValue( newValue ); this.options.values[ index ] = this._trimAlignValue( newValue );
this._refreshValue(); this._refreshValue();
this._change( null, index ); this._change( null, index );
return;
} }
if ( arguments.length ) { if ( arguments.length ) {