From 87656cdf576f1b56dbd6cd731d3830a993c42d26 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Go=C5=82=C4=99biowski-Owczarek?= Date: Sat, 25 Sep 2021 21:20:06 +0200 Subject: [PATCH] Theme: Fix blank icons having a background A fix from 43254468de7d69b5422e667ba7ebbe864fc34a63 introduced a rule setting `background-image` of a blank icon to none. However, the selector used for that rule had lower specificity than another one: `.ui-button .ui-icon` which caused dashes being shown over the icons. We needed to increase the specificity of the `.ui-icon-blank` rule past the above selector and past `.ui-button:hover .ui-icon`. We're doing it by repeating the class name three times. Closes gh-1987 --- themes/base/theme.css | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/themes/base/theme.css b/themes/base/theme.css index ad6f5004b..192624a11 100644 --- a/themes/base/theme.css +++ b/themes/base/theme.css @@ -220,7 +220,10 @@ a.ui-button:active, } /* positioning */ -html .ui-icon-blank { background-image: none; } +/* Three classes needed to override `.ui-button:hover .ui-icon` */ +.ui-icon-blank.ui-icon-blank.ui-icon-blank { + background-image: none; +} .ui-icon-caret-1-n { background-position: 0 0; } .ui-icon-caret-1-ne { background-position: -16px 0; } .ui-icon-caret-1-e { background-position: -32px 0; }