library-mirrors/jquery-ui
1
0
Fork 0
mirror of https://github.com/jquery/jquery-ui.git synced 2024-11-21 11:04:24 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Tests: Accept a small difference of animated width/height

Browse Source 
jQuery 3.2 & newer have a different animation logic and the animated elements
width/height differ from the starting ones even at the beginning of the
animation. The point of the assertions checking that they're identical was
to ensure bug #5245 is fixed; that issue manifested by a big jump to half the
element size. To test for that, it's enough to check that the first obtained
values are close to the original ones.

This makes effects tests pass in all supported jQuery versions.

Closes gh-1928
Ref #5245
This commit is contained in:
Michał Gołębiowski-Owczarek 2020-07-23 15:53:36 +02:00 committed by GitHub
parent b8ec78a37a
commit 91037d66b0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
tests/unit/effects/core.js
View File

@ -378,8 +378,10 @@ $.each( $.effects.effect, function( effect ) {
assert.equal( test[ 0 ].style.height, cssHeight, "Inline CSS Height has been rest after animation ended" );
ready();
} );
assert.equal( test.width(), width, "Width is the same px after animation started" );
assert.equal( test.height(), height, "Height is the same px after animation started" );
assert.ok( Math.abs( test.width() - width ) / width < 0.05,
"Width is close to the value when animation started" );
assert.ok( Math.abs( test.height() - height ) / height < 0.05,
"Height is close to the value when animation started" );
} );
} );