library-mirrors/jquery-ui
1
0
Fork 0
mirror of https://github.com/jquery/jquery-ui.git synced 2024-10-05 01:44:18 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Selectmenu: Don't render options with the hidden attribute

Browse Source 
Fixes #15098
This commit is contained in:
Scott González 2016-11-16 12:52:15 -05:00
parent 9a4c057157
commit a2b25ef6ca
2 changed files with 30 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
tests/unit/selectmenu/core.js
View File

@ -376,4 +376,30 @@ QUnit.test( "Number pad input should change value", function( assert ) {
} );
} );
QUnit.test( "Options with hidden attribute should not be rendered", function( assert ) {
var ready = assert.async();
assert.expect( 1 );
var button, menu, options,
element = $( "#speed" );
element.find( "option" ).eq( 1 ).prop( "hidden", true );
element.selectmenu();
button = element.selectmenu( "widget" );
menu = element.selectmenu( "menuWidget" );
button.simulate( "focus" );
setTimeout( function() {
button.trigger( "click" );
options = menu.children()
.map( function() {
return $( this ).text();
} )
.get();
assert.deepEqual( options, [ "Slower", "Medium", "Fast", "Faster" ], "correct elements" );
ready();
} );
} );
} );

4
ui/widgets/selectmenu.js
View File

@ -656,6 +656,10 @@ return $.widget( "ui.selectmenu", [ $.ui.formResetMixin, {
var that = this,
data = [];
options.each( function( index, item ) {
if ( item.hidden ) {
return;
}
data.push( that._parseOption( $( item ), index ) );
} );
this.items = data;