library-mirrors/jquery-ui
1
0
Fork 0
mirror of https://github.com/jquery/jquery-ui.git synced 2024-11-21 11:04:24 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fixes for large data sets

Browse Source 
- Don't bind the element if it already exists
- Use closest instead of parents and remove each for selectable mouseStart event
This commit is contained in:
John Clark 2020-06-11 18:04:38 -04:00
parent e7a10c70ae
commit ad11d34dda
2 changed files with 22 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
ui/widget.js
View File

@ -590,7 +590,9 @@ $.Widget.prototype = {
delegateElement = this.widget(); delegateElement = this.widget();
} else { } else {
element = delegateElement = $( element ); element = delegateElement = $( element );
this.bindings = this.bindings.add( element ); if ( !this.bindings.find(element).length ) {
this.bindings = this.bindings.add( element );
}
} }
$.each( handlers, function( event, handler ) { $.each( handlers, function( event, handler ) {

41
ui/widgets/selectable.js
View File

@ -139,31 +139,28 @@ return $.widget( "ui.selectable", $.ui.mouse, {
} }
} ); } );
$( event.target ).parents().addBack().each( function() { var element = $( event.target ).closest( ":data(selectable-item)" );
var doSelect, if ( element.length ) {
selectee = $.data( this, "selectable-item" ); var selectee = element.data( "selectable-item" ),
if ( selectee ) { doSelect = ( !event.metaKey && !event.ctrlKey) ||
doSelect = ( !event.metaKey && !event.ctrlKey ) ||
!selectee.$element.hasClass( "ui-selected" ); !selectee.$element.hasClass( "ui-selected" );
that._removeClass( selectee.$element, doSelect ? "ui-unselecting" : "ui-selected" ) that._removeClass( selectee.$element, doSelect ? "ui-unselecting" : "ui-selected" )
._addClass( selectee.$element, doSelect ? "ui-selecting" : "ui-unselecting" ); ._addClass( selectee.$element, doSelect ? "ui-selecting" : "ui-unselecting" );
selectee.unselecting = !doSelect; selectee.unselecting = !doSelect;
selectee.selecting = doSelect; selectee.selecting = doSelect;
selectee.selected = doSelect; selectee.selected = doSelect;
// selectable (UN)SELECTING callback // selectable (UN)SELECTING callback
if ( doSelect ) { if ( doSelect ) {
that._trigger( "selecting", event, { that._trigger( "selecting", event, {
selecting: selectee.element selecting: selectee.element
} ); });
} else { } else {
that._trigger( "unselecting", event, { that._trigger( "unselecting", event, {
unselecting: selectee.element unselecting: selectee.element
} ); });
}
return false;
} }
} ); }
}, },