library-mirrors/jquery-ui
1
0
Fork 0
mirror of https://github.com/jquery/jquery-ui.git synced 2024-11-21 11:04:24 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Dialog: Allow for subpixel calculation errors in tests

Browse Source 
Tests were failing in IE 10-11 with values that were off by 0.01 pixels.

Closes gh-1737
This commit is contained in:
Scott González 2016-08-30 14:58:39 -04:00
parent 398bd8dd36
commit d2ce363200
1 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
tests/unit/dialog/helper.js
View File

@ -33,11 +33,8 @@ return $.extend( helper, {
assert.ok( expectedDX - actualDX <= 1 && expectedDY - actualDY <= 1, "dragged[" + expectedDX + ", " + expectedDY + "] " + msg );
},
// TODO switch back to checking the size of the .ui-dialog element (var d)
// once we switch to using box-sizing: border-box (#9845) that should work fine
// using the element's dimensions to avoid subpixel errors
shouldResize: function( assert, element, dw, dh, msg ) {
var heightAfter, widthAfter, actual, expected,
var actualDH, actualDW, heightAfter, widthAfter
d = element.dialog( "widget" ),
handle = $( ".ui-resizable-se", d ),
heightBefore = element.height(),
@ -49,9 +46,13 @@ return $.extend( helper, {
widthAfter = element.width();
msg = msg ? msg + "." : "";
actual = { width: widthAfter, height: heightAfter },
expected = { width: widthBefore + dw, height: heightBefore + dh };
assert.deepEqual( actual, expected, "resized[" + 50 + ", " + 50 + "] " + msg );
actualDH = heightAfter - heightBefore;
actualDW = widthAfter - widthBefore;
// TODO: Switch to assert.close().
// Also change the testDrag() helper.
assert.ok( Math.abs(actualDH - dh) <= 1 && Math.abs(actualDW - dw) <= 1, "resized[50, 50] " + msg );
}
} );