From d569b52838594c3e7e732d31dbf07dc2072edfdb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Scott=20Gonz=C3=A1lez?= Date: Thu, 14 Jun 2012 21:01:14 -0400 Subject: [PATCH] Effects (fade): Delegate hiding and showing to core. Fixes #8267 - dialog fadein broken since 1.9m4. --- ui/jquery.effects.fade.js | 15 ++++----------- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/ui/jquery.effects.fade.js b/ui/jquery.effects.fade.js index 66029b51c..3989ee908 100644 --- a/ui/jquery.effects.fade.js +++ b/ui/jquery.effects.fade.js @@ -14,23 +14,16 @@ $.effects.effect.fade = function( o, done ) { var el = $( this ), - mode = $.effects.setMode( el, o.mode || "toggle" ), - hide = mode === "hide"; + mode = $.effects.setMode( el, o.mode || "toggle" ); - el.show(); el.animate({ - opacity: hide ? 0 : 1 + opacity: mode }, { queue: false, duration: o.duration, easing: o.easing, - complete: function() { - if ( hide ) { - el.hide(); - } - done(); - } + complete: done }); }; -})(jQuery); +})( jQuery );