mirror of
https://github.com/jquery/jquery-ui.git
synced 2024-10-05 01:44:18 +00:00
Dialog: Set the _isOpen flag before triggering the open event. Fixes #6012 - Dialog: _isOpen flag should be set before triggering open event.
This commit is contained in:
parent
5de8ced5d9
commit
de02aa34a8
@ -6,11 +6,12 @@
|
||||
module("dialog: events");
|
||||
|
||||
test("open", function() {
|
||||
expect(11);
|
||||
expect(13);
|
||||
|
||||
el = $("<div></div>");
|
||||
el.dialog({
|
||||
open: function(ev, ui) {
|
||||
ok(el.data("dialog")._isOpen, "interal _isOpen flag is set");
|
||||
ok(true, 'autoOpen: true fires open callback');
|
||||
equals(this, el[0], "context of callback");
|
||||
equals(ev.type, 'dialogopen', 'event type in callback');
|
||||
@ -29,6 +30,7 @@ test("open", function() {
|
||||
same(ui, {}, 'ui hash in callback');
|
||||
}
|
||||
}).bind('dialogopen', function(ev, ui) {
|
||||
ok(el.data("dialog")._isOpen, "interal _isOpen flag is set");
|
||||
ok(true, 'dialog("open") fires open event');
|
||||
equals(this, el[0], 'context of event');
|
||||
same(ui, {}, 'ui hash in event');
|
||||
|
2
ui/jquery.ui.dialog.js
vendored
2
ui/jquery.ui.dialog.js
vendored
@ -329,8 +329,8 @@ $.widget("ui.dialog", {
|
||||
uiDialog.find('.ui-dialog-buttonpane :tabbable').get().concat(
|
||||
uiDialog.get()))).eq(0).focus();
|
||||
|
||||
self._trigger('open');
|
||||
self._isOpen = true;
|
||||
self._trigger('open');
|
||||
|
||||
return self;
|
||||
},
|
||||
|
Loading…
Reference in New Issue
Block a user