library-mirrors/jquery-ui
1
0
Fork 0
mirror of https://github.com/jquery/jquery-ui.git synced 2024-11-21 11:04:24 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Tests: Increase robustness of a draggable revert test

Browse Source 
One of the changes is increasing `revertDuration` from 200 to 300. For some
reason, when jQuery 3.1 is used in an iframe (which TestSwarm uses) the timings
are lower than expected and `setTimeout` too slow and the check for animation
happens too late.

Closes gh-2230
This commit is contained in:
Michał Gołębiowski-Owczarek 2024-04-12 15:23:05 +02:00 committed by GitHub
parent ab2a2a973e
commit e7a0da63ea
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
tests/unit/draggable/options.js
View File

@ -1018,7 +1018,7 @@ QUnit.test( "opacity, default, switching after initialization", function( assert
} ); } );
QUnit.test( "revert and revertDuration", function( assert ) { QUnit.test( "revert and revertDuration", function( assert ) {
var ready = assert.async(); var ready = assert.async( 2 );
assert.expect( 7 ); assert.expect( 7 );
var element = $( "#draggable2" ).draggable( { var element = $( "#draggable2" ).draggable( {
@ -1035,7 +1035,7 @@ QUnit.test( "revert and revertDuration", function( assert ) {
$( "#draggable2" ).draggable( "option", { $( "#draggable2" ).draggable( "option", {
revert: true, revert: true,
revertDuration: 200, revertDuration: 300,
stop: function() { stop: function() {
ready(); ready();
} }
@ -1045,6 +1045,7 @@ QUnit.test( "revert and revertDuration", function( assert ) {
testHelper.move( element, 50, 50 ); testHelper.move( element, 50, 50 );
setTimeout( function() { setTimeout( function() {
assert.ok( $( "#draggable2" ).is( ":animated" ), "revert: true with revertDuration should animate" ); assert.ok( $( "#draggable2" ).is( ":animated" ), "revert: true with revertDuration should animate" );
ready();
} ); } );
} ); } );