library-mirrors/jquery-ui
1
0
Fork 0
mirror of https://github.com/jquery/jquery-ui.git synced 2024-12-07 06:14:24 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Draggable: Ensure sortable revert still works after draggable is removed

Browse Source 
Fixes #9481
This commit is contained in:
Mike Sherov 2014-08-24 21:10:08 -04:00
parent 27ed20715f
commit e8c99b9abf
1 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
ui/draggable.js
View File

@ -713,8 +713,7 @@ $.ui.plugin.add("draggable", "connectToSortable", {
var sortable = $( this ).sortable( "instance" ); var sortable = $( this ).sortable( "instance" );
if (sortable && !sortable.options.disabled) { if (sortable && !sortable.options.disabled) {
inst.sortables.push({ inst.sortables.push({
instance: sortable, instance: sortable
shouldRevert: sortable.options.revert
}); });
sortable.refreshPositions(); // Call the sortable's refreshPositions at drag start to refresh the containerCache since the sortable container cache is used in drag and needs to be up to date (this will ensure it's initialised as well as being kept in step with any changes that might have happened on the page). sortable.refreshPositions(); // Call the sortable's refreshPositions at drag start to refresh the containerCache since the sortable container cache is used in drag and needs to be up to date (this will ensure it's initialised as well as being kept in step with any changes that might have happened on the page).
sortable._trigger("activate", event, uiSortable); sortable._trigger("activate", event, uiSortable);
@ -740,10 +739,6 @@ $.ui.plugin.add("draggable", "connectToSortable", {
inst.cancelHelperRemoval = true; inst.cancelHelperRemoval = true;
this.instance.cancelHelperRemoval = false; this.instance.cancelHelperRemoval = false;
//The sortable revert is supported, and we have to set a temporary dropped variable on the draggable to support revert: "valid/invalid"
if (this.shouldRevert) {
this.instance.options.revert = this.shouldRevert;
}
// Use _storedCSS To restore properties in the sortable, // Use _storedCSS To restore properties in the sortable,
// as this also handles revert (#9675) since the draggable // as this also handles revert (#9675) since the draggable
// may have modified them in unexpected ways (#8809) // may have modified them in unexpected ways (#8809)
@ -859,12 +854,18 @@ $.ui.plugin.add("draggable", "connectToSortable", {
sortable.isOver = 0; sortable.isOver = 0;
sortable.cancelHelperRemoval = true; sortable.cancelHelperRemoval = true;
// Prevent reverting on this forced stop // Calling sortable's mouseStop would trigger a revert,
// so revert must be temporarily false until after mouseStop is called.
sortable.options._revert = sortable.options.revert;
sortable.options.revert = false; sortable.options.revert = false;
sortable._trigger( "out", event, sortable._uiHash( sortable ) ); sortable._trigger( "out", event, sortable._uiHash( sortable ) );
sortable._mouseStop( event, true ); sortable._mouseStop( event, true );
// restore sortable behaviors that were modfied
// when the draggable entered the sortable area (#9481)
sortable.options.revert = sortable.options._revert;
sortable.options.helper = sortable.options._helper; sortable.options.helper = sortable.options._helper;
if ( sortable.placeholder ) { if ( sortable.placeholder ) {