From fb525e1cb10ce5959df28b0cbd29ebdc96c266f4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Scott=20Gonz=C3=A1lez?= Date: Thu, 25 Oct 2012 05:45:18 -0400 Subject: [PATCH] Tabs: Removed select event. Fixes #7154 - Tabs: Remove select event. --- tests/unit/tabs/tabs_common_deprecated.js | 3 +- tests/unit/tabs/tabs_deprecated.js | 40 ----------------------- ui/jquery.ui.tabs.js | 21 ------------ 3 files changed, 1 insertion(+), 63 deletions(-) diff --git a/tests/unit/tabs/tabs_common_deprecated.js b/tests/unit/tabs/tabs_common_deprecated.js index 763e0d84e..0d381f9e9 100644 --- a/tests/unit/tabs/tabs_common_deprecated.js +++ b/tests/unit/tabs/tabs_common_deprecated.js @@ -19,7 +19,6 @@ TestHelpers.commonWidgetTests( "tabs", { beforeLoad: null, create: null, load: null, - remove: null, - select: null + remove: null } }); diff --git a/tests/unit/tabs/tabs_deprecated.js b/tests/unit/tabs/tabs_deprecated.js index 5f91f1b52..10c86d254 100644 --- a/tests/unit/tabs/tabs_deprecated.js +++ b/tests/unit/tabs/tabs_deprecated.js @@ -198,46 +198,6 @@ asyncTest( "load", function() { } }); -test( "select", function() { - expect( 13 ); - - var element = $( "#tabs1" ).tabs({ - active: false, - collapsible: true - }), - anchors = element.find( ".ui-tabs-nav .ui-tabs-anchor" ), - panels = element.find( ".ui-tabs-panel" ); - - // from collapsed - element.one( "tabsselect", function( event, ui ) { - ok( !( "originalEvent" in event ), "originalEvent" ); - strictEqual( ui.tab, anchors[ 0 ], "ui.tab" ); - strictEqual( ui.panel, panels[ 0 ], "ui.panel" ); - equal( ui.index, 0, "ui.index" ); - state( element, 0, 0, 0 ); - }); - element.tabs( "option", "active", 0 ); - state( element, 1, 0, 0 ); - - // switching tabs - element.one( "tabsselect", function( event, ui ) { - equal( event.originalEvent.type, "click", "originalEvent" ); - strictEqual( ui.tab, anchors[ 1 ], "ui.tab" ); - strictEqual( ui.panel, panels[ 1 ], "ui.panel" ); - equal( ui.index, 1, "ui.index" ); - state( element, 1, 0, 0 ); - }); - anchors.eq( 1 ).click(); - state( element, 0, 1, 0 ); - - // collapsing - element.one( "tabsselect", function() { - ok( false, "collapsing" ); - }); - element.tabs( "option", "active", false ); - state( element, 0, 0, 0 ); -}); - module( "tabs (deprecated): methods" ); test( "add", function() { diff --git a/ui/jquery.ui.tabs.js b/ui/jquery.ui.tabs.js index 4a8287305..cc9e93b7d 100644 --- a/ui/jquery.ui.tabs.js +++ b/ui/jquery.ui.tabs.js @@ -1046,27 +1046,6 @@ if ( $.uiBackCompat !== false ) { } }); - // select event - $.widget( "ui.tabs", $.ui.tabs, { - options: { - select: null - }, - _trigger: function( type, event, data ) { - var ret = this._superApply( arguments ); - if ( !ret ) { - return false; - } - if ( type === "beforeActivate" && data.newTab.length ) { - ret = this._super( "select", event, { - tab: data.newTab.find( ".ui-tabs-anchor" )[ 0], - panel: data.newPanel[ 0 ], - index: data.newTab.closest( "li" ).index() - }); - } - return ret; - } - }); - // load event $.widget( "ui.tabs", $.ui.tabs, { _trigger: function( type, event, data ) {