library-mirrors/jquery-ui
1
0
Fork 0
mirror of https://github.com/jquery/jquery-ui.git synced 2024-11-21 11:04:24 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Tests: Properly check $.uiBackCompat in common widget tests

Browse Source 
The "common widget" tests, checking if a widget doesn't overwrite some
core widget APIs wasn't running as it was incorrectly checking for
`$.uiBackCompat === false` instead of `$.uiBackCompat !== true` after the
default changed in gh-2250.

Fixing the check uncovered that the draggable & sortable modules do
overwrite the `_trigger` method. Add an exception in the test for that;
at this stage of the project we don't plan to change the implementation.

Closes gh-2286
Ref gh-2250
This commit is contained in:
Michał Gołębiowski-Owczarek 2024-09-09 17:52:53 +02:00 committed by GitHub
parent 54f96eea31
commit fd1b8a03b2
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 14 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
tests/lib/common.js
View File

@ -34,7 +34,7 @@ function testWidgetDefaults( widget, defaults ) {
} }
function testWidgetOverrides( widget ) { function testWidgetOverrides( widget ) {
if ( $.uiBackCompat === false ) { if ( $.uiBackCompat !== true ) {
QUnit.test( "$.widget overrides", function( assert ) { QUnit.test( "$.widget overrides", function( assert ) {
assert.expect( 4 ); assert.expect( 4 );
$.each( [ $.each( [
@ -43,8 +43,19 @@ function testWidgetOverrides( widget ) {
"option", "option",
"_trigger" "_trigger"
], function( i, method ) { ], function( i, method ) {
if ( method === "_trigger" &&
/^(?:draggable|sortable): common widget$/
.test( assert.test.module.name ) ) {
// Draggable & sortable modules overwrite _trigger. They
// should not, but we don't plan to change the API at this
// stage of the project.
assert.ok( true, "draggable & sortable modules overwrite _trigger" );
} else {
assert.strictEqual( $.ui[ widget ].prototype[ method ], assert.strictEqual( $.ui[ widget ].prototype[ method ],
$.Widget.prototype[ method ], "should not override " + method ); $.Widget.prototype[ method ], "should not override " + method );
}
} ); } );
} ); } );
} }