Commit Graph

231 Commits

Author SHA1 Message Date
Felix Nagel
66ba39094e Selectmenu: remove button wrapper element 2013-03-07 23:53:15 +01:00
Jörn Zaefferer
022079a782 Selectmenu: Switch to span to avoid cranky click/keydown event handling 2013-03-07 23:23:10 +01:00
Felix Nagel
6e80a19d02 Selectmenu: improve keyboard control 2013-03-07 22:57:49 +01:00
Felix Nagel
f128292636 Selectmenu: fix keyboard control issue 2013-03-07 20:10:56 +01:00
Felix Nagel
f08b0af1be Selectmenu: make sure menu is refreshed at least once before opening 2013-03-07 19:34:13 +01:00
Felix Nagel
8787cb0456 Selectmenu: switch from a to button element 2013-03-07 19:15:37 +01:00
Jörn Zaefferer
d94e217065 Selectmenu: Fix whitespace (trailing ws on 1 line) and lint issues (unused variables) 2013-03-01 17:18:03 +01:00
Felix Nagel
50bb89f3be Selectmenu: follow-up to: menuItems now contains link elements instead of list elements 2013-02-13 23:30:37 +01:00
Felix Nagel
06eb3bff6a Selectmenu: menuItems now contains link elements instead of list elements 2013-02-13 23:09:00 +01:00
Felix Nagel
8a5e8696ad Selectmenu: aria-activedescendant should be set when item is selected, not when menu is closed 2013-02-13 23:07:25 +01:00
Felix Nagel
640d3080eb Selectmenu: menu focus reset when menu is closed, prevents issues when using keyboard control on button when focusing menu item before 2013-02-13 22:42:05 +01:00
Felix Nagel
9719719e60 Selectmenu: rename _setSelected to _setAria 2013-02-09 03:24:50 +01:00
Felix Nagel
3a17a91f30 Selectmenu: click on the text of the button did not open the menu in Webkit browsers 2013-02-08 22:05:26 +01:00
Felix Nagel
4d77ca3e21 Selectmenu: Update copyright year to 2013 2013-01-10 19:16:41 +01:00
Felix Nagel
c9602857dd Selectmenu: improve element creation 2013-01-02 19:52:18 +01:00
Felix Nagel
2eb92232f3 Selectmenu: make sure position option could be overwritten 2013-01-02 19:36:56 +01:00
Felix Nagel
50d7a969a5 Selectmenu: improve _setOption to make it possible to change icons option after init 2012-12-20 00:16:37 +01:00
Felix Nagel
a787d52d4a Selectmenu: make dropdown style default and remove option dropdown 2012-12-20 00:10:06 +01:00
Felix Nagel
52fc8e3c70 Selectmenu: add option icons 2012-12-18 19:55:04 +01:00
Felix Nagel
1afede867d Selectmenu: remove zIndex 2012-12-16 01:44:19 +01:00
Felix Nagel
76f335ea68 Selectmenu: CGL and lint fixes 2012-12-15 02:40:14 +01:00
Felix Nagel
57ecee889d Selectmenu: rework appendTo functionality 2012-12-15 02:21:51 +01:00
Felix Nagel
e2b5123f37 Selectmenu: introduce _setText helper function to improve handling of empty strings 2012-12-14 18:04:51 +01:00
Felix Nagel
1ea22565d3 Selectmenu: fix closing of empty selects 2012-12-13 01:12:52 +01:00
Felix Nagel
c69d01bed7 Selectmenu: replace placeholder entity with   2012-12-13 00:54:45 +01:00
Felix Nagel
89019606eb Selectmenu: revert change to text instead of html, otherwise the unicode special char wont be displayed 2012-12-13 00:53:51 +01:00
Felix Nagel
ed422bd855 Selectmenu: removed ugly workaround for IE9 to make sure the menu is built on first focus 2012-12-12 23:43:32 +01:00
Felix Nagel
b15ae2a64f Selectmenu: merge and explain if statements in Menu focus event, remove unneeded Menu focus method call in open 2012-12-12 19:31:39 +01:00
Felix Nagel
20aad07fe4 Selectmenu: fix comment typo 2012-12-12 17:39:00 +01:00
Felix Nagel
07328359e9 Selectmenu: use method _documentClick for adding events to the document 2012-12-12 17:26:17 +01:00
Felix Nagel
d1350f9f11 Selectmenu: improve option appendTo handling in appendTo method 2012-12-12 16:34:56 +01:00
Jörn Zaefferer
2845d38d40 Selectmenu: Select value when closing with space 2012-12-09 12:58:47 +01:00
Jörn Zaefferer
15032d17d9 Selectmenu: Remove colons from labels, annoying for screenreader-users. Cleanup whitespace. 2012-12-09 12:36:35 +01:00
Felix Nagel
e6aca63a77 Selectmenu: simplify $.each usage in _readOptions method 2012-12-03 23:28:06 +01:00
Felix Nagel
aa60a9e114 Selectmenu: use item.index instead of _getSelectedItem method 2012-12-03 23:19:15 +01:00
Felix Nagel
60e3302d96 Selectmenu: use text() instead of html() as the option and optgroup is read as text 2012-12-03 23:07:30 +01:00
Felix Nagel
cba09dafa7 Selectmenu: guard clause should not return false 2012-12-03 23:05:09 +01:00
Felix Nagel
04553a7da5 Selectmenu: close guard close should test for closed menu 2012-12-03 23:04:53 +01:00
Felix Nagel
0d282630de Selectmenu: make isOpen check a guard clause in close method 2012-11-29 20:57:44 +01:00
Felix Nagel
18ecaf45db Selectmenu: added comment about popup positioning 2012-11-29 20:33:05 +01:00
Felix Nagel
f622428c43 Selectmenu: improve disabled check in open method 2012-11-29 20:23:30 +01:00
Felix Nagel
ac7b8f925a Selectmenu: improve comment in _drawMenu 2012-11-29 20:20:43 +01:00
Felix Nagel
1e6808a1a2 Selectmenu: replace placeholder entity with   2012-11-29 20:13:57 +01:00
Felix Nagel
a177a92635 Selectmenu: improve element creation 2012-11-29 20:10:05 +01:00
Felix Nagel
e581a13c10 Selectmenu: remove unnecessary comments from _drawButton 2012-11-29 20:06:00 +01:00
Felix Nagel
71e744ad30 Selectmenu: move button event binding in _drawButton 2012-11-29 19:54:10 +01:00
Felix Nagel
080b5bca0a Selectmenu: remove unnecessary comments from _create 2012-11-29 19:53:12 +01:00
Felix Nagel
b014bc6245 Selectmenu: alphabetical ordering of options and callback events 2012-11-29 19:49:43 +01:00
Felix Nagel
8a62210538 Selectmenu: updated documentation link 2012-11-29 19:41:20 +01:00
Felix Nagel
7328333773 Selectmenu: better position handling, fixes issue with wrong styles when using custom positioning 2012-11-29 00:58:28 +01:00
Felix Nagel
4e68c526ab Selectmenu: removed Position Plugin offset option to fix broken pop-up functionality 2012-11-23 15:38:33 +01:00
Felix Nagel
12fe28fefd Selectmenu: cleanup, CGL and lint fix 2012-11-12 23:06:05 +01:00
Felix Nagel
a9a6e3beaf Selectmenu: proposed fix for menu delay issue 2012-11-10 01:25:30 +01:00
Felix Nagel
7725e4adba Selectmenu: focus selected item when menu opens 2012-11-10 01:18:49 +01:00
Felix Nagel
684b55bcbc Selectmenu: Do not remove ui-state-focus class on first button focus (follow-up) 2012-10-27 20:49:35 +02:00
Felix Nagel
b6e1c86864 Selectmenu: Do not remove ui-state-focus class on first button focus 2012-10-26 19:29:30 +02:00
Felix Nagel
228a9b91fb Selectmenu: follow-up for menu, reset aria-activedescendant to selected item when menu is closed 2012-10-26 00:41:17 +02:00
Felix Nagel
a59b3c7585 Selectmenu: reset aria-activedescendant to selected item when menu is closed 2012-10-26 00:33:20 +02:00
Felix Nagel
7c1a9d9a36 Selectmenu: hopefully fixed multiple a11y bugs (value is recognized by screenreader: in collapsed state, when selecting a value, on tab focus; label points to button now) 2012-10-25 23:57:36 +02:00
Felix Nagel
b2d50f9ffc Selectmenu: fixed aria-activedescendant for button element 2012-10-25 22:24:37 +02:00
Felix Nagel
9cf0f21efd Selectmenu: add removeUniqueId to destroy method 2012-10-25 20:55:48 +02:00
Felix Nagel
b8cce0c3e1 Selectmenu: small improvement for label id setting 2012-10-25 20:54:27 +02:00
Jörn Zaefferer
99aa0ff8d1 Selectmenu: Fix data naming, should be [namespace]-[widgetname]-[value] 2012-10-19 18:22:12 -04:00
Robert Beuligmann
8e1e956248 Selectmenu: corrections based on code review. 2012-10-16 10:57:49 -05:00
Robert Beuligmann
20d19dbbf1 Selectmenu: ARIA tweaks for keyboard events and closed menu operation 2012-10-15 16:58:31 -05:00
Felix Nagel
c179902468 Simplify licensing. 2012-08-11 19:57:17 +02:00
Felix Nagel
b6e246784d Selectmenu: remove unbind Menu document event to reset mouseHandled flag, related to revision b8ad711dee 2012-08-11 19:55:06 +02:00
Scott González
549b97ed6c Selectmenu: Fixed event unbinding. 2012-07-17 15:27:26 -04:00
Felix Nagel
44f9b8fb09 Selectmenu: updated copyright notice 2012-07-16 20:36:01 +02:00
Felix Nagel
001bd3d502 Selectmenu: trim trailing spaces 2012-07-13 00:23:00 +02:00
Felix Nagel
b19986a851 Selectmenu: changed _unbind to _off 2012-07-13 00:18:05 +02:00
Felix Nagel
8f5f4b38cd Selectmenu: changed _bind to _on 2012-07-13 00:10:49 +02:00
Felix Nagel
39532f0a8e Selectmenu: Use new uniqueId method for generating id's 2012-05-31 18:54:57 +02:00
Felix Nagel
d4ec5cbb3f Selectmenu: make use of Menu option 'role' (follow-up), no need to adjust li role 2012-05-24 18:56:41 +02:00
Felix Nagel
7345e43048 Selectmenu: make use of Menu option 'role' 2012-05-24 18:41:32 +02:00
Felix Nagel
ec6d88fae4 Selectmenu: small fixes for lint tests 2012-05-24 18:30:39 +02:00
Felix Nagel
c5a449d611 Selectmenu: small fixes for lint tests 2012-05-16 20:41:24 +02:00
Felix Nagel
360e885d98 Selectmenu: updated copyright year 2012-05-16 19:27:11 +02:00
Felix Nagel
ddf7c27c75 Selectmenu: prevent copyright notice from being removed by minification 2012-05-16 19:26:31 +02:00
Felix Nagel
b348d32caa Selectmenu: trim trailing spaces 2012-05-16 19:25:21 +02:00
Felix Nagel
1092551e21 Selectmenu: fixed small regression which added unwanted, empty optgroup to every menu 2012-04-01 22:38:16 +02:00
kborchers
4a9e26c68e Selectmenu: Add links to all menu items to be in line with what menu expects and remove the extra space added to disabled items 2012-03-18 21:47:40 -05:00
Felix Nagel
b1a72e6e04 Selectmenu: small improvements, code clean-up, lint, coding guidelines 2012-02-26 03:46:27 +01:00
Felix Nagel
cea684492d Selectmenu: removed working but illogical closest context 2012-02-26 03:13:44 +01:00
Felix Nagel
f2228b0553 Selectmenu: remove unwanted Menu mouseover event, fixes problem with selected item highlighting on menu open 2012-02-26 01:50:55 +01:00
Felix Nagel
c5efddab2d Selectmenu: small fix for _toggleAttr to make sure isOpen is not undefined 2012-02-26 01:15:49 +01:00
Felix Nagel
85d6acb899 Selectmenu: merged _toggleButtonStyle with _toggleAttr method, removed incomplete dropdown _setOptions functionality 2012-02-25 03:17:20 +01:00
Felix Nagel
a4eeddd330 Selectmenu: improve optgroup header event handling, fixed disabled item event handling, improve attribute handling on menu toggle, small improvements, clean-up 2012-02-25 01:43:53 +01:00
Felix Nagel
c0f9dd31e9 Selectmenu: unbind Menu document click event (fires unwanted focus event) 2012-02-25 00:15:28 +01:00
Felix Nagel
b356e1e4e1 Selectmenu: selected callback event fired twice when using mouse 2012-02-24 22:50:27 +01:00
Felix Nagel
058cba236f Selectmenu: backfall for initial refresh when menu is opened 2012-02-24 22:39:11 +01:00
Felix Nagel
96102f7692 Selectmenu: use _hoverable and _focusable for button events 2012-02-23 23:32:17 +01:00
Felix Nagel
29effb38eb Selectmenu: removed Button widget dependency 2012-02-23 23:25:03 +01:00
Felix Nagel
43851b65f5 Selectmenu: removed unneeded SPACE keypress event 2012-02-23 21:05:11 +01:00
Felix Nagel
c424ae40f0 Selectmenu: close open menu on escape keydown 2012-02-22 00:29:05 +01:00
Felix Nagel
45263578dd Selectmenu: removed aria-activedescendant attr from button 2012-02-21 23:44:32 +01:00
Felix Nagel
52e43c076f Selectmenu: re-enabled lazy loading of the menu items (menu refresh) 2012-02-21 23:41:00 +01:00
Felix Nagel
d0c31c188e Selectmenu: fix _setSelected method, fixes aria-selected and unit tests 2012-02-21 22:35:37 +01:00
Jörn Zaefferer
59d15809a3 Selectmenu: Introduce menuWidget method, to get access to the menu element. Fix various tests and simplify demos accordingly. Add comment about optgroup-click-handling. 2012-02-21 20:22:13 +01:00
Jörn Zaefferer
b15dc8e3c5 Selectmenu: Simplify _getCreateOptions implementation 2012-02-21 18:31:27 +01:00