Commit Graph

192 Commits

Author SHA1 Message Date
Felix Nagel
0631d7666f Selectmenu: rename var to focusIndex 2013-04-29 22:15:50 +02:00
Felix Nagel
5e9ad9b434 Selectmenu: blank before comment 2013-04-29 22:15:29 +02:00
Felix Nagel
00ab497923 Selectmenu: improve readability when creating button elements 2013-04-29 22:14:50 +02:00
Felix Nagel
8b4a3044cb Selectmenu: set aria states as string if needed 2013-04-29 22:07:41 +02:00
Felix Nagel
b84cd7e686 Selectmenu: simplify tabindex attribute setting on button create 2013-04-29 22:04:56 +02:00
Felix Nagel
68c7485ed9 Selectmenu: Comments start with an uppercase letter 2013-04-29 22:01:51 +02:00
Felix Nagel
a29cfb8bf4 Selectmenu: don't quote click, remove extraneous space 2013-04-29 21:59:55 +02:00
Felix Nagel
60eed79390 Selectmenu: improve id generation 2013-04-29 21:54:36 +02:00
Felix Nagel
26c528a4a3 Selectmenu: Updating to use instance method on bridge, see 4fce29e935 2013-03-19 20:27:12 +01:00
Felix Nagel
ba0e8040f0 Selectmenu: add ui-state-disabled and aria-disabled manually as its removed from Widget, see 44d07173db 2013-03-19 20:20:06 +01:00
Jörn Zaefferer
775b81b9e6 Selectmenu: Remove aria-selected, since that only causes NVDA to announce 'not selected', doesn't have any positive effect 2013-03-09 13:00:38 +01:00
Felix Nagel
66ba39094e Selectmenu: remove button wrapper element 2013-03-07 23:53:15 +01:00
Jörn Zaefferer
022079a782 Selectmenu: Switch to span to avoid cranky click/keydown event handling 2013-03-07 23:23:10 +01:00
Felix Nagel
6e80a19d02 Selectmenu: improve keyboard control 2013-03-07 22:57:49 +01:00
Felix Nagel
f128292636 Selectmenu: fix keyboard control issue 2013-03-07 20:10:56 +01:00
Felix Nagel
f08b0af1be Selectmenu: make sure menu is refreshed at least once before opening 2013-03-07 19:34:13 +01:00
Felix Nagel
8787cb0456 Selectmenu: switch from a to button element 2013-03-07 19:15:37 +01:00
Jörn Zaefferer
d94e217065 Selectmenu: Fix whitespace (trailing ws on 1 line) and lint issues (unused variables) 2013-03-01 17:18:03 +01:00
Felix Nagel
50bb89f3be Selectmenu: follow-up to: menuItems now contains link elements instead of list elements 2013-02-13 23:30:37 +01:00
Felix Nagel
06eb3bff6a Selectmenu: menuItems now contains link elements instead of list elements 2013-02-13 23:09:00 +01:00
Felix Nagel
8a5e8696ad Selectmenu: aria-activedescendant should be set when item is selected, not when menu is closed 2013-02-13 23:07:25 +01:00
Felix Nagel
640d3080eb Selectmenu: menu focus reset when menu is closed, prevents issues when using keyboard control on button when focusing menu item before 2013-02-13 22:42:05 +01:00
Felix Nagel
9719719e60 Selectmenu: rename _setSelected to _setAria 2013-02-09 03:24:50 +01:00
Felix Nagel
3a17a91f30 Selectmenu: click on the text of the button did not open the menu in Webkit browsers 2013-02-08 22:05:26 +01:00
Felix Nagel
4d77ca3e21 Selectmenu: Update copyright year to 2013 2013-01-10 19:16:41 +01:00
Felix Nagel
c9602857dd Selectmenu: improve element creation 2013-01-02 19:52:18 +01:00
Felix Nagel
2eb92232f3 Selectmenu: make sure position option could be overwritten 2013-01-02 19:36:56 +01:00
Felix Nagel
50d7a969a5 Selectmenu: improve _setOption to make it possible to change icons option after init 2012-12-20 00:16:37 +01:00
Felix Nagel
a787d52d4a Selectmenu: make dropdown style default and remove option dropdown 2012-12-20 00:10:06 +01:00
Felix Nagel
52fc8e3c70 Selectmenu: add option icons 2012-12-18 19:55:04 +01:00
Felix Nagel
1afede867d Selectmenu: remove zIndex 2012-12-16 01:44:19 +01:00
Felix Nagel
76f335ea68 Selectmenu: CGL and lint fixes 2012-12-15 02:40:14 +01:00
Felix Nagel
57ecee889d Selectmenu: rework appendTo functionality 2012-12-15 02:21:51 +01:00
Felix Nagel
e2b5123f37 Selectmenu: introduce _setText helper function to improve handling of empty strings 2012-12-14 18:04:51 +01:00
Felix Nagel
1ea22565d3 Selectmenu: fix closing of empty selects 2012-12-13 01:12:52 +01:00
Felix Nagel
c69d01bed7 Selectmenu: replace placeholder entity with   2012-12-13 00:54:45 +01:00
Felix Nagel
89019606eb Selectmenu: revert change to text instead of html, otherwise the unicode special char wont be displayed 2012-12-13 00:53:51 +01:00
Felix Nagel
ed422bd855 Selectmenu: removed ugly workaround for IE9 to make sure the menu is built on first focus 2012-12-12 23:43:32 +01:00
Felix Nagel
b15ae2a64f Selectmenu: merge and explain if statements in Menu focus event, remove unneeded Menu focus method call in open 2012-12-12 19:31:39 +01:00
Felix Nagel
20aad07fe4 Selectmenu: fix comment typo 2012-12-12 17:39:00 +01:00
Felix Nagel
07328359e9 Selectmenu: use method _documentClick for adding events to the document 2012-12-12 17:26:17 +01:00
Felix Nagel
d1350f9f11 Selectmenu: improve option appendTo handling in appendTo method 2012-12-12 16:34:56 +01:00
Jörn Zaefferer
2845d38d40 Selectmenu: Select value when closing with space 2012-12-09 12:58:47 +01:00
Jörn Zaefferer
15032d17d9 Selectmenu: Remove colons from labels, annoying for screenreader-users. Cleanup whitespace. 2012-12-09 12:36:35 +01:00
Felix Nagel
e6aca63a77 Selectmenu: simplify $.each usage in _readOptions method 2012-12-03 23:28:06 +01:00
Felix Nagel
aa60a9e114 Selectmenu: use item.index instead of _getSelectedItem method 2012-12-03 23:19:15 +01:00
Felix Nagel
60e3302d96 Selectmenu: use text() instead of html() as the option and optgroup is read as text 2012-12-03 23:07:30 +01:00
Felix Nagel
cba09dafa7 Selectmenu: guard clause should not return false 2012-12-03 23:05:09 +01:00
Felix Nagel
04553a7da5 Selectmenu: close guard close should test for closed menu 2012-12-03 23:04:53 +01:00
Felix Nagel
0d282630de Selectmenu: make isOpen check a guard clause in close method 2012-11-29 20:57:44 +01:00