Commit Graph

135 Commits

Author SHA1 Message Date
Ben Higgins
0bb807bb42 Draggable: fix changing containment
If containment was set such that relative_container is set by
_setContainment, and then containment changes to e.g. "document",
"window", or an array, relative_container would not be unset, causing
incorrect containment of the draggable.

Add a unittest to check that containment with an array works after
previously being set to "parent".

Fixes #9733
Closes gh-1176
2014-01-20 13:08:12 -05:00
Brian J. Dowling
f4423f508e Tests: Fix draggable_options expected test count to be dynamic
The test count was previously incremented to 8 when normally 6 tests
are run.  After figuring out the dynamic test code, I just made the
expect depend on the same array length

Also re-enabled the test in the Gruntfile since it now passes.
2014-01-16 21:25:28 +00:00
TJ VanToll
28310ff55f Slider & Interactions: Add Windows 8 touch support
Fixes #9709
Fixes #9710
Closes gh-1152
2014-01-15 15:38:10 -05:00
Dave Stein
38c6cf1382 Draggable: Test fix regarding static scrolling
No longer checking scroll positions of static scrolls since the fixture is
in an absolute container.

Closes gh-1145
2013-12-15 09:38:46 -05:00
Mike Sherov
f4839f73a7 Draggable Unit Tests: Ensure IFRAMEs can be written to
Draggable tests were failing in IE because the frame needs to be
written to to be accessible to further DOM manipulation.
2013-12-14 17:38:33 -05:00
Mike Sherov
44b2180782 Draggable: normalize lookups for rootNodes when to bust scroll cache. Fixes #9379 - Draggable: position bug in scrollable div
Core: update scrollParent() to support all current supported browsers.
2013-12-03 10:08:12 -05:00
Mike Sherov
1f724adb15 Draggable Tests: don't test auto scroll while testing helpers. 2013-10-31 21:41:45 -04:00
Mike Sherov
a3715a7c91 Draggable Tests: Ensure all combinations of helper / draggable positions / scrollParents / parent positions are tested accurately. 2013-10-29 13:25:57 -04:00
Mike Sherov
dbbf3a9611 Draggable Tests: Ensure Draggable tests are correctly testing offset under scroll conditions. 2013-10-23 12:22:06 -04:00
Mike Sherov
fdc7052fdb Draggable Tests: Test both position and offset of draggable element in all applicable tests. 2013-10-21 11:20:03 -04:00
Mike Sherov
94f8c4d5e9 Draggable: apply axis options to position instead of style. Fixes #7251 - Draggable: constrained axis option returns incorrect position. 2013-10-20 19:46:05 -04:00
Mike Sherov
9ca0a19a00 Draggable Tests: Fix lint error. 2013-10-20 15:34:59 -04:00
Mike Sherov
b8795e15d6 Draggable Tests: Add position asserts to drag tests
They're currently disabled however due to bugs both
in the tests and in the actual widget.
2013-10-20 15:31:47 -04:00
Mike Sherov
c9b0e28d8d Draggable Tests: consolidate drag tests and provide error messages for all assertions. 2013-10-20 09:35:12 -04:00
Mike Sherov
0144b270c8 Draggable Tests: clarify scroll helpers. 2013-10-20 08:37:34 -04:00
Mike Sherov
82edd58743 Draggable Tests: make sure offset tests are actually testing offsets 2013-10-19 18:53:00 -04:00
Mike Sherov
67fd40eda7 Tests: extract TestHelpers.forceScrollableWindow for tests that need the window to scroll 2013-10-19 18:48:04 -04:00
Mike Sherov
263d078944 Draggable: Ignore scroll offsets for abspos draggables. Fixes #9315 - Draggable: jumps down with offset of scrollbar 2013-08-12 19:32:01 -04:00
Bruno M. Custódio
0d5eaab9bb Updating jQuery to 1.10.2.
Adding jQuery 1.10.0, 1.10.1, 1.10.2, 2.0.0, 2.0.1, 2.0.2 and 2.0.3 to the
tests directory.
2013-07-05 08:42:37 -04:00
Steven Luscher
fcd1cafac8 Draggable: active element blurs when clicking on a draggable. Fixes #4261 - Draggable: Inputs do not blur when clicking on a draggable 2013-06-19 18:07:38 -04:00
Steven Luscher
bca3e058e8 Clicking on a draggable anchor without moving it should make it the active element (Fixes #8399). 2013-06-19 08:38:57 -04:00
Brian Grinstead
24756a978a Draggable: enabled draggable from within iframe. Fixed #5727 - draggable: cannot drag element inside iframe 2013-05-20 22:10:04 -04:00
Mike Sherov
7c939aadf8 Test Suite: Remove Flaky Datepicker test, and correct more old jQuery test cases for old Opera and old Safari. 2013-04-14 12:58:42 -04:00
Mike Sherov
d345a0d7db Draggable: allow draggable to defer destroying itself upon DOM removal until after stop is fired. Fixes #6889 - Draggable: Cursor doesn't revert to pre-dragging state after revert action when original element is removed. 2013-04-12 14:45:48 -04:00
Scott González
d7ea0e5e51 Draggable tests: Wrap IIFE in parens. 2013-04-08 14:45:09 -04:00
Mike Sherov
58d9130ba3 Draggable Tests: style guide conformance for TestHelpers 2013-04-07 12:31:21 -04:00
Mike Sherov
d4d9e14161 Draggable Tests: fix more old Safari and old Opera tests with jQuery < 1.8 tests by accounting for a bug in $.contains on disconnected Elements. 2013-04-07 12:17:19 -04:00
Mike Sherov
3c1a3ca252 Draggable Tests: fix old Safari and old Opera tests with jQuery < 1.8 tests by accounting for a bug in $.contains on disconnected Elements. 2013-04-07 12:10:59 -04:00
Mike Sherov
6a3bf605ba Draggable Tests: fix copypasta'd assertion messages. 2013-04-06 22:59:56 -04:00
Mike Sherov
49c7b7200e Draggable: Don't cache parent offset if the parent position is fixed. Fixes #5009 - Draggable: scroll not working with parent's position fixed 2013-04-03 12:26:39 -04:00
Mike Sherov
a88d645140 Draggable: Stop erroneously overriding scroll offsets for root nodes. Fixes #6258 - Draggable: not following mouse when scrolled and using overflow-y: scroll. 2013-04-02 19:51:36 -04:00
Mike Sherov
204a0423be Draggable Tests: Fix IE8 test failures by accounting for the IE8 testswarm IFRAME positioning bug. 2013-03-31 12:19:43 -04:00
Mike Sherov
38f93c4ac1 Draggable Tests: Minor style fixes and removing unnecessary setup and teardown for core tests. 2013-03-26 09:22:35 -04:00
Mike Sherov
e9faec96ed Draggable Tests: Test that removing an element on drop doesn't cause a draggable error. Fixes #9159 - Draggable Tests: Write test case for #8269 2013-03-26 09:21:53 -04:00
Mike Sherov
dc5254aa07 Draggable: Handle containment set to false after init, and style improvements. Fixes #8962 - Containment doesn't properly update 2013-03-23 16:48:19 -04:00
Jörn Zaefferer
90135b27f8 Widget tests: Use instance method. Also replace a few instances of $.data in widget implementations. 2013-03-19 16:53:35 +01:00
Mike Sherov
9d8af804ad Draggable: make sure snap elements are in the document before snapping. Fixes #8459 - Draggable: element can snap to an element that was removed during drag. 2013-03-16 14:36:06 -04:00
Zbigniew Motyka
bd126a9c1c Draggable: modified snapping algorithm to use edges and corners. Fixed #8165 - Draggable: Snapping doesn't take top/left into account properly 2013-03-16 11:51:51 -04:00
Woody Gilk
82f588e82b Draggable: Fix double offset bug when scrolling. Fixes #6817 - Draggable: auto scroll goes double distance when dragging 2013-03-15 18:52:56 -04:00
Scott González
44d07173db Widget: Stop setting ui-state-disabled and aria by default on setting disabled option.
Fixes #5973 - Resizable: disabled should not have the ui-state-disabled class or aria attribute aria-disabled
Fixes #5974 - Draggable: disabled should not have the ui-state-disabled class or aria attribute aria-disabled
Fixes #6039 - Droppable: disabled should not have ui-state-disabled

This reverts commit 23771d38ba.
2013-03-14 19:08:21 -04:00
Scott González
23771d38ba Revert "Widget: Stop setting ui-state-disabled and aria by default on setting disabled option." This needs to wait for a major release.
This reverts commit 4d67f4f349.
2013-03-14 15:07:06 -04:00
Mike Sherov
4d67f4f349 Widget: Stop setting ui-state-disabled and aria by default on setting disabled option.
Fixes #5973 - Resizable: disabled should not have the ui-state-disabled class or aria attribute aria-disabled
Fixes #5974 - Draggable: disabled should not have the ui-state-disabled class or aria attribute aria-disabled
Fixes #6039 - Droppable : disabled should not have ui-state-disabled
2013-03-11 22:08:21 -04:00
Scott González
57051e8a73 Draggable tests: Don't use .on(). 2013-03-09 08:12:47 -05:00
Scott González
cdff72efed Draggable: Account for descendants in handle. 2013-03-08 10:08:58 -05:00
TJ VanToll
6358695df1 Draggable: Fix border containment. Fixed #5569 - Draggable: Containment incorrectly calculates padding and border 2013-03-07 21:42:28 -05:00
Mike Sherov
ca0b4b8a6c Draggable Tests: Fix containment tests 2013-03-04 11:39:14 -05:00
Mike Sherov
5a04d237dd Draggable Tests: Fix snap test failures in IE8 2013-03-04 09:58:23 -05:00
Mike Sherov
dd16205a3f Draggable Tests: Style Sweep 2013-03-04 01:32:23 -05:00
Mike Sherov
c278a4461b Draggable Tests: Add test coverage for supported options 2013-03-04 01:05:11 -05:00
TJ VanToll
c32bebd1bd Draggable: Account for z-index set in CSS for the stack option. Fixed #9077 - Draggable: stack option resets the z-index 2013-02-11 23:29:48 -05:00