Commit Graph

3389 Commits

Author SHA1 Message Date
Scott González
0cc40d799f Dialog: Removed deprecated position handling. Fixes #8825 - Dialog: Remove array and string notations for position option. 2013-03-15 06:41:06 -04:00
Scott González
44d07173db Widget: Stop setting ui-state-disabled and aria by default on setting disabled option.
Fixes #5973 - Resizable: disabled should not have the ui-state-disabled class or aria attribute aria-disabled
Fixes #5974 - Draggable: disabled should not have the ui-state-disabled class or aria attribute aria-disabled
Fixes #6039 - Droppable: disabled should not have ui-state-disabled

This reverts commit 23771d38ba.
2013-03-14 19:08:21 -04:00
Scott González
23771d38ba Revert "Widget: Stop setting ui-state-disabled and aria by default on setting disabled option." This needs to wait for a major release.
This reverts commit 4d67f4f349.
2013-03-14 15:07:06 -04:00
Scott González
054449e214 Sortable: Only animate along the specified axis when reverting. Fixes #7415 - Sortable: Incorrect revert animation with axis: 'y'. 2013-03-13 11:31:54 -04:00
Mike Sherov
4d67f4f349 Widget: Stop setting ui-state-disabled and aria by default on setting disabled option.
Fixes #5973 - Resizable: disabled should not have the ui-state-disabled class or aria attribute aria-disabled
Fixes #5974 - Draggable: disabled should not have the ui-state-disabled class or aria attribute aria-disabled
Fixes #6039 - Droppable : disabled should not have ui-state-disabled
2013-03-11 22:08:21 -04:00
Jörn Zaefferer
775b81b9e6 Selectmenu: Remove aria-selected, since that only causes NVDA to announce 'not selected', doesn't have any positive effect 2013-03-09 13:00:38 +01:00
John Chen
07ce771a13 Sortable: Skip triggering over event if it's alreay over the continer. Fixes #9041: the over event fires on every pixel movement 2013-03-08 16:52:35 -05:00
John Chen
89473f6557 Sortable: Skip items that are not at the same line as the cursor when floating. Fixes #8792: Issue with floated items in connected lists. 2013-03-08 16:52:21 -05:00
Scott González
e0b2644d91 Removed guard against duplicate loading. Use safe references to original functions when proxying, don't rename originals. 2013-03-08 10:23:25 -05:00
Scott González
cdff72efed Draggable: Account for descendants in handle. 2013-03-08 10:08:58 -05:00
TJ VanToll
6358695df1 Draggable: Fix border containment. Fixed #5569 - Draggable: Containment incorrectly calculates padding and border 2013-03-07 21:42:28 -05:00
Felix Nagel
0bf91a41c6 Merge branch 'master' into selectmenu 2013-03-07 23:56:48 +01:00
Felix Nagel
66ba39094e Selectmenu: remove button wrapper element 2013-03-07 23:53:15 +01:00
Jörn Zaefferer
022079a782 Selectmenu: Switch to span to avoid cranky click/keydown event handling 2013-03-07 23:23:10 +01:00
Felix Nagel
6e80a19d02 Selectmenu: improve keyboard control 2013-03-07 22:57:49 +01:00
Felix Nagel
f128292636 Selectmenu: fix keyboard control issue 2013-03-07 20:10:56 +01:00
Felix Nagel
f08b0af1be Selectmenu: make sure menu is refreshed at least once before opening 2013-03-07 19:34:13 +01:00
Felix Nagel
8787cb0456 Selectmenu: switch from a to button element 2013-03-07 19:15:37 +01:00
Scott González
b9be6bb7ad Sortable: Copy the src of the original item when creating a placeholder from an image. Fixes #5129 - Sortable: Unable to use an image as a placeholder in Firefox. 2013-03-07 12:55:00 -05:00
Mike Sherov
c278a4461b Draggable Tests: Add test coverage for supported options 2013-03-04 01:05:11 -05:00
Felix Nagel
dffe8f6610 Merge branch 'master' into selectmenu 2013-03-03 13:48:01 +01:00
Jörn Zaefferer
d94e217065 Selectmenu: Fix whitespace (trailing ws on 1 line) and lint issues (unused variables) 2013-03-01 17:18:03 +01:00
Scott González
6f29577436 Effects: Handle the .hide/show/toggle( options ) signatures from core properly. Fixes #9126 - .show()/.hide() do not support all of core's options. 2013-02-28 13:34:49 -05:00
Scott González
948563b8b5 Effects: Delegate to core show/hide when the element is already in the correct final state. This forces the element to go through the olddisplay tracking and forces styles on elements even if they're hidden via an ancestor. Fixes #9120 - Effects: .hide() inconsistent with core with a hidden parent. 2013-02-26 10:36:03 -05:00
Zaven Muradyan
1c80735acb Droppable: Changed drop event to loop over a copied array instead of the droppables directly. Fixed #9116 - Droppable: Drop event can cause droppables to remain active if any droppable is created/destroyed in the event handler. 2013-02-26 09:56:18 -05:00
Scott González
e9c04bfa43 Position: Fix orientation check for scrollbar widths. Fixes #8763 - Position: getScrollInfo() swapped width and height. 2013-02-26 08:59:28 -05:00
Scott González
d5d3a745b0 Autocomplete: Set isNewMenu flag on every suggestion. Fixes #9118 - Autocomplete: Mouse auto-highlights option in Firefox. 2013-02-25 15:36:08 -05:00
Scott González
2348fb8eb9 Spinner: Call _stop() on blur. Fixes #9112 - Spinner keeps changing after losing focus. 2013-02-22 09:15:43 -05:00
Steve Urmston
a924af12b6 Draggable: Revert flag honours Sortable revert speed. Fixed #9103 Draggable: revert option reset after being added to a connectedSortable. 2013-02-21 08:20:41 -05:00
Scott González
bd47bd4ace Sortable: When sorting table rows, create a td to force dimensions. Fixes #4765 - Sortable: Placeholder not displayed when sorting table rows. 2013-02-20 20:16:29 -05:00
Scott González
51eb28e76e Dialog: Extract check for which elements can gain focus into its own method for overriding. Fixes #9087 - Dialog: Allow registering elements outside a dialog for use when a modal dialog is open. 2013-02-20 17:35:48 -05:00
Christian Wenz
10ca48308f Datepicker: Updated German locale. Fixes #9098 - Datepicker German localization - make casing of previous/next/today consistent. 2013-02-19 15:21:48 -05:00
Scott González
5e1b8dc71a Dialog: Don't hard-code widget data key. Fixes #9097 - UI dialog inheritance. 2013-02-18 16:07:15 -05:00
Nathanael Silverman
a692bf9b70 Sortable: Inject a CSS rule to style the cursor. Fixed #7389 - sortable: 'cursor' option didn't override CSS cursor settings. 2013-02-18 10:10:01 -05:00
Felix Nagel
50bb89f3be Selectmenu: follow-up to: menuItems now contains link elements instead of list elements 2013-02-13 23:30:37 +01:00
Felix Nagel
06eb3bff6a Selectmenu: menuItems now contains link elements instead of list elements 2013-02-13 23:09:00 +01:00
Felix Nagel
8a5e8696ad Selectmenu: aria-activedescendant should be set when item is selected, not when menu is closed 2013-02-13 23:07:25 +01:00
Felix Nagel
640d3080eb Selectmenu: menu focus reset when menu is closed, prevents issues when using keyboard control on button when focusing menu item before 2013-02-13 22:42:05 +01:00
TJ VanToll
a5469750ae Merge branch 'draggable_fix_9077' 2013-02-12 21:28:23 -05:00
TJ VanToll
3d39d8c32f Removing unnecessary wrapping of this in draggable's stack option handling. 2013-02-12 21:27:21 -05:00
Scott González
bce9da4206 Datepicker i18n: Change Slovak day/month names to lowercase. Fixes #9078 - Datepicker Slovak localisation - name of day/month is always lowercase. 2013-02-12 09:57:29 -05:00
David Petersen
c958b211db Position: Handle decimal percentage offsets. Fixes #9076: percentage offset does not support decimal 2013-02-12 07:05:19 -06:00
TJ VanToll
c32bebd1bd Draggable: Account for z-index set in CSS for the stack option. Fixed #9077 - Draggable: stack option resets the z-index 2013-02-11 23:29:48 -05:00
Felix Nagel
a7b4f29cea Merge branch 'master' into selectmenu 2013-02-09 03:29:10 +01:00
Felix Nagel
9719719e60 Selectmenu: rename _setSelected to _setAria 2013-02-09 03:24:50 +01:00
Felix Nagel
3a17a91f30 Selectmenu: click on the text of the button did not open the menu in Webkit browsers 2013-02-08 22:05:26 +01:00
Scott González
7d5fe02dd9 Autocomplete: Use .ui-front instead of .zIndex() for the suggestions menu. 2013-02-05 13:01:32 -05:00
Scott González
7a49ee4cd3 Datepicker: Use entity number instead of entity name when escaping single quotes. 2013-02-05 10:13:27 -05:00
Scott González
101a09d31f Autocomplete: Optimize element type checks for speed and size. 2013-02-05 09:34:32 -05:00
David Petersen
df077abfc2 Slider: allow range option to be changed. Fixed #5602 - Slider Does Not Exhibit Proper Behavior When Switching Range 2013-02-05 08:31:42 -06:00
David Petersen
a129a93a4d Slider: Add disabled tests and remove disabled prop from handles 2013-02-04 14:43:56 -06:00
Scott González
a7353e7c9b Dailog: Cover iframes during drag and resize. Fixes #7650 - Dialog cannot be dragged properly with IFRAME. 2013-02-03 08:55:34 -05:00
Scott González
8724092e50 Dialog: Don't use ._on() for modal event handlers. Fixes #9048 - Dialog: broken focusin event handler when beforeclose event of a modal opens another modal. 2013-02-02 19:32:42 -05:00
Vahid Sohrabloo
2df2abcbf1 Draggable: Change $.ui.contains() to $.contains(). Fixes #9051 - Draggable: Reference to undefined $.ui.contains(). 2013-02-02 15:29:31 -05:00
Scott González
df179542cc Datepicker: Escape single quotes in tooltips. Fixes #9049 - Datepicker beforeShowDay tooltip not displayed properly if single quote is used. 2013-02-01 16:52:04 -05:00
Scott González
7bbda71a32 Dialog: Check for empty array in addition to empty object when checking if there are buttons. Fixes #9043 - Dialog: Buttonpane shown with no buttons when modifying native prototypes. 2013-02-01 08:59:55 -05:00
Scott González
62cda1f95d Dialog: Set the _isOpen flag immediately in open(). Fixes #8958 - Dialog: Double ui-widget-overlay when opening modal dialog triggers an event opening same dialog. 2013-01-31 17:20:19 -05:00
Scott González
c193a0ce17 Menu: Escape em and en dashes in regex. Fixes #9016 - Menu: Non-ASCII characters. 2013-01-31 09:05:16 -05:00
Kris Borchers
d1505e3434 Dialog: Move call to _focusTabbable and triggering of open and focus events into the _show callback. Fixes #6756 - Dialog: show: "blind" with link in content doesn't animate properly. Fixes #8051 - Dialog: 'Explode' dialog animation causes crash in IE 6, 7 and 8. Fixes #4421 - Dialog: Focus lost from dialog which uses show-effect 2013-01-30 12:30:37 -06:00
Felix Nagel
91dde04dad Merge branch 'master' into selectmenu 2013-01-30 18:10:39 +01:00
David Petersen
2ca4d17982 Effects Core: make removeClass work correctly with changes jQuery 1.9.0. Fixed #9015 - Inclusion of jQuery UI breaks removeClass 2013-01-29 07:47:54 -06:00
Thomas Jaggi
3aa8ad0c4a Slider: Added rounded corners to range area. Fixed #9024 - Slider: Range area needs rounded corners, too 2013-01-28 16:03:42 +01:00
David Sullivan
55360eeb7e Dialog: modified _createOverlay to _appendTo instead of document.body. Fixed #8984 - Modal dialogs display behind overlay when using appendTo option 2013-01-26 11:34:51 -05:00
Scott González
c53198c209 Dialog: Allow interaction with datepickers from modal dialogs. Fixes #8989 - Dialog: Cannot change month/year in datepicker within modal. 2013-01-25 08:51:13 -05:00
David Petersen
649f105229 Dialog: Don't handle overlays on destory if there are not any. Fixed: #9004 - failed in _destroyOverlay when I destroy a modal dialog thau was never opened. Fixed: #9000 Dialog leaves broken event handler after close/destroy in certain cases 2013-01-24 13:43:02 -06:00
David Petersen
f7f165c9f8 Merge pull request #891 from petersendidit/datepicker_8994
Datepicker: Handle when yearRange is a year or a modifier. Fixed #8994 -...
2013-01-23 11:50:00 -08:00
David Petersen
8f7c3e309c Datepicker: Handle when yearRange is a year or a modifier. Fixed #8994 - Datepicker: next and prev buttons are disabled when using yearRange 2013-01-23 13:41:01 -06:00
Scott González
10c873ab6c Accordion: Add panel in addition to content for create event. Fixes #8998 - Accordion: Create event uses content instead of panel. 2013-01-22 09:19:04 -05:00
Scott González
673c6558e0 Accordion: Properly set corner classes on refresh. Fixes #8995 - Accordion: Corner display issues. 2013-01-22 08:56:38 -05:00
Felix Nagel
f5e65b0819 Merge branch 'master' into selectmenu 2013-01-18 19:25:30 +01:00
Corey Frang
722c4bed99 Updating to jQuery Color 2.1.2 2013-01-16 11:15:16 -06:00
Dominic Barnes
176e0ed0e6 Slider: Moved events to named functions (to allow extended plugins to hook in). 2013-01-14 12:48:32 -05:00
Mike Sherov
e4a786e1a4 Tooltip: Avoid errors on mouseover of tooltips with parents that have no title attribute. Fixes #8955 - Tooltip: error when parent element has no title attribute using jQuery <1.7
This corrects a failing test with core 1.6, so no new test is required.
2013-01-11 08:35:51 -05:00
Felix Nagel
4d77ca3e21 Selectmenu: Update copyright year to 2013 2013-01-10 19:16:41 +01:00
Felix Nagel
dcb28a7c71 Merge branch 'master' into selectmenu 2013-01-10 19:13:54 +01:00
Scott González
83cbf97978 Update copyright year to 2013. 2013-01-10 08:52:20 -05:00
Mike Sherov
78a6354180 Effects: fix backwards compatibility in animateClass for jQuery Core <1.8 2013-01-08 21:36:34 -05:00
Scott González
68e5ebcf1a Datepicker i18n: Fix line endings. 2013-01-08 08:09:34 -05:00
Mike Sherov
da01fb6a34 Effects: Avoid cssHook blending in non-rgba browsers when the value is "transparent". Fixes #8914: odd behaviour of css hook when setting backgroundColor to transparent in IE7/8 2013-01-03 14:33:41 -05:00
Jörn Zaefferer
fb47fd0310 Merge branch 'master' into selectmenu 2013-01-03 09:45:09 +01:00
Mike Sherov
f667d090a7 Interactions: Update widget defaults to match documented API. 2013-01-02 18:27:22 -05:00
Mike Sherov
b477098da5 Slider: add options for event callbacks 2013-01-02 14:58:12 -05:00
Felix Nagel
c9602857dd Selectmenu: improve element creation 2013-01-02 19:52:18 +01:00
Felix Nagel
1ba02e9c5f Merge branch 'master' into selectmenu 2013-01-02 19:38:55 +01:00
Felix Nagel
2eb92232f3 Selectmenu: make sure position option could be overwritten 2013-01-02 19:36:56 +01:00
TJ VanToll
695358983e Selectable: Account for scrolling on the helper's initial position. Fixed #8915 - Selectable: Lasso offset issue with scrolling. 2013-01-01 08:22:18 -05:00
Kris Borchers
5561f5db12 Add comment explaining the mouseHandled flag 2012-12-29 20:08:35 -06:00
Kris Borchers
5143b7f672 Create mouseHandled flag per instance instead of globally. Fixes #8866 - Menu: select event not firing due to mouseHandled flag reset bug 2012-12-27 21:06:54 -06:00
Jörn Zaefferer
2c3d311f90 Menu: Allow changing icons option after creation. Fixes #8927 - Menu: Can't change icons option after init 2012-12-27 17:23:25 +01:00
Jörn Zaefferer
0d53fbfd0b Spinner: Trigger start/spin/stop events when calling step/page methods. Fixes #8901 - Spinner does not fire start/spin/stop events when calling stepUp()/Down(), pageUp()/Down() methods 2012-12-27 17:06:01 +01:00
Jörn Zaefferer
04d668b717 Spinner: Update button icons when option changes. Fixes #8926 - Spinner: Can't change icons option after init 2012-12-27 12:50:04 +01:00
Mike Sherov
74d7eac2da All: Convert single quotes to double quotes. 2012-12-25 12:01:09 -05:00
Mike Sherov
63d624fcb5 Datepicker: Use tabs for indentation. 2012-12-25 08:41:09 -05:00
Felix Nagel
44e472a613 Merge branch 'master' into selectmenu 2012-12-20 22:05:23 +01:00
Scott González
e21fc29610 Datepicker: Remove data event handlers from the dark ages. 2012-12-20 10:12:40 -05:00
Felix Nagel
dab7bf8993 Merge branch 'master' into selectmenu 2012-12-20 00:32:28 +01:00
Felix Nagel
50d7a969a5 Selectmenu: improve _setOption to make it possible to change icons option after init 2012-12-20 00:16:37 +01:00
Felix Nagel
a787d52d4a Selectmenu: make dropdown style default and remove option dropdown 2012-12-20 00:10:06 +01:00
Felix Nagel
52fc8e3c70 Selectmenu: add option icons 2012-12-18 19:55:04 +01:00
Dominic Barnes
209443d716 Slider: Create clone of options.values during _create(). Fixed #8892 - Multiple Sliders have Conflict with options.values. 2012-12-18 11:48:10 -05:00
Scott González
9cbd4b4222 Tooltip: Clear the tracking interval on close. Fixes #8920 -Tooltip potential setinterval endless loop. 2012-12-18 08:38:36 -05:00
Matthieu Penant
9f841dffcc Datepicker: Added Candian French locale. Fixes #8917 - Datepicker: Add Canadian French locale. 2012-12-17 08:30:23 -05:00
Felix Nagel
1afede867d Selectmenu: remove zIndex 2012-12-16 01:44:19 +01:00
Felix Nagel
76f335ea68 Selectmenu: CGL and lint fixes 2012-12-15 02:40:14 +01:00
Felix Nagel
57ecee889d Selectmenu: rework appendTo functionality 2012-12-15 02:21:51 +01:00
Felix Nagel
8aa24dd1d5 Merge branch 'master' into selectmenu 2012-12-15 01:10:32 +01:00
Felix Nagel
e2b5123f37 Selectmenu: introduce _setText helper function to improve handling of empty strings 2012-12-14 18:04:51 +01:00
Scott González
8ec7a1b69f All: Use .addBack() instead of .andSelf(). 2012-12-14 11:13:50 -05:00
Scott González
80e46c93a8 Autocomplete: Append to closest .ui-front if available. 2012-12-14 09:10:32 -05:00
Felix Nagel
1ea22565d3 Selectmenu: fix closing of empty selects 2012-12-13 01:12:52 +01:00
Felix Nagel
c69d01bed7 Selectmenu: replace placeholder entity with &#160; 2012-12-13 00:54:45 +01:00
Felix Nagel
89019606eb Selectmenu: revert change to text instead of html, otherwise the unicode special char wont be displayed 2012-12-13 00:53:51 +01:00
Felix Nagel
ed422bd855 Selectmenu: removed ugly workaround for IE9 to make sure the menu is built on first focus 2012-12-12 23:43:32 +01:00
Felix Nagel
b15ae2a64f Selectmenu: merge and explain if statements in Menu focus event, remove unneeded Menu focus method call in open 2012-12-12 19:31:39 +01:00
Felix Nagel
20aad07fe4 Selectmenu: fix comment typo 2012-12-12 17:39:00 +01:00
Felix Nagel
07328359e9 Selectmenu: use method _documentClick for adding events to the document 2012-12-12 17:26:17 +01:00
Scott González
ff78d0bbce Core: Moved selectstart support test to deprecated section. 2012-12-12 11:22:08 -05:00
Scott González
f5aaf874e9 Progressbar: Moved .ui-progressbar-indeterminate to main element. Added tests for markup structure. 2012-12-12 11:21:49 -05:00
Felix Nagel
f6372bd7ea Merge branch 'master' into selectmenu 2012-12-12 16:44:19 +01:00
Felix Nagel
d1350f9f11 Selectmenu: improve option appendTo handling in appendTo method 2012-12-12 16:34:56 +01:00
Scott González
747d853452 Core: Removed $.ui.contains. Fixes #8902 - Remove $.ui.contains. 2012-12-12 08:54:53 -05:00
Scott González
0f111a2ac4 Dialog: Spacing. 2012-12-12 08:47:21 -05:00
Scott González
b9f206dbcf Dialog: Cleanup. 2012-12-11 16:23:18 -05:00
Jörn Zaefferer
2845d38d40 Selectmenu: Select value when closing with space 2012-12-09 12:58:47 +01:00
Jörn Zaefferer
15032d17d9 Selectmenu: Remove colons from labels, annoying for screenreader-users. Cleanup whitespace. 2012-12-09 12:36:35 +01:00
Scott González
d4551bc3b8 Dialog: Respect maxHeight when determining size on open. Fixes #4820 - Dialog: Auto height does not respect the maxHeight option. 2012-12-07 16:57:03 -05:00
Scott González
70b16ef445 Dialog: Added appendTo option. Fixes #7948 - Dialog: Allow dialog to be attached to a element other than body. 2012-12-07 14:54:21 -05:00
Scott González
da17a232ca Autocomplete: Handle detached elements for appendTo after create. 2012-12-07 11:58:58 -05:00
Scott González
a1eb9ca4be Position: Split out dimension parsing. 2012-12-06 15:00:42 -05:00
Scott González
fb38c20763 Droppable: Added missing semicolon. 2012-12-06 14:43:35 -05:00
Scott González
3ec0c2e572 Core: Removed $.ui.isOver() and $.ui.isOverAxis(). Fixes #8891 - Remove $.ui.isOver() and $.ui.isOverAxis(). 2012-12-06 14:42:10 -05:00
Scott González
b239298946 Allow higher cyclomatic complexity in functions that sanely use switch statements. 2012-12-06 14:31:21 -05:00
Scott González
ebf8a60187 Tabs: Reduce cyclomatic complexity. 2012-12-06 14:31:21 -05:00
Kris Borchers
b44375aef1 Progressbar: Take min into account when calculating percentage. 2012-12-06 11:07:07 -06:00
Scott González
f7614706ab Progressbar: Cleanup, byte shaving. 2012-12-06 10:10:07 -05:00
Scott González
f1be88e795 Progressbar: Only remove aria-valuenow for indeterminate progressbars. Added more accessibility tests. 2012-12-06 09:35:41 -05:00
Scott González
8c763cdf98 Progressbar: Define defaults for callbacks. 2012-12-06 09:21:25 -05:00
Scott González
1e5662ebe5 Tabs: Decode URIs before comparing. Fixes #8877 - Tabs: isLocal function issue in Safari 5.1.7. 2012-12-05 17:19:14 -05:00
Scott González
f59f5a8b12 Dialog: Restore inline styles for dimensions/display. Fixes #8119 - Dialog: Destroying a dialog leaves some styles changed. 2012-12-05 11:53:34 -05:00
Bjørn Johansen
70f5d18c71 Datepicker: Added Norwegian Bokmål and Norwegian Nynorsk locales. Fixes #8886 - Datepicker: Add Norwegian Bokmål (nb) and Norwegian Nynorsk (nn) locales.
Signed-off-by: Bjørn Johansen <bjorn.johansen@metronet.no>
2012-12-05 11:03:11 -05:00
Pavel Selitskas
cff4c3c4f3 Datepicker: Added Belarusian locale. Fixes #8885 - Datepicker: Add Belarusian locale. 2012-12-05 10:54:53 -05:00
Scott González
598cdae199 Datepicker: Handle changes to the disabled option. Fixes #8883 - Datepicker: Changing disabled option doesn't work. 2012-12-05 10:38:31 -05:00
Scott González
3c2acc3227 Dialog: Remove width, min-height, height styles on destroy. Fixes #8119 - Dialog: Destroying a dialog leaves some styles changed. 2012-12-04 10:03:05 -05:00
Scott González
050e71bdd8 Revert "Dialog: Cleanup style properties on _destroy. Reenables style check in domEqual, while removing commented and unnecessary old code. Fixes #8119 - Dialog: Destroying a dialog leaves style, scrollleft, and scrolltop leftovers."
This reverts commit d687a1b10d.
2012-12-04 09:21:33 -05:00
Scott González
8072099a3a Revert "Menu: Remove display property on hidden submenus instead of setting display:block. Surfaced by domEqual now checking for style property (see d687a1b)."
This reverts commit 53b940fa27.
2012-12-04 09:21:16 -05:00
Scott González
86f1087931 Revert "Tabs: Remove display property on hidden panels instead of setting display:block. Surfaced by domEqual now checking for style property (see d687a1b)."
This reverts commit b9068c1523.
2012-12-04 09:20:56 -05:00
Jörn Zaefferer
9bd44301d3 Dialog: Refactor _createOverlay and _destroyOverlay to use widget methods and properties. 2012-12-04 01:17:00 +01:00
Jörn Zaefferer
1e8baf5683 Dialog: Remove the instance-storing for the overlay, just create one whenever it is needed. Heavily simplifies the code, while the memorly leak should be hardly an issue anymore, since fixed positioning restricts the overlay size to the window dimensions. Fixes #6058 - Dialog overlays are not properly reused when multiple instances of a Dialog exist. 2012-12-04 01:08:34 +01:00
Jörn Zaefferer
b9068c1523 Tabs: Remove display property on hidden panels instead of setting display:block. Surfaced by domEqual now checking for style property (see d687a1b). 2012-12-04 00:56:14 +01:00
Jörn Zaefferer
53b940fa27 Menu: Remove display property on hidden submenus instead of setting display:block. Surfaced by domEqual now checking for style property (see d687a1b). 2012-12-04 00:49:37 +01:00
Jörn Zaefferer
d687a1b10d Dialog: Cleanup style properties on _destroy. Reenables style check in domEqual, while removing commented and unnecessary old code. Fixes #8119 - Dialog: Destroying a dialog leaves style, scrollleft, and scrolltop leftovers. 2012-12-04 00:35:47 +01:00
Felix Nagel
e6aca63a77 Selectmenu: simplify $.each usage in _readOptions method 2012-12-03 23:28:06 +01:00
Felix Nagel
aa60a9e114 Selectmenu: use item.index instead of _getSelectedItem method 2012-12-03 23:19:15 +01:00
Felix Nagel
60e3302d96 Selectmenu: use text() instead of html() as the option and optgroup is read as text 2012-12-03 23:07:30 +01:00
Felix Nagel
cba09dafa7 Selectmenu: guard clause should not return false 2012-12-03 23:05:09 +01:00
Felix Nagel
04553a7da5 Selectmenu: close guard close should test for closed menu 2012-12-03 23:04:53 +01:00
Scott González
8b15aaf496 Widget: Don't modify the prototype passed to $.widget(). Fixes #8876 - Calling _super calls wrong inherited widget. 2012-12-03 14:18:24 -05:00
Scott González
5ba267e7c7 Resizable: Respect containment for alsoResize option. Fixes #4603 - Resizable: alsoResize option doesn't work with containment. Fixes #5559 - Dialog: Content grows bigger than widget on resize at document edge. 2012-12-03 10:36:55 -05:00
Jörn Zaefferer
13505e5945 Dialog: Ensure all animations finish and clean up themselve when destroying dialog. Fixes #5860 - Dialog: Destroying a dialog during animated close leaves .ui-effects-wrapper in DOM. 2012-11-30 13:08:56 +01:00
Kris Borchers
f2ee4c51aa Progressbar: Create and destroy indeterminate overlay as needed and code cleanup. 2012-11-29 22:13:39 -06:00
Felix Nagel
0d282630de Selectmenu: make isOpen check a guard clause in close method 2012-11-29 20:57:44 +01:00
Felix Nagel
18ecaf45db Selectmenu: added comment about popup positioning 2012-11-29 20:33:05 +01:00
Felix Nagel
f622428c43 Selectmenu: improve disabled check in open method 2012-11-29 20:23:30 +01:00
Felix Nagel
ac7b8f925a Selectmenu: improve comment in _drawMenu 2012-11-29 20:20:43 +01:00
Felix Nagel
1e6808a1a2 Selectmenu: replace placeholder entity with &#160; 2012-11-29 20:13:57 +01:00
Felix Nagel
a177a92635 Selectmenu: improve element creation 2012-11-29 20:10:05 +01:00
Felix Nagel
e581a13c10 Selectmenu: remove unnecessary comments from _drawButton 2012-11-29 20:06:00 +01:00
Felix Nagel
71e744ad30 Selectmenu: move button event binding in _drawButton 2012-11-29 19:54:10 +01:00
Felix Nagel
080b5bca0a Selectmenu: remove unnecessary comments from _create 2012-11-29 19:53:12 +01:00
Felix Nagel
b014bc6245 Selectmenu: alphabetical ordering of options and callback events 2012-11-29 19:49:43 +01:00
Felix Nagel
8a62210538 Selectmenu: updated documentation link 2012-11-29 19:41:20 +01:00
Jörn Zaefferer
24d9141597 Dialog: Use consistent code for appending to body 2012-11-29 17:40:31 +01:00
Felix Nagel
7328333773 Selectmenu: better position handling, fixes issue with wrong styles when using custom positioning 2012-11-29 00:58:28 +01:00
Felix Nagel
36533a718d Merge branch 'master' into selectmenu 2012-11-28 23:29:15 +01:00
Scott González
dec844570f Autocomplete: When appendTo is a jQuery object or a DOM element, don't search against the document. Fixes #8858 - Autocomplete: Fails when appendTo is detached from the DOM. 2012-11-28 10:33:59 -05:00
Scott González
f2854408cc Tooltip: Escape the title attribute so that it's treated as text and not HTML. Fixes #8861 - Tooltip: XSS vulnerability in default content. 2012-11-27 11:21:33 -05:00
Viktor Kojouharov
c5e0961268 Effects: Use $ instead of jQuery in $.effects.animateClass. Fixes #8860 - Effects: Class animation has broken noConflict support. 2012-11-27 08:27:48 -05:00
Scott González
e6e706bbd6 Datepicker: Remove JSHint overrides. 2012-11-27 08:22:21 -05:00
Scott González
7c53af0abc Datepicker: Remove support for setting options via custom attributes. 2012-11-26 22:50:36 -05:00
Fabrício Matté
caacf8f504 Button: Let change handler handle display and aria update. Fixed #5518 - Button: Incorrect state after double click in Firefox 2012-11-26 20:15:53 -05:00
David Petersen
6121683d80 Tabs: Calculate border and padding on tabs container. Fixed #8836: Height overflows parent with heightStyle: 'fill'. 2012-11-26 16:35:07 -05:00
TJ VanToll
0cd470b0d5 Resizable: Modified the default z-index value of resizable handles. Fixed #7960 - Dialog: Modal dialogs do not disable resizables on the page. 2012-11-26 12:42:44 +01:00
Jörn Zaefferer
7e9060c109 Dialog: Extract setting the title into a _title method, use .text() to prevent XSS. Fixes #6016 - Dialog: Title XSS Vulnerability. 2012-11-26 10:28:25 +01:00
Jörn Zaefferer
60486ac632 Dialog: Don't focus dialog when mousedown is on close button. Fixes #8838 - Dialog: Close icon does not work in dialog larger than the window in IE. 2012-11-26 10:28:25 +01:00
Kris Borchers
d179cbaf32 Dialog: Update position when size is changed. Fixes #8789 - Dialog does not close for first click on chrome. 2012-11-26 10:28:25 +01:00
Jörn Zaefferer
ec1f1bde76 Dialog: Follow-up to c77ca67 - exclude button options from properties to create the button. 2012-11-26 10:28:25 +01:00
Jörn Zaefferer
a09f5c07f5 Dialog: Follow-up to 9fe3a62d8 - also deprecate string notation for position option. 2012-11-26 10:28:25 +01:00
Jörn Zaefferer
32a893128d Dialog: Improve _destroy method, detaching dialog content from wrapper instead of appending to body. 2012-11-26 10:28:24 +01:00
Jörn Zaefferer
41c2afd66b Dialog: Refactor overlay handling into two instance methods. Remove unaddressable TODOs. 2012-11-26 10:28:24 +01:00
Jörn Zaefferer
a0310eb091 Dialog: Move array notation support for position option to backCompat check. Fixes #8824 - Deprecate array notation for position option. 2012-11-26 10:28:24 +01:00
Jörn Zaefferer
0be97bf8c0 Dialog: Removed broken disabled option from dialog, defuse disable/enable methods. Disabling dialogs is not supported. 2012-11-26 10:28:24 +01:00
Jörn Zaefferer
b27db7e3b9 Dialog: Extend autofocus, starting with [autofocus], then :tabbable content, then buttonpane, then close button, then dialog. Fixes #4731 - Dialog: Add option to set which element gains focus on open 2012-11-26 10:28:24 +01:00
Jörn Zaefferer
999617343f Dialog: Pass through icons and showText (as 'text') options to button. Fixes #6830 - Allow Icons to be specified for Dialog buttons. 2012-11-26 10:28:23 +01:00
Jörn Zaefferer
d8b98ec3bb Dialog: Tiny code improvements 2012-11-26 10:28:23 +01:00
Jörn Zaefferer
e3dcaf28eb Dialog: Remove uuid and getTitleId. Leftovers from 240b22b143. 2012-11-26 10:28:23 +01:00
Jörn Zaefferer
0bc73b74b6 Dialog: Remove busted ui-dialog-disabled class, shouldn't be there. Removed outdated TODOs. 2012-11-26 10:28:23 +01:00
Jörn Zaefferer
972f5c192c Dialog: Button is now a fixed dependency, so remove the check 2012-11-26 10:28:23 +01:00
Jörn Zaefferer
0ae6fc1e02 Dialog: Remove useless tmp vars. 2012-11-26 10:28:23 +01:00
Jörn Zaefferer
625a111fb9 Dialog: Extracting wrapper creation into _createWrapper. Merging the two keydown handlers into one. 2012-11-26 10:28:23 +01:00
Jörn Zaefferer
4c9caa8169 Dialog: Extract button pane creation into _createButtonPane 2012-11-26 10:28:22 +01:00
Jörn Zaefferer
1d6ce644e0 Dialog: Refactor _create, extracting title bar creation in _createTitlebar 2012-11-26 10:28:22 +01:00
Jörn Zaefferer
f0acaac230 Dialog: Refactor uiDialogTitlebar variable, use this.uiDialogTitlebar instead. Wasn't needed anymore (previous refactorings). 2012-11-26 10:28:22 +01:00
Jörn Zaefferer
7a0353500a Dialog: Refactor the mousedown-bind call to use _on, removing the need for the uiDialog closure. Use this.uiDialog and remove the variable. 2012-11-26 10:28:22 +01:00
Jörn Zaefferer
1001504249 Dialog: Remove outdated TODO 2012-11-26 10:28:22 +01:00
Jörn Zaefferer
c8aef203cb Dialog: Have _makeResizable look at options instead of passing handles. 2012-11-26 10:28:22 +01:00
Jörn Zaefferer
16a79c1b9c Dialog: Finish refactoring _setOption, getting rid of unnecessary switch (no fallthroughs). 2012-11-26 10:28:22 +01:00
Jörn Zaefferer
7e964be80c Dialog: Have _createButtons access the buttons option directly. Start refactoring _setOption, no need for switch. 2012-11-26 10:28:22 +01:00
Jörn Zaefferer
fed2972027 Dialog: Refactor _setOption to call _super early. Move dialogClass update above that to access old option value. 2012-11-26 10:28:22 +01:00
Jörn Zaefferer
83a9f219bf Dialog: Use button widget for close button (was already listed as dependency) 2012-11-26 10:28:21 +01:00
Jörn Zaefferer
0848040d3e Dialog: Focus tabbable only when dialog lost focus before. 2012-11-26 10:26:12 +01:00
Jörn Zaefferer
6edce86733 Dialog: Remove attroperty workaround for title attribute. Make the default null, as it should be. No back-compat, as the behaviour doesn't change. 2012-11-26 10:26:12 +01:00
Jörn Zaefferer
f7d3a51589 Dialog: Only add the new dialogClass, not the base classes when changing the option. 2012-11-26 10:26:12 +01:00
Jörn Zaefferer
324d54dd32 Dialog: Use $.isEmptyObject() to check if there a button-option properties 2012-11-26 10:26:12 +01:00
Jörn Zaefferer
4e03321fd7 Dialog: Trigger focus event when dialog is moved to top. 2012-11-26 10:26:12 +01:00
Jörn Zaefferer
b6cefc797e Dialog: Remove deprecated disableSelection() usage. 2012-11-26 10:26:11 +01:00
Jörn Zaefferer
4632780435 Dialog: Fix yoda-if, remove unnecessary TODOs; add missing callbacks to commons test 2012-11-26 10:26:11 +01:00
Jörn Zaefferer
2062a18db6 Dialog: Inline code review 2012-11-26 10:26:11 +01:00
Jörn Zaefferer
0a25b2c448 Dialog: move to top when opening again, and focus as if opened from scratch. 2012-11-26 10:26:11 +01:00
Jörn Zaefferer
8ee8046c02 Dialog: Keep focus inside modal dialog, by handling focus events on elements outside of it 2012-11-26 10:26:11 +01:00
Jörn Zaefferer
2a887e4321 Dialog: Improve accessibilty - add an aria-describedby attribute on the dialog if there is nothing yet in the dialog content. Partial fix for: 2012-11-26 10:26:11 +01:00
Corey Frang
d7adc2bae9 Effects Core: Upgrading jQuery Color to 2.1.1 2012-11-23 11:18:07 -06:00
Felix Nagel
4e68c526ab Selectmenu: removed Position Plugin offset option to fix broken pop-up functionality 2012-11-23 15:38:33 +01:00
Felix Nagel
e25cdd88e7 Merge branch 'master' into selectmenu 2012-11-23 13:49:12 +01:00
Corey Frang
a217bd3b16 Effects: Making sure outerHeight and outerWidth make it through to the .size() implementation in all cases - Fixes IE8 effects failure 2012-11-22 04:12:30 -06:00
kborchers
d3bc471688 Progressbar: Add ability to set value: false for an indeterminate progressbar. Fixes #7624 - Progressbar: Support value: false for indeterminate progressbar 2012-11-21 21:48:17 -06:00
Mike Sherov
509259a66e Button: add explanatory comment for when we bind to blur 2012-11-21 19:58:59 -05:00
TJ VanToll
93abe02b60 Button: Fixing handling of the disabled options on refresh method calls. Fixed #8828 - Button: Refresh does not re-enable disabled button. 2012-11-21 19:24:24 -05:00
Samuel Bovée
cb748b4a6f Slider: factorize code with Widget method call. Fixed #8772 - Wrong slider UI state when disabled at init 2012-11-21 19:18:00 -05:00
Mike Sherov
f13b5dfa7f Button: add blur event to buttons. Fixes #8559 - Button: Button doesn't remove active state when using keyboard. 2012-11-21 19:14:04 -05:00
Scott González
d5afdba4cb Autocomplete: Whitespace. 2012-11-19 17:08:41 -05:00
Roman Salnikov
7ffcaa2e3b Datepicker: reinitialize datepicker if mainDiv isn't on the page. Fixed #5679 - Datepicker should reinitialize if dpDiv is removed 2012-11-19 09:15:10 -05:00
mathias.stenbom
cf9fbce139 Draggable: made handles work with complex markup. Fixes #8757 - Draggable: Resizable handle with inner element does not work, when its also draggable 2012-11-19 09:06:50 -05:00
Mike Sherov
cc7df712cc Button: properly escape button names. Fixes #7505 - Button: Buttonset not applied to radio group with quotation/apostrophe in name. 2012-11-19 08:37:41 -05:00
Mike Sherov
4334b5d4f1 Dev: make Datepicker pass JSHint with only eval setting overridden 2012-11-18 15:01:30 -05:00
Mike Sherov
53c462b666 Dev: make draggable pass JSHint with no local overrides 2012-11-18 11:44:12 -05:00
Mike Sherov
0e800636c4 Dev: Make droppable pass JSHint with no local settings overrides 2012-11-17 14:51:56 -05:00
Mike Sherov
5bae9a4763 Dev: Make sortable pass JSHint with only the loopfunc setting override 2012-11-17 14:24:44 -05:00
Mike Sherov
a1b32b59d5 Resizable: use css() instead of position() for absolute placement. Fixes #3815 - Resizable: absolutely positioned element inside scrollable element is repositioned when resized 2012-11-17 01:29:39 -05:00
Mike Sherov
9eaa572de1 Dev: Make resizable pass JSHint without any settings overrides 2012-11-17 00:08:01 -05:00
Scott González
3541c54082 Tabs: Removed some legacy code that isn't doing anything. 2012-11-16 16:57:36 -05:00
Scott González
23f7e30c77 Tabs: Remove ui-tabs-aria-controls data on destroy. 2012-11-16 16:10:22 -05:00
Juan Pablo Kaniefsky
a18863205e Slider: when handles overlap, clicking and dragging will now pick the last one that was moved. Fixed #3467 - Sliders Handles can overlap, only small sliver of slider is selectable 2012-11-16 09:32:56 -05:00
Jörn Zaefferer
f86168bf6b Merge branch 'master' into selectmenu 2012-11-15 17:14:19 +01:00
Scott González
3d96f20506 Datepicker: Fixed firstDay in Faroese locale. Fixes #8815 - Datepicker: Faroese locale has incorrect firstDay. 2012-11-14 15:06:37 -05:00
Scott González
ca0df6b900 Tooltip: Removed logic for handling tracking tooltips which gain focus while open (we no longer mix events). Fixes #8799 - Tooltip: tracking fails on nested elements. 2012-11-14 14:42:36 -05:00
Scott González
1b503a237e Tooltip: Handle synthetic focusin events. Fixes #8740 - Tooltip: Does not hide consistently with dynamically loaded content. 2012-11-14 14:14:45 -05:00
Jay Merrifield
eca5abd873 Datepicker: Updated the range tests so you can't navigate past the yearRange. Fixes #7362 - Datepicker allows changing year to something outside yearRange 2012-11-13 21:08:55 -05:00
Scott González
2553d61384 Accordion: Use .css() to clear the height, instead of .height(). 2012-11-13 19:02:02 -05:00
Ethan Romba
3974b55ba5 Resizable: Update CSS dimensions selectively. Fixes #7605 - Setting width and height when only one is changing
Resizable: Trigger resize event only when element is resized. Fixes #5545 - Callbacks ignore the grid.

Resizable: Added event tests. Fixes #5817 - resize event reports unconstrained ui.size
2012-11-12 21:41:22 -05:00
Felix Nagel
daec559c98 Merge branch 'master' into selectmenu 2012-11-12 23:28:24 +01:00