Commit Graph

111 Commits

Author SHA1 Message Date
Michael Wiencek
0dc84db853 Tooltip: Preserve the title after disabling twice
Fixes #9719
Closes gh-1154
2014-01-09 20:38:08 +01:00
Scott González
a8ff77360b Tooltip: Only bind remove handler for delegated tooltips
The remove handler was being added for every tooltip, but only removed for
delegated tooltips. The default destroy behavior already handles non-delegated
tooltips, so the handler should only be added for delegated tooltips.

Fixes #9531
Closes gh-1156
2014-01-09 04:12:35 -05:00
Daniel DeGroff
af85dfcafb Tooltip: On close and destroy only set title if empty or undefined
Ticket #8925 states that changes to the title attribute while the
tooltip is open are lost on tooltip close.

In the close and destroy functions, the title attribute is always
written if a value was stored in the element on open. It is possible
the attribute has changed and restoring the initial value may overwrite
the current value.

If the value is empty or undefined as set in open, do not set the title
attribute.

This fix has the limitation that if the user removed the title
attribute or set the value to an empty string the original title value
would be restored on close and destroy.

Fixes #8925
2014-01-06 16:10:02 +01:00
Dylan Barrell
b9e438d07c Tooltip: Improve accessibility by adding content to an aria-live div
Fixes #9610
Closes gh-1118
2013-12-19 10:36:30 -05:00
Scott González
f64c953497 Tooltip: Use .uniqueId() and move aria-describedby helper methods into the widget prototype. 2013-10-24 09:19:42 -04:00
Mike Sherov
e4a786e1a4 Tooltip: Avoid errors on mouseover of tooltips with parents that have no title attribute. Fixes #8955 - Tooltip: error when parent element has no title attribute using jQuery <1.7
This corrects a failing test with core 1.6, so no new test is required.
2013-01-11 08:35:51 -05:00
Scott González
83cbf97978 Update copyright year to 2013. 2013-01-10 08:52:20 -05:00
Scott González
9cbd4b4222 Tooltip: Clear the tracking interval on close. Fixes #8920 -Tooltip potential setinterval endless loop. 2012-12-18 08:38:36 -05:00
Scott González
8ec7a1b69f All: Use .addBack() instead of .andSelf(). 2012-12-14 11:13:50 -05:00
Scott González
f2854408cc Tooltip: Escape the title attribute so that it's treated as text and not HTML. Fixes #8861 - Tooltip: XSS vulnerability in default content. 2012-11-27 11:21:33 -05:00
Scott González
ca0df6b900 Tooltip: Removed logic for handling tracking tooltips which gain focus while open (we no longer mix events). Fixes #8799 - Tooltip: tracking fails on nested elements. 2012-11-14 14:42:36 -05:00
Scott González
1b503a237e Tooltip: Handle synthetic focusin events. Fixes #8740 - Tooltip: Does not hide consistently with dynamically loaded content. 2012-11-14 14:14:45 -05:00
Scott González
498aadf644 Tooltip: Ignore disabled checks when closing. Fixes #8758 - Tooltip: Tooltip is shown, but not hidden if element has class=ui-state-disabled. 2012-11-09 13:07:53 -05:00
Scott González
02694a90f3 Tooltip: Use ui-tooltip-open instead of tooltip-open for data key. 2012-11-05 15:03:15 -05:00
Jörn Zaefferer
1d9eab1ead Tooltip: Make 'flipfit flip' the collision default to avoid the tooltip ever overlapping the trigger. Also fix max-width for custom-content demo. Fixes #8739 - Tooltip: Default positioning on large items off. 2012-11-05 19:05:58 +01:00
Jörn Zaefferer
98173a3d0e Tooltip: Check type on event directly, preventing TypeError when programmatically moving focus to track-toolipped-input. Fixes #8747 - Tooltip: Using the track option within dialogs creates JS errors 2012-11-05 18:59:52 +01:00
Scott González
d074efe528 Tooltip: Use attributes, not properties, when checking for parent tooltips. Fixes #8742 - Tooltip shows incorrect message in chrome if there is input with name='title' in a form. 2012-10-28 20:28:55 -04:00
Scott González
68cab60fa7 Removed bgiframe. 2012-10-26 10:53:17 -04:00
Jörn Zaefferer
ba752cf7ed Tooltip: Run _disable when disabled option is set on create. Fixes #8712 - Tooltip: Disabled tooltips on initialization. 2012-10-24 10:02:21 -04:00
Mike Sherov
e1230997aa Build: Enable "unused" option in jshint - Remove unused variables from codebase. - Closes gh-788
Squashed commit of the following:

commit 7f19f92c64
Author: Mike Sherov <mike.sherov@gmail.com>
Date:   Tue Oct 23 10:34:28 2012 -0400

    put back in fake args for signatures that we want to keep

commit 257505a9e6
Author: Mike Sherov <mike.sherov@gmail.com>
Date:   Tue Oct 23 08:10:20 2012 -0400

    changes per @scott_gonzalez

commit 12725480cb
Author: Mike Sherov <mike.sherov@gmail.com>
Date:   Mon Oct 22 22:54:05 2012 -0400

    clean up unused vars in ui directory

commit 563595e7ae
Author: Mike Sherov <mike.sherov@gmail.com>
Date:   Mon Oct 22 22:37:42 2012 -0400

    clean up unused vars in grunt and tests
2012-10-23 09:37:46 -05:00
Scott González
7af1ec727b Tooltip: Position below the element and set a max width of 300px to more closely match native tooltip behavior. Fixes #8718 - tooltip flickers when too long. 2012-10-23 10:15:28 -04:00
Andrew Couch
0b3e59f149 Tooltip: Do not attempt to position if tooltip is hidden. Fixed #8644 - Delayed tooltips set to track should reposition when being shown for the first time. 2012-10-21 13:15:59 -04:00
Andrew Couch
3b2d1e7736 Tooltip: handle removal of elements with delegated tooltips. Fixed #8646 - Delegated tooltips don't close when the tooltipped element is removed 2012-10-21 13:15:44 -04:00
Jörn Zaefferer
6b48ef5eca Tooltip: Only bind blur when opening via focus, mouseleave for mouseover. Remove the keep-open-on-focusout workaround. Now matching behaviour described in ARIA Authoring Practices. Fixes #8699 - Moving focus on click of a tooltipped element shows native tooltip in IE/Firefox on Windows 2012-10-21 12:50:12 -04:00
Jörn Zaefferer
77a55f1291 Tooltip: Fix nested tooltips (on hover) by closing parent tooltips and removing title attributes. Fixes #8700 - Overlapping tooltipped elements shows native tooltip for one of the elements 2012-10-21 12:49:32 -04:00
Jörn Zaefferer
9d5f91ece2 Tooltip: Comment why we need to use closest 2012-10-19 20:57:13 -04:00
Scott González
bd3a348776 Tooltip: Change the default items selector to exclude disabled elements. Fixes #8661 - Tooltip doesn't hide on disabled anchor element [IE only]. 2012-10-12 20:26:47 -04:00
Scott González
0a31a82831 Tooltip: Better cleanup on destroy. Fixes #8627 - The Tooltip destroy method is not clearing up the data properties. 2012-10-05 12:52:02 -04:00
Scott González
96f2aa4c72 Tooltip: Check if event exists before checking properties in open(). Fixes #8626 - Programatically opening a tooltip with out giving an event results in a javascript error. 2012-10-05 11:26:49 -04:00
Scott González
d434c9a442 typo 2012-10-04 11:59:11 -04:00
Scott González
f5261f359e Tooltip: Stop tracking the mouse if the element gains focus. Fixes #8622 - Tooltip tracks mouse when the element has focus. 2012-10-04 11:14:37 -04:00
Scott González
149567e476 Updated docs URLS. 2012-09-26 18:06:20 -05:00
Scott González
e242868f56 Tooltip: Allow strings for content option. 2012-08-31 15:41:45 -04:00
Scott González
dee7c8bd44 Tooltip: Update open tooltips if the content option changes. Fixes #8544 - Unable to update tooltip content dynamically. 2012-08-31 15:38:21 -04:00
Scott González
485ca7192a Simplify licensing. 2012-08-09 15:09:50 -04:00
Scott González
a4534bb993 Update copyright to jQuery Foundation. 2012-07-04 09:08:08 -04:00
Scott González
d740e450aa Tooltip: Reposition tracking tooltips when they gain focus. 2012-06-14 12:40:03 -04:00
Jörn Zaefferer
5c2cf39dff Tooltip: Add track option 2012-06-14 12:38:13 -04:00
Scott González
ff39bed57a Widget: Added _off() for removing event handlers. Fixes #7795 - Widget: _on and _off. 2012-06-14 12:33:16 -04:00
Scott González
9608e98149 Widget: Rename _bind() to _on(). Partial fix for #7795 - Widget: _on and _off. 2012-06-13 08:00:45 -04:00
Scott González
e8b623207a Tooltip: When calling the content response method multiple times, only update the content, don't do any other processing. 2012-06-13 05:18:48 -04:00
Jörn Zaefferer
0c87dd1f45 Tooltip: Cleanup comments 2012-05-22 18:34:00 +02:00
Scott González
b6cc9dd870 Tooltip: Handle multiple aria-describedby values. 2012-05-22 11:06:44 -04:00
Jörn Zaefferer
653673ed64 Tooltip: Fix the accessible properties IE exposes 2012-05-09 18:26:19 +02:00
Scott González
dbf31da79f Tooltip: Only check if the element is active if the event that is causing the tooltip to close is not focusout. 2012-04-30 13:31:14 -04:00
Jörn Zaefferer
5cf3f927a0 Tooltip: Remove bad docs links from headers 2012-04-17 09:56:20 +02:00
Scott González
639afa5954 Lint fixes. 2012-04-02 19:12:21 -04:00
Jo Liss
37dcc3e21d Protect all copyright notices against minification
For instance, this is useful for the jquery-ui-rails gem, which does not
use jQuery UI's own minification, but relies on Rails to minify the
files where necessary. Rails in turn uses UglifyJS for JS and YUI for
CSS, both of which respect the /*! ... */ convention.
2012-04-02 15:21:06 +02:00
Scott González
45a5a24dfe Tooltip: Store the title in ui-tooltip-title data only if the element has a title. 2012-03-30 09:06:06 -04:00
Scott González
56de22eead Tooltip: Avoid infinite recursion when disabling a tooltip on close. 2012-03-29 18:36:38 -04:00