Nate Eagle
3829a37ca1
Dialog: Awesome new stacking and overlay implementation. Fixes the following tickets:
...
Fixes #3534 - Dialog: Modal dialog disables all input elements on page.
Fixes #4671 - Dialog: Modal Dialog disables vertical scroll bar in Chrome & Safari.
Fixes #4995 - Dialog: Modal Dialog's overlay dissapears in IE when content is tall.
Fixes #5388 - Dialog: Don't change z-index when already at the top.
Fixes #5466 - Dialog: "modal" Dialog Incorrectly Cancels Input Events.
Fixes #5762 - Dialog: Get rid of z-index workaround, document it instead.
Fixes #6267 - Dialog: checkboxes that inherit a z-index < jqueryui.dialog z-index don't work.
Fixes #7051 - Dialog: modal prevents tab key from moving focus off slider handle.
Fixes #7107 - Dialog: Modal dialog event loss with high zindex child elements (FF 3.6).
Fixes #7120 - Dialog: Modal operation interrupts drag drop marker functionality on gmaps.
Fixes #8172 - Dialog: Change event cancelled when opening modal dialog from another modal dialog.
Fixes #8583 - Dialog: Mouse event wrongly stopped.
Fixes #8722 - Dialog: Remove stack option.
Fixes #8729 - Dialog: Remove zIndex option.
2012-10-24 16:56:19 -04:00
Mike Sherov
e1230997aa
Build: Enable "unused" option in jshint - Remove unused variables from codebase. - Closes gh-788
...
Squashed commit of the following:
commit 7f19f92c64
Author: Mike Sherov <mike.sherov@gmail.com>
Date: Tue Oct 23 10:34:28 2012 -0400
put back in fake args for signatures that we want to keep
commit 257505a9e6
Author: Mike Sherov <mike.sherov@gmail.com>
Date: Tue Oct 23 08:10:20 2012 -0400
changes per @scott_gonzalez
commit 12725480cb
Author: Mike Sherov <mike.sherov@gmail.com>
Date: Mon Oct 22 22:54:05 2012 -0400
clean up unused vars in ui directory
commit 563595e7ae
Author: Mike Sherov <mike.sherov@gmail.com>
Date: Mon Oct 22 22:37:42 2012 -0400
clean up unused vars in grunt and tests
2012-10-23 09:37:46 -05:00
Trey Hunner
49f9b849b9
Remove trailing whitespace and add final newlines
2012-10-21 22:45:41 -04:00
Scott González
b073cda1a5
Dialog tests: Fixed calls to $.contains() that were passing jQuery objects instead of elements.
2012-07-13 15:52:32 -04:00
Scott González
5ae668fdb6
Tests: Enable QUnit.config.requireExpects.
2012-06-27 11:32:48 -04:00
Jay Merrifield
cab4c467d9
Dialog: Handle escape for all overlays. Fixes #8300 - Dialog: Incorrect behavior for ESCAPE with multiple modal dialogs.
2012-05-07 09:44:26 -04:00
Scott González
0a5a9090f8
Tests: Lint.
2012-04-19 10:28:26 -04:00
Jörn Zaefferer
72023dd045
Update to QUnit 1.3. Replace usage of same with deepEqual and equals with equal.
2012-02-29 18:36:40 +01:00
Alberto Monteiro
a4b7feabd3
Dialog: When destroy is called place the element back in original DOM position. Fixed #4980 - Dialog: Destroy should place element back in original DOM position
2011-12-15 17:52:49 -03:00
Corey Frang
dfe75e1b55
Dialog: Update to 96e5c24
- keyup apparently doesn't work like I thought it would everywhere, switching back to keydown.
2011-08-20 18:05:39 -05:00
Corey Frang
96e5c241e1
Dialog: Tabbing out of a modal dialog was possible because keypress doesn't fire for tabs everywhere, switched to keyup. Added Unit Test - Caught by @DomenicDenicola - Fixes #3123 - Tabbing stops in modal dialog
2011-08-19 06:03:59 -05:00
Scott González
da84672db8
.attr() -> .prop()
2011-06-08 17:02:57 -04:00
Jay Merrifield
f9996682b5
Dialog: Before handling escape key presses, check if the default action has been prevented. Fixes #6966 - Pressing ESC on dialog when 2 dialogs are open closes both dialogs.
2011-03-08 09:42:10 -05:00
Jay Merrifield
dfb3544297
Dialog: Make sure the overlay instance still exists before trying to remove it. Fixes #6645 - Dialog: Missing element not found check in overlay code.
2010-11-12 08:16:41 -05:00
John Firebaugh
e66cdfcf59
Dialog: Don't change DOM position on open. Fixes #6137 - dialog('open') causes form elements to reset on IE7.
2010-10-04 09:18:46 -04:00
Scott González
c090802cc1
Revert "Dialog: Don't change DOM position on open. Fixes #6137 - dialog('open') causes form elements to reset on IE7."
...
This reverts commit 67b1db14c9
.
Reverting so I can commit again with the proper author.
2010-10-04 09:18:21 -04:00
Scott González
67b1db14c9
Dialog: Don't change DOM position on open. Fixes #6137 - dialog('open') causes form elements to reset on IE7.
2010-10-04 09:15:40 -04:00
Ziling Zhao
c5770c0e84
Dialog: modified so that minWidth is respected. Fixes #5531 - dialog width should be at least minWidth on creation.
2010-07-30 15:14:48 -04:00
Scott González
c9f30818af
Dialog: Update the internal flag for whether or not the dialog is open before triggering the close event.
...
Fixes #5184 - isOpen in dialogclose event is true.
2010-02-16 02:13:38 +00:00
Ca-Phun Ung
f6b3e0c6e9
dialog: added unit test for ticket #4826
2009-09-15 16:14:15 +00:00
Richard Worth
52005f42dd
dialog unit tests: split tests into individual files
2009-02-04 04:35:18 +00:00
Richard Worth
43ab3a04e5
unit tests: created separate file for each module: core, common widget, events, methods, options, tickets
2009-02-02 14:36:08 +00:00