Scott González
a8ff77360b
Tooltip: Only bind remove handler for delegated tooltips
...
The remove handler was being added for every tooltip, but only removed for
delegated tooltips. The default destroy behavior already handles non-delegated
tooltips, so the handler should only be added for delegated tooltips.
Fixes #9531
Closes gh-1156
2014-01-09 04:12:35 -05:00
Jörn Zaefferer
247257ebc9
Menu: Fix var declaration and move regex comment to the right place.
...
Follow-up to a6806ab1
2014-01-08 18:15:04 +01:00
Daniel DeGroff
af85dfcafb
Tooltip: On close and destroy only set title if empty or undefined
...
Ticket #8925 states that changes to the title attribute while the
tooltip is open are lost on tooltip close.
In the close and destroy functions, the title attribute is always
written if a value was stored in the element on open. It is possible
the attribute has changed and restoring the initial value may overwrite
the current value.
If the value is empty or undefined as set in open, do not set the title
attribute.
This fix has the limitation that if the user removed the title
attribute or set the value to an empty string the original title value
would be restored on close and destroy.
Fixes #8925
2014-01-06 16:10:02 +01:00
Dylan Barrell
b9e438d07c
Tooltip: Improve accessibility by adding content to an aria-live div
...
Fixes #9610
Closes gh-1118
2013-12-19 10:36:30 -05:00
Felix Nagel
c9042b960f
Selectmenu: fix lint issue
2013-12-18 20:11:29 +01:00
Felix Nagel
3dfa08f227
Selectmenu: Fix empty option processing
...
Ref #9701
2013-12-18 19:30:48 +01:00
Felix Nagel
a6806ab17a
Menu: Add _isDivider method
...
Ability to prevent generation of dividers from items
Fixes #9701
2013-12-18 19:29:41 +01:00
Jyoti Deka
bc8e75059c
Resizable: remove redundant comments and whitespace
2013-12-15 13:04:38 -05:00
Jyoti Deka
20f064662a
Resizable: containment plugin restricts resizing within container
...
Fixes #7018
Fixes #9107
Closes gh-1122
2013-12-15 12:57:29 -05:00
Jyoti Deka
bae1a25b14
Resizable: fix whitespace on containment plugin
2013-12-15 12:38:18 -05:00
Jyoti Deka
c03cb8079c
Resizable: containment now works with non - immediate children
...
Fixes #7485
Closes gh-1130
2013-12-15 12:29:55 -05:00
Jyoti Deka
ec5f395260
Resizable: modified to allow resizing when resizables are nested.
...
Fixes #5025
Closes gh-1149
2013-12-14 16:08:44 -05:00
Jörn Zaefferer
3e57b29267
JSCS config: Set requireSpaceBeforeBinaryOperators, fix occurences
2013-12-09 13:02:19 +01:00
Jörn Zaefferer
8b14e49994
JSCS config: Set disallowSpaceAfterObjectKeys, fix two occurences
2013-12-09 12:55:17 +01:00
Felix Nagel
06bcd8eb62
Selectmenu: update button width on refresh
2013-12-07 19:10:50 +01:00
Jörn Zaefferer
6a483fd143
Autocomplete: Whitespace
2013-12-07 18:00:20 +01:00
Jörn Zaefferer
9de1eb0a23
Accordion: Whitespace
2013-12-07 18:00:07 +01:00
Jörn Zaefferer
c3d382e901
Menu: Remove preventDefault for disabled menu items, since there is no default on list items. Follow-up to fe7c300374
and the anchor removal in general
2013-12-03 21:57:58 +01:00
Jörn Zaefferer
fe7c300374
Menu: Remove click binding that was supposed to prevent default on anchor clicks on a disabled menu. Not relevant anymore since we removed the anchors. Partial fix for #8802 - Dev: Track down uses of .bind() inside widgets
2013-12-03 21:54:08 +01:00
Jörn Zaefferer
4992fc902e
Menu: Add ui-front on submenus to address opacity messing up stacking order. Fixes #9650 - Menu: Disabled item visible through submenu on top
2013-12-03 17:03:01 +01:00
Mike Sherov
44b2180782
Draggable: normalize lookups for rootNodes when to bust scroll cache. Fixes #9379 - Draggable: position bug in scrollable div
...
Core: update scrollParent() to support all current supported browsers.
2013-12-03 10:08:12 -05:00
Felix Nagel
a9b18bcfec
Selectmenu: add 1px to menu width to avoid wrapping long text in IE10
2013-11-26 00:56:50 +01:00
Jörn Zaefferer
9a5f20bc7d
Merge branch 'master' into selectmenu
2013-11-25 14:29:30 +01:00
Scott González
f848ae38e0
Build: Include es3 option for JSHint.
2013-11-22 09:54:27 -05:00
Jörn Zaefferer
1096f19f37
Dialog: Keep track of instances to focus when elements outside the dialog get focus. Works with inheritance. Adds tests for both. Fixes #9241 - Dialog: UI dialog inheritance causes undefined property '_focusTabbable' in IE9
2013-11-20 16:04:13 +01:00
Jörn Zaefferer
4f80bc6ecd
Selectmenu: Fix code style issue
2013-11-16 12:30:46 +01:00
Jörn Zaefferer
43772f3e5b
Merge branch 'master' into selectmenu
2013-11-16 12:25:21 +01:00
Jörn Zaefferer
9fd0e86820
Dialog: Update code style, adding whitespace around string arguments and array indices
2013-11-15 16:48:31 +01:00
Jörn Zaefferer
0e5a2e126a
Dialog: Restore focus to the previously focused element when window regains focus. Fixes #9101 - Dialog: Track last focused element instead of always focusing the first tabbable element
2013-11-15 08:16:24 +01:00
Felix Nagel
51b0429713
Selectmenu: simplify and fix document click event
2013-11-13 19:55:31 +01:00
Felix Nagel
ab2219b6ac
Merge branch 'master' into selectmenu
2013-11-13 19:45:56 +01:00
Jörn Zaefferer
0e192979d0
Fix various coding style issues
2013-11-13 19:20:16 +01:00
Scott González
9910e938aa
Menu: Simplify styling. Remove rounded corners, reduce spacing.
2013-11-13 18:41:47 +01:00
Scott González
874865842b
Tabs: Don't decode URLs if they're not UTF-8. Fixes #9518 - Tabs: URLs encoded in anything other than UTF-8 will throw an error.
2013-11-13 12:29:29 -05:00
Imants Horsts
629c632a11
Datepicker: Corrected values for Latvian locale. Fixes #9656 - Datepicker: Incorrect values in Latvian localization.
2013-11-13 07:09:10 -05:00
Kris Borchers
601ad962e0
Sortable: Adjust itemWithLeastDistance algorithm in _contactContainers to properly handle dragging items to the beginning and ends of lists. Fixes #9314 - Sortable: Items cannot be dragged directly into bottom position. Fixes #9381 - Sortable: Connected list placeholders have an inaccurate initial position
2013-11-01 15:17:05 -05:00
Felix Nagel
a6c5f58d82
Selectmenu: follow-up to close menu on other element mousedown not on click
2013-10-30 21:36:03 +01:00
Felix Nagel
11186cc10a
Selectmenu: make sure ui-state-focus class is set on button after initial focus
2013-10-29 21:49:17 +01:00
Felix Nagel
027d8d4cab
Selectmenu: close menu on other element mousedown not on click
2013-10-29 20:54:16 +01:00
Felix Nagel
f3e4b24485
Selectmenu: improve disabled item handling
2013-10-29 19:52:54 +01:00
Andrei Picus
ffab89e9be
Droppable: update ddmanager when scope changes through setOption. Fixed #9287 - droppable: Scope option cannot be changed after initialization.
2013-10-29 13:58:15 -04:00
Fabrício Matté
8b64322e98
Button: Remove obsolete mouse click coordinates checking. Fixed #7665 - Button: Radio button & checkboxes ignore mouseclicks for minor mouse movements.
2013-10-29 12:51:17 -04:00
Monika Piotrowicz
f16d0c7e26
Accordion: moving aria-expanded from active tabpanel to active tab. Fixed #9407 - Accordion: aria-expanded attribute on wrong element
2013-10-28 10:32:25 -04:00
Scott González
9e6095a646
Core: Move variables for .uniqueId()/.removeUniqueId() into their implementations.
2013-10-24 09:19:42 -04:00
Scott González
8a9fb52822
Datepicker: Prefix variables with component name.
2013-10-24 09:19:42 -04:00
Scott González
46b8915eb0
Position: Wrap everything in an IIFE to avoid name collisions when the build strips the main closure.
2013-10-24 09:19:42 -04:00
Scott González
5801a7ef65
Spinner: Prefix variables with component name.
2013-10-24 09:19:42 -04:00
Scott González
47db52b9c9
Widget: Prefix variables with component name.
2013-10-24 09:19:42 -04:00
Scott González
f64c953497
Tooltip: Use .uniqueId() and move aria-describedby helper methods into the widget prototype.
2013-10-24 09:19:42 -04:00
Scott González
ecd4f95a50
Tabs: Use .uniqueId() for panels and moved isLocal() into the widget prototype.
2013-10-24 09:19:42 -04:00
Scott González
604e0949e3
Sortable: Moved helper methods into the widget prototype.
2013-10-24 09:19:42 -04:00
Scott González
b7e3e4636f
Resizable: Moved helper methods into the widget prototype.
2013-10-24 09:19:42 -04:00
Scott González
8dbda00896
Slider: Move numPages into the widget prototype.
2013-10-24 09:19:41 -04:00
Scott González
3317ec8990
Blind effect: Moved regexes into effect definition.
2013-10-24 09:19:41 -04:00
Scott González
d0002569d3
Droppable: Moved isOverAxis() into $.ui.intersect().
2013-10-24 09:19:41 -04:00
Scott González
d6f85644d4
Dialog: Move option category hashes into the widget prototype.
2013-10-24 09:19:41 -04:00
Scott González
da185a6c15
Accordion: Use .uniqueId() and move animation properties into the widget prototype.
2013-10-24 09:19:41 -04:00
Felix Nagel
2c7e3389bc
Selectmenu: remove widthMenu option and rename widthButton option to width
2013-10-24 00:11:10 +02:00
Felix Nagel
80d2c1180a
Selectmenu: lint fix
2013-10-21 21:18:33 +02:00
Felix Nagel
67e7f18d08
Selectmenu: add ui-state-active class to active list item
2013-10-21 20:39:15 +02:00
Felix Nagel
fab6b8883e
Merge branch 'master' into selectmenu
2013-10-21 20:33:49 +02:00
Mike Sherov
4bd1a9c5ba
Draggable: Make sure positional constraints are never applied to ui.originalPosition
2013-10-21 11:20:03 -04:00
Jörn Zaefferer
619261f079
Datepicker: Finnish date format doesn't have padding for day and month. Fixes #9609 - Datepicker: Correct the Finnish date format
2013-10-21 14:24:10 +02:00
Mike Sherov
94f8c4d5e9
Draggable: apply axis options to position instead of style. Fixes #7251 - Draggable: constrained axis option returns incorrect position.
2013-10-20 19:46:05 -04:00
Kris Borchers
52307ebadb
Menu: More precise removal of ui-state-active class for easier CSS overrides. Fixes #9532 - Need a way in Menu to keep ui-state-active class on selected item
2013-10-18 22:14:49 -05:00
Kris Borchers
14065dc23b
Resizable: Store size based on calculated helper size to prevent 1 pixel shifts. Fixes #9547 - Resizable: off-by-one pixel dimensions with helper and grid
2013-10-18 22:12:46 -05:00
Jörn Zaefferer
7b9c810b9a
Autocomplete: Append liveRegion to body to support detached init. Fixes #9590 - Dynamically adding input field breaks auto-complete's accessibility for screen readers
2013-10-19 00:27:51 +02:00
Andrei Picus
06c4387bc9
Sortable: Fix typo and break lines in comment.
2013-10-18 17:30:32 +02:00
Jyoti Deka
93a2dcde52
Slider: Remove unnecessary 3rd argument in _slide method when calling this.values()
2013-10-18 17:24:01 +02:00
Jörn Zaefferer
5ee3a2a7fd
Revert "Slider: Remove unnecessary 3rd argument in _slide method when calling this.values()"
...
This reverts commit b715e1d3cc
.
Reverting to fix author email address to avoid CLA issues in the future.
2013-10-18 17:21:23 +02:00
Jyoti Deka
b715e1d3cc
Slider: Remove unnecessary 3rd argument in _slide method when calling this.values()
2013-10-18 17:18:18 +02:00
Jyoti Deka
ecde7cd41a
Widget: option-method should work as getter only when argument length is 1. Fixes #9601 - Widget: calling _setOption with undefined as 3rd argument makes it a getter
2013-10-16 22:22:28 +02:00
Felix Nagel
7af3dab075
Selectmenu: Remove links in menu items
2013-10-10 01:01:41 +02:00
Felix Nagel
e26e0df3af
Merge branch 'master' into selectmenu
2013-10-10 00:08:49 +02:00
Kris Borchers
31e705ab32
Menu: Add items option for better definition of menu items in non parent-child structures
2013-10-05 21:52:31 -05:00
Kris Borchers
e08791d2c1
Autocomplete: Don't add anchors to items in generated menu
2013-10-05 21:52:31 -05:00
Kris Borchers
3a61627a50
Menu: Remove the requirement to use anchors in menu items
2013-10-05 21:52:30 -05:00
Scott González
e14f75ed48
Tabs: Keep reference to existing tablist during refresh. Fixes #9584 - Tabs: Refresh issue when tabs are moved to bottom.
2013-10-04 10:10:30 -04:00
Scott González
ed09ee5b75
Dialog: Added note explaining that _on() is safe to use for shared handlers because of stacking.
2013-10-03 12:09:50 -04:00
Stephane Deschamps
b67d1037a8
Day TH's: scope=col. Closes gh-1074
...
A TH must feature a way to know which span of TD's it applies to, and in simple tables such as date tables, this can be achieved through the use of the scope attribute.
2013-10-02 17:28:12 +02:00
Jörn Zaefferer
e263ebda99
Dialog: Switch back to shuffling z-index, but only look at .ui-front siblings.
...
Fixes #9166 - Dialog: moveToTop implementation resets flash/video/iframe/scroll
Fixes #9364 - Dialog: Click of element with tooltip scrolls the dialog to the top
2013-10-02 17:02:28 +02:00
TJ VanToll
2dfe85d3e2
Dialog: Safe activeElement access.
...
Fixed #9420 - Dialog: Close causes blur of window in IE9
Fixed #8443 - Dialog: "unspecified error" when using ie9 and iframe
2013-10-01 09:22:07 +03:00
Felix Nagel
f2d06bf063
Selectmenu: add widthMenu and widthButton options
2013-09-29 15:33:14 +02:00
TJ VanToll
e6360ab846
Spinner: Only format the value when there is one. Fixes #9573 - Spinner: forces a field validation in Firefox before field loses focus or form is submitted
2013-09-27 14:23:07 -04:00
Felix Nagel
b1532ed4ae
Selectmenu: Click on button text does not open menu in Webkit browsers
2013-09-26 01:10:16 +02:00
Felix Nagel
b80681c74e
Selectmenu: remove unneeded variable usage
2013-09-25 22:30:13 +02:00
Felix Nagel
12dba998f1
Selectmenu: do not follow anchor link when item is clicked
2013-09-25 22:27:03 +02:00
Kris Borchers
485e0a0612
Menu: Only focus menu after click if focus is on an element within menu. Fixes #9044 - Menu: Autofocus issue with dialog opened from menu widget
2013-09-17 13:03:18 -05:00
Scott González
f416a66f59
Selectmenu: Code review.
2013-09-16 14:45:48 -04:00
Scott González
134fcafdda
Merge branch 'master' into selectmenu
2013-09-16 11:58:05 -04:00
Scott González
d13df39e39
Widget: Only remove hover and focus classes when disabling, not enabling. Fixes #9558 - Widget: .enable() while already enabled kills ui-state-focus and ui-state-hover.
2013-09-16 11:57:35 -04:00
Jörn Zaefferer
1552fc8a05
Spinner: Add isValid method. Fixes #9542 - Spinner: Add isValid() method
2013-09-13 00:16:31 +02:00
Jörn Zaefferer
6e799c39d3
Widget Bridge: Make the _init method optional. Add tests for both states. Fixes #9543 - Widget bridge: Make _init() optional.
2013-09-11 22:26:34 +02:00
Felix Nagel
bdfe7196a2
Selectmenu: lint fix
2013-08-31 11:50:53 +02:00
Felix Nagel
cf6dbd8b6b
Merge branch 'master' into selectmenu
2013-08-31 03:12:22 +02:00
Felix Nagel
67f04e4e42
Selectmenu: update button text when selected option is added
2013-08-31 03:09:57 +02:00
TJ VanToll
eae2c4b358
Draggable: Safe activeElement access from iFrames for IE9, prevent window focus changes in IE9+. Fixed #9520 - Draggable: Browser window drops behind other windows in IE9/10
2013-08-28 11:35:21 -04:00
Scott González
e628d0e4ba
Dialog: Capitalize default value for closeText option. Fixes #9500 - Dialog: Capitalize 'close' for closeText option.
2013-08-15 16:56:49 -04:00
Mike Sherov
263d078944
Draggable: Ignore scroll offsets for abspos draggables. Fixes #9315 - Draggable: jumps down with offset of scrollbar
2013-08-12 19:32:01 -04:00
Kris Borchers
5a24ee0485
Selectmenu: Override menu's _closeOnDocumentClick function to prevent collapseAll and manually fix focus state on open
2013-08-11 19:17:34 -05:00