Commit Graph

52 Commits

Author SHA1 Message Date
Scott González
f2ca8f92f0 Menu: Convert tests to new infrastructure
Ref #10119
Ref gh-1528
2015-04-09 09:26:26 -04:00
Jörn Zaefferer
c770605db0 Menu: Ignore bubbled mouseenter events on parent items
Test uses QUnit 2.x API - inconsistent with the other tests, but also
a good reference.

Fixes #11641
Closes gh-1535
2015-04-08 16:34:26 +02:00
Alexander Schmitz
144826d175 Menu: Use new has/lacksClasses assertions for all class checks 2015-03-11 16:05:40 -04:00
Jörn Zaefferer
666f051c3a Tests: Reduce timeouts to optimize testsuite runtime 2015-03-04 23:04:07 +01:00
Jörn Zaefferer
2aabd427eb Tests: Fix style issues with missing or multiple line breaks
As pointed out by jscs, after a esformatter run. The latter doesn't
address these, so fixing them manually.
2015-01-24 17:10:20 +01:00
Jörn Zaefferer
0bbd156918 Menu: Use ui-state-active consistently
So far we were using ui-state-active on active parent items,
ui-state-focus on active child items. The theme update highlighted the
visual inconsistency. With this change, only ui-state-active is used.

Fixes #10692
2015-01-21 18:07:43 +01:00
TJ VanToll
de2ef2a585 Menu: Wrap menu items in a <div>
This avoids styling issues where ui-state-focus rules apply to submenus.

Fixes #10162
Closes gh-1342
2014-10-25 10:10:30 -07:00
Trisha Crowley
c48b18b388 Menu: Typeahead now accounts for leading whitespace
Fixes #10649
Closes gh-1356
2014-10-07 07:45:01 -04:00
TJ VanToll
6b6b49f678 Menu: Maintain focus on already selected item during typeahead
Fixes #10644
Closes gh-1354
2014-10-03 09:30:49 -04:00
Simen Bekkhus
e3e5a9ffa6 Menu: Filter out non-items when typing
Fixes #10571
Closes gh-1329
2014-09-29 14:36:46 -04:00
Jörn Zaefferer
fe7c300374 Menu: Remove click binding that was supposed to prevent default on anchor clicks on a disabled menu. Not relevant anymore since we removed the anchors. Partial fix for #8802 - Dev: Track down uses of .bind() inside widgets 2013-12-03 21:54:08 +01:00
Scott González
6a74bf9929 Menu tests: Force line height to ensure we know how many items will be scrolled. 2013-11-20 11:14:27 -05:00
Jörn Zaefferer
3945a8f074 Menu: Update unit test that regressed from style changes (see 9910e938aa) 2013-11-15 12:51:10 +01:00
Kris Borchers
31e705ab32 Menu: Add items option for better definition of menu items in non parent-child structures 2013-10-05 21:52:31 -05:00
Kris Borchers
3a61627a50 Menu: Remove the requirement to use anchors in menu items 2013-10-05 21:52:30 -05:00
TJ VanToll
afdf898659 Menu tests: jshint cleanup of unused argument 2013-08-03 17:52:11 -04:00
TJ VanToll
484e382259 Menu: Only set the mouseHandled flag if the event is going to bubble. Fixes #9469: on( "menuselect" )
not firing every time.
2013-08-03 17:43:30 -04:00
Kris Borchers
86eaa30994 Menu tests: Whitespace and general cleanup 2013-07-15 21:54:44 -05:00
Kris Borchers
a74ac174cc Menu tests: Check default is prevented on any click on disabled menus 2013-07-14 21:52:35 -05:00
Scott González
694987f2f7 Menu tests: Better handling of async focus in IE. 2012-12-11 09:44:39 -05:00
Mike Sherov
e1230997aa Build: Enable "unused" option in jshint - Remove unused variables from codebase. - Closes gh-788
Squashed commit of the following:

commit 7f19f92c64
Author: Mike Sherov <mike.sherov@gmail.com>
Date:   Tue Oct 23 10:34:28 2012 -0400

    put back in fake args for signatures that we want to keep

commit 257505a9e6
Author: Mike Sherov <mike.sherov@gmail.com>
Date:   Tue Oct 23 08:10:20 2012 -0400

    changes per @scott_gonzalez

commit 12725480cb
Author: Mike Sherov <mike.sherov@gmail.com>
Date:   Mon Oct 22 22:54:05 2012 -0400

    clean up unused vars in ui directory

commit 563595e7ae
Author: Mike Sherov <mike.sherov@gmail.com>
Date:   Mon Oct 22 22:37:42 2012 -0400

    clean up unused vars in grunt and tests
2012-10-23 09:37:46 -05:00
Scott González
e162fddd95 Menu: Don't move focus from the active item on click. Fixes #8552 - selected value overwritten/not correctly set. 2012-09-05 16:07:36 -04:00
Scott González
f7b32d9a8f Menu tests: Removed test for key handling when the element doens't have focus (illogical test). 2012-07-17 14:08:16 -04:00
Scott González
9b6c1c5cdb Menu tests: Cleanup. 2012-06-27 09:49:56 -04:00
Scott González
156f07b48a Menu tests: Saner output for log helper. 2012-06-18 13:38:16 -04:00
Scott González
f92f8bb56b Menu tests: Cleanup. 2012-06-18 13:26:46 -04:00
kborchers
fe7ca1f1c3 Menu: Better handling of divider elements and menu items without anchors. 2012-05-24 23:45:12 -05:00
kborchers
474912313a Menu Tests: Increase timeout on page up/down test 2012-05-23 07:24:49 -05:00
kborchers
c275ebe09b Menu Tests: Remove unused unit tests and add new unit tests to improve coverage. 2012-05-22 23:52:59 -05:00
Jörn Zaefferer
9dcd0e0eb8 Menu: Handle SPACE same as ENTER, select items or opening submenus 2012-05-22 16:01:40 +02:00
kborchers
33df9b788d Menu tests: Update tests to test mouseenter instead of mouseover 2012-04-19 23:50:52 -05:00
kborchers
c16bd7c510 Menu tests: Don't pollute the global namespace with helpers. 2012-04-19 11:19:52 -05:00
kborchers
58a120bb4b Merge branch 'menuaria' into master 2012-04-19 09:24:08 -05:00
Scott González
aa187f57d1 Tests: Lint 2012-04-19 09:39:21 -04:00
kborchers
890a45a22c Menu: Add unit tests for testing disabled items 2012-04-18 21:29:39 -05:00
Jörn Zaefferer
72023dd045 Update to QUnit 1.3. Replace usage of same with deepEqual and equals with equal. 2012-02-29 18:36:40 +01:00
kborchers
e2ca906141 Menu: Clean up tests to remove nested setTimeout calls 2012-02-17 16:06:14 -06:00
Scott González
2fd2ab23c9 Menu tests: Handle async focus events in IE. 2012-02-09 16:19:50 -05:00
kborchers
3ef4db2670 Menu: Focus the menu before performing keyboard unit tests. 2012-02-06 15:01:40 -06:00
kborchers
4f15e66f53 Menu: Added unit tests for the enable, disable and refresh methods as well as the disabled option. Cleaned up some variable names in unit tests. 2012-01-22 11:26:41 -06:00
kborchers
c88add2269 Menu: Fix close delay and increase the default delay 2011-12-20 11:49:48 -06:00
kborchers
a8d0e4c804 Menu: Fix focus handling to keep focus on the menu and prevent jumping around within the menu on mousedown 2011-12-15 12:43:28 -06:00
Corey Frang
34a0479d1c Menu: Refactoring the collapseAll to deal with some issues selecting - Updating unit tests. Thanks @kborchers 2011-09-22 15:30:46 -05:00
kborchers
9e617bbad1 Menu: Add support for structures other than UL/LI plus visual and unit tests 2011-09-14 10:29:36 -05:00
Jörn Zaefferer
ae0c4e44ff Merge remote branch 'kborchers/menu_autoCollapse' 2011-09-12 23:54:19 +02:00
kborchers
94317d7aa4 Menu: Added autoCollapse as the default and added a unit test 2011-09-12 08:43:49 -05:00
Scott González
6fb68568be Tests: Cleanup. 2011-08-03 21:43:52 -04:00
Scott González
cff6b56fd4 Menu tests: Cleanup. 2011-08-03 21:15:38 -04:00
Scott González
3c65bc3923 Menu tests: Removed console.log() call. 2011-07-26 14:38:18 -04:00
kborchers
23340f1162 Menu: Added Home moves to first item and End moves to last item in currently active menu or submenu. Also fixed PageUp and PageDown so that they don't wrap back around to other end of menu. Also fixed scrolling to use activeMenu rather than element to all. Also added unit tests for keyboard nav 2011-07-25 09:13:13 -05:00