Commit Graph

112 Commits

Author SHA1 Message Date
Michał Gołębiowski-Owczarek
70dae67b73
Build: Migrate from JSHint & JSCS to ESLint
Fixes #15393
Closes gh-1958
2021-06-07 00:58:12 +02:00
Michał Gołębiowski-Owczarek
e7a10c70ae
Tests: Ensure no timers are running at the end of each test (#1920)
This helps fix issues that make tooltip tests sometimes fail when run against
jQuery 3.2 or newer due to timing differences.

Details:
* Add the `moduleAfterEach` function ensuring no timers are running.
* Attach this function via `common.testWidget`.
* Attach this function to most test suites.
* Add a tooltip test helper cleaning up leftover timers.
* Rename legacy `setup`/`teardown` hooks to `beforeEach`/`afterEach`.

Closes gh-1920
2020-05-16 09:16:24 +02:00
Scott González
92451b44c1 Tooltip: Allow tracking tooltips to be off by a fraciton of a pixel
Closes gh-1718
2016-07-07 09:16:52 -04:00
Scott González
010f5f9d13 Tooltip: Fix re-enabling of delegated tooltips
Fixes #14950
Closes gh-1699
2016-04-21 10:59:27 -04:00
Amanpreet Singh
92f122d5b1 Tooltip: Shift to use no globals 2016-04-14 00:14:57 +05:30
Alexander Schmitz
a0892eca70 Tooltip: Style updates
Ref #14246
2015-09-11 08:29:07 -04:00
Alexander Schmitz
b7278a3968 Tooltip: Style updates
Ref #14246
Ref gh-1588
2015-08-21 08:06:22 -04:00
Alexander Schmitz
eeb962027e Tooltip: Move tooltip into widgets directory
Ref #13885
2015-08-08 00:29:39 -04:00
Alexander Schmitz
24f1ce9ea0 Tooltip: Remove core event/alias and deprecated module dependencies 2015-05-20 14:27:57 -04:00
Jiabao Wu
2cef124bf2 Tooltip: Remove name attribute from elements in the live region
Fixes #11272
Closes gh-1544
2015-04-22 10:20:11 -04:00
Scott González
6231b161b9 Tests: Fix AMD loading in IE8
It appears that we must load require.js via a standard script tag in order
for it to work properly in IE8.
2015-04-17 12:13:38 -04:00
Scott González
bde431bb44 Tests: Rename files
Ref gh-1528
2015-04-09 09:27:00 -04:00
Scott González
a2da340e0d Tooltip: Convert tests to new infrastructure
Ref #10119
Ref gh-1528
2015-04-09 09:26:27 -04:00
Scott González
500f6b4992 Tests: Switch to the new qunit-composite module
This module was created from our existing implementation.

Closes gh-1532
2015-04-07 09:03:36 -04:00
Scott González
899d90709a Tests: Handle jQuery git returning null for empty attributes
jQuery now returns `null` for empty attributes instead of `undefined`.

Closes gh-1516
2015-03-25 15:55:53 -04:00
Alexander Schmitz
7b01dc3d2c Tooltip: Use new has/lacksClasses assertions for all class checks 2015-03-11 16:05:41 -04:00
Alexander Schmitz
9d71547394 Tooltip: Add classes option
Ref #7053
Ref gh-1411
2015-03-11 16:05:33 -04:00
Alexander Schmitz
c192d4086d Widget: Add classes option and _add/_remove/_toggleClass methods
Fixes #7053
Closes gh-1411
2015-03-11 16:00:04 -04:00
Marco Ziech
c4e367bb31 Tooltip: Register event handlers before content is loaded
Fixes #8740
Closes gh-1053
Closes gh-1456
2015-02-25 15:35:49 -05:00
Jörn Zaefferer
9d0f44fd7b All: Drop support for jQuery 1.6.x
Affects core, effects, position and widget. Only position has unit tests
that fail with jQuery 1.6 without the workaround.

Drops the 1.6.x copies jQuery of jQuery and removes them from the select
in the testsuites.

Fixes #10723
Closes gh-1422
2015-01-13 15:05:54 +01:00
Daniel Owens
42099e4461 Tooltip: Accept HTMLElement and jQuery objects for the content option
Fixes #9278
Closes #983
Closes #1421
2015-01-12 18:37:57 +01:00
Scott González
8825d93dc8 Tooltip: Properly track hiding and closing for delegated tooltips
Fixes #10602
Closes gh-1353
2014-10-09 10:40:58 -04:00
Mike Sherov
aa425ab95d Build: Pull in jquery.simulate.js from Bower
Fixes #10563
2014-08-22 17:01:50 -04:00
Scott González
32bef7ad4e Tooltip: Treat the tooltip as closing until it's fully removed
This ensures that we don't trigger the close event twice if the tooltip is
destroyed during the hide animation.

Closes gh-1306
2014-08-06 15:01:58 -04:00
Scott González
c017628e11 Tests: Fix composite tests 2014-08-01 12:25:14 -04:00
Scott González
6df127a0b5 Build: Reorganize external directory
Put each external library into its own directory.
Move jquery.js to external.

Ref gh-1266
2014-06-24 22:45:32 -04:00
Jörn Zaefferer
a40647f0e5 All: Rename jquery.js to exclude version in filename 2014-03-05 10:19:11 +01:00
Jörn Zaefferer
822f3cd9d0 Tests: Update to sane QUnit markup 2014-02-20 17:05:02 +01:00
Rafael Xavier de Souza
21154cfa2e All: Rename all files, removing the "jquery.ui." prefix;
- By executing https://gist.github.com/jzaefferer/893fcf70b7eebc1dc271;

Fixes #9464
Closes gh-1029
2014-01-24 18:22:49 -02:00
Michael Wiencek
0dc84db853 Tooltip: Preserve the title after disabling twice
Fixes #9719
Closes gh-1154
2014-01-09 20:38:08 +01:00
Jörn Zaefferer
5cf4456aaf Tooltip: Lowercase test html for IE7/8 compat 2014-01-06 16:33:33 +01:00
Daniel DeGroff
af85dfcafb Tooltip: On close and destroy only set title if empty or undefined
Ticket #8925 states that changes to the title attribute while the
tooltip is open are lost on tooltip close.

In the close and destroy functions, the title attribute is always
written if a value was stored in the element on open. It is possible
the attribute has changed and restoring the initial value may overwrite
the current value.

If the value is empty or undefined as set in open, do not set the title
attribute.

This fix has the limitation that if the user removed the title
attribute or set the value to an empty string the original title value
would be restored on close and destroy.

Fixes #8925
2014-01-06 16:10:02 +01:00
Dylan Barrell
b9e438d07c Tooltip: Improve accessibility by adding content to an aria-live div
Fixes #9610
Closes gh-1118
2013-12-19 10:36:30 -05:00
Bruno M. Custódio
0d5eaab9bb Updating jQuery to 1.10.2.
Adding jQuery 1.10.0, 1.10.1, 1.10.2, 2.0.0, 2.0.1, 2.0.2 and 2.0.3 to the
tests directory.
2013-07-05 08:42:37 -04:00
Scott González
44d07173db Widget: Stop setting ui-state-disabled and aria by default on setting disabled option.
Fixes #5973 - Resizable: disabled should not have the ui-state-disabled class or aria attribute aria-disabled
Fixes #5974 - Draggable: disabled should not have the ui-state-disabled class or aria attribute aria-disabled
Fixes #6039 - Droppable: disabled should not have ui-state-disabled

This reverts commit 23771d38ba.
2013-03-14 19:08:21 -04:00
Scott González
23771d38ba Revert "Widget: Stop setting ui-state-disabled and aria by default on setting disabled option." This needs to wait for a major release.
This reverts commit 4d67f4f349.
2013-03-14 15:07:06 -04:00
Mike Sherov
4d67f4f349 Widget: Stop setting ui-state-disabled and aria by default on setting disabled option.
Fixes #5973 - Resizable: disabled should not have the ui-state-disabled class or aria attribute aria-disabled
Fixes #5974 - Draggable: disabled should not have the ui-state-disabled class or aria attribute aria-disabled
Fixes #6039 - Droppable : disabled should not have ui-state-disabled
2013-03-11 22:08:21 -04:00
Bruno M. Custódio
b440979ba6 Updating 'jQuery' to 1.9.1. 2013-02-05 13:47:59 +00:00
Kris Borchers
34409e7ddd Updating to jQuery 1.9.0 2013-01-17 00:28:41 -06:00
Scott González
f2854408cc Tooltip: Escape the title attribute so that it's treated as text and not HTML. Fixes #8861 - Tooltip: XSS vulnerability in default content. 2012-11-27 11:21:33 -05:00
Scott González
fb6119e182 Upgrade jQuery to 1.8.3. 2012-11-14 15:22:01 -05:00
Scott González
1b503a237e Tooltip: Handle synthetic focusin events. Fixes #8740 - Tooltip: Does not hide consistently with dynamically loaded content. 2012-11-14 14:14:45 -05:00
Scott González
498aadf644 Tooltip: Ignore disabled checks when closing. Fixes #8758 - Tooltip: Tooltip is shown, but not hidden if element has class=ui-state-disabled. 2012-11-09 13:07:53 -05:00
Jörn Zaefferer
6874f19061 Tooltip: Fix default for position option, follow-up to 1d9eab1. 2012-11-05 19:07:03 +01:00
Jörn Zaefferer
98173a3d0e Tooltip: Check type on event directly, preventing TypeError when programmatically moving focus to track-toolipped-input. Fixes #8747 - Tooltip: Using the track option within dialogs creates JS errors 2012-11-05 18:59:52 +01:00
Scott González
d074efe528 Tooltip: Use attributes, not properties, when checking for parent tooltips. Fixes #8742 - Tooltip shows incorrect message in chrome if there is input with name='title' in a form. 2012-10-28 20:28:55 -04:00
Jörn Zaefferer
ba752cf7ed Tooltip: Run _disable when disabled option is set on create. Fixes #8712 - Tooltip: Disabled tooltips on initialization. 2012-10-24 10:02:21 -04:00
Scott González
97b4813f30 Tooltip tests: Fixed new default value for position option. 2012-10-23 15:07:19 -04:00
Mike Sherov
e1230997aa Build: Enable "unused" option in jshint - Remove unused variables from codebase. - Closes gh-788
Squashed commit of the following:

commit 7f19f92c64
Author: Mike Sherov <mike.sherov@gmail.com>
Date:   Tue Oct 23 10:34:28 2012 -0400

    put back in fake args for signatures that we want to keep

commit 257505a9e6
Author: Mike Sherov <mike.sherov@gmail.com>
Date:   Tue Oct 23 08:10:20 2012 -0400

    changes per @scott_gonzalez

commit 12725480cb
Author: Mike Sherov <mike.sherov@gmail.com>
Date:   Mon Oct 22 22:54:05 2012 -0400

    clean up unused vars in ui directory

commit 563595e7ae
Author: Mike Sherov <mike.sherov@gmail.com>
Date:   Mon Oct 22 22:37:42 2012 -0400

    clean up unused vars in grunt and tests
2012-10-23 09:37:46 -05:00
Jörn Zaefferer
78f781fccd Tooltip: Unit test for nested tooltips 2012-10-21 13:25:36 -04:00