Commit Graph

8 Commits

Author SHA1 Message Date
Michał Gołębiowski-Owczarek
8cc5bae1ca
Checkboxradio: Don't re-evaluate text labels as HTML
If you generate a Checkboxradio from a checkbox/radio with a label that
contains encoded HTML, e.g. `<em>test</em>` this will work fine
at first. If, however a refresh is triggered on that instance (explicitly or
e.g. by turning it into a `Controlgroup`), the previously escaped HTML will
now be evaluated.

If the label was created based on some user input, this could lead to
unexpected code execution even though the initial output was escaped.

Fixes gh-2101
Closes gh-2102
2022-07-14 20:52:02 +02:00
Michał Gołębiowski-Owczarek
70dae67b73
Build: Migrate from JSHint & JSCS to ESLint
Fixes #15393
Closes gh-1958
2021-06-07 00:58:12 +02:00
Michał Gołębiowski-Owczarek
e7a10c70ae
Tests: Ensure no timers are running at the end of each test (#1920)
This helps fix issues that make tooltip tests sometimes fail when run against
jQuery 3.2 or newer due to timing differences.

Details:
* Add the `moduleAfterEach` function ensuring no timers are running.
* Attach this function via `common.testWidget`.
* Attach this function to most test suites.
* Add a tooltip test helper cleaning up leftover timers.
* Rename legacy `setup`/`teardown` hooks to `beforeEach`/`afterEach`.

Closes gh-1920
2020-05-16 09:16:24 +02:00
Amanpreet Singh
e089b1dd49 Checkboxradio: Shift to use no globals 2016-04-14 00:06:12 +05:30
Scott González
d4b0699578 Checkboxradio: Test cleanup 2015-10-27 16:05:52 -04:00
Alexander Schmitz
641c5ed17a Checkboxradio: Style updates 2015-10-08 14:02:56 -04:00
Alexander Schmitz
16abde399d Spinner: Updates for new button widget and classes option 2015-10-08 14:02:35 -04:00
Alexander Schmitz
25d0c85718 Checkboxradio: Initial commit of new widget 2015-10-07 10:57:59 -04:00