Jörn Zaefferer
2a2a2c017c
Dialog: Prevent dialog form losing focus (or move it back in IE <= 8).
2012-10-24 16:57:13 -04:00
Nate Eagle
3829a37ca1
Dialog: Awesome new stacking and overlay implementation. Fixes the following tickets:
...
Fixes #3534 - Dialog: Modal dialog disables all input elements on page.
Fixes #4671 - Dialog: Modal Dialog disables vertical scroll bar in Chrome & Safari.
Fixes #4995 - Dialog: Modal Dialog's overlay dissapears in IE when content is tall.
Fixes #5388 - Dialog: Don't change z-index when already at the top.
Fixes #5466 - Dialog: "modal" Dialog Incorrectly Cancels Input Events.
Fixes #5762 - Dialog: Get rid of z-index workaround, document it instead.
Fixes #6267 - Dialog: checkboxes that inherit a z-index < jqueryui.dialog z-index don't work.
Fixes #7051 - Dialog: modal prevents tab key from moving focus off slider handle.
Fixes #7107 - Dialog: Modal dialog event loss with high zindex child elements (FF 3.6).
Fixes #7120 - Dialog: Modal operation interrupts drag drop marker functionality on gmaps.
Fixes #8172 - Dialog: Change event cancelled when opening modal dialog from another modal dialog.
Fixes #8583 - Dialog: Mouse event wrongly stopped.
Fixes #8722 - Dialog: Remove stack option.
Fixes #8729 - Dialog: Remove zIndex option.
2012-10-24 16:56:19 -04:00
Scott González
11effcbd35
Dialog: Don't use deprecated offset option for .position(). Fixes #8675 - Dialog: Position with pixels in array doesn't work with back compat disabled.
2012-10-23 14:50:02 -04:00
Mike Sherov
e1230997aa
Build: Enable "unused" option in jshint - Remove unused variables from codebase. - Closes gh-788
...
Squashed commit of the following:
commit 7f19f92c64257505a9e612725480cb563595e7ae
2012-10-23 09:37:46 -05:00
David Petersen
35dc9307fc
Dialog: Use _hide() to make sure close event gets triggered. Fixes #8684 - jQuery dialog with hide options does not trigger close event.
2012-10-17 20:28:27 -04:00
Dale Kocian
1a69667887
Dialog: Added mousedown event handler on dialog title to focus. Fixed #8063 - Dialog: Escape closes incorrect dialog.
2012-10-16 09:17:21 -04:00
Scott González
a3f1a34d3b
Remove use of $.browser; add $.ui.ie and $.ui.ie6 temporarily.
2012-10-10 11:45:48 -04:00
Richard D. Worth
1e6e4ce4dc
Dialog: add required closing tag </button>. Fixes #8639 - jQuery 1.9.0 dialog on a XHTML page is broken if buttons are defined
2012-10-09 08:41:18 -04:00
Scott González
4ab4684cfc
Dialog: Don't try to place the dialog next to itself on destroy. Fixes #8613 - Destroying a dialog removes the original element from the DOM.
2012-10-01 15:34:44 -04:00
Scott González
149567e476
Updated docs URLS.
2012-09-26 18:06:20 -05:00
Scott González
6abb10766c
Dialog: Only bind focus-trapping event once. Fixes #8551 - After repeated opening and closing of a modal dialog, focus navigation using tab becomes slow.
2012-09-04 17:00:26 -04:00
Scott González
485ca7192a
Simplify licensing.
2012-08-09 15:09:50 -04:00
Lee Rowlands
5a952856a0
Dialog: Prevent tabbing out of modal dialog. Partial fix for #7862 - Dialog: modal accessibility.
2012-07-05 21:23:39 -04:00
Scott González
a4534bb993
Update copyright to jQuery Foundation.
2012-07-04 09:08:08 -04:00
Scott González
ff39bed57a
Widget: Added _off() for removing event handlers. Fixes #7795 - Widget: _on and _off.
2012-06-14 12:33:16 -04:00
kborchers
240b22b143
Dialog: Use new uniqueId method for generating id's
2012-05-29 23:11:42 -05:00
Scott González
286941ef8d
Dialog: Only create the button pane once and store a reference to it. Fixes #8343 - _createButtons removes all elements with .ui-dialog-buttonpane class.
2012-05-22 08:28:53 -04:00
Scott González
8fcf7ea828
Dialog: Remove uses of self var; use that var.
2012-05-09 20:20:15 -04:00
Scott González
650fe5c5db
Dialog: Removed trailing whitespace.
2012-05-07 09:57:18 -04:00
Jay Merrifield
cab4c467d9
Dialog: Handle escape for all overlays. Fixes #8300 - Dialog: Incorrect behavior for ESCAPE with multiple modal dialogs.
2012-05-07 09:44:26 -04:00
Scott González
cb8474af1d
Remove trailing whitespace.
2012-04-18 21:57:51 -04:00
Scott González
639afa5954
Lint fixes.
2012-04-02 19:12:21 -04:00
Jo Liss
37dcc3e21d
Protect all copyright notices against minification
...
For instance, this is useful for the jquery-ui-rails gem, which does not
use jQuery UI's own minification, but relies on Rails to minify the
files where necessary. Rails in turn uses UglifyJS for JS and YUI for
CSS, both of which respect the /*! ... */ convention.
2012-04-02 15:21:06 +02:00
Scott González
932fe888c0
Updated copyright year.
2012-03-08 10:53:08 -05:00
Alberto Monteiro
a4b7feabd3
Dialog: When destroy is called place the element back in original DOM position. Fixed #4980 - Dialog: Destroy should place element back in original DOM position
2011-12-15 17:52:49 -03:00
James Khoury
ce0afde900
Dialog: Modified the dialog._size() to use outerHeight in calculating the nonContentHeight. Fixed #7692 - dialog: dialog height bug is incorrect when .ui-dialog padding set.
2011-11-28 16:52:10 -05:00
Jörn Zaefferer
66f9e12797
Widget: Remove method argument from _super and _superApply. Was a left-over from first implementation, not necessary anymore.
2011-11-18 17:08:40 +01:00
Scott González
a0856efef3
Widget: Added window and document properties. Fixes #7801 - Widget: Add document and window properties.
2011-10-20 16:57:47 -04:00
Florian Gutmann
42d33f2f86
Dialog: fix small memory leak when having lot's of instances. Fixes #7793 - Small memory leak in ui dialog.
2011-10-14 11:18:48 -04:00
Corey Frang
dfe75e1b55
Dialog: Update to 96e5c24 - keyup apparently doesn't work like I thought it would everywhere, switching back to keydown.
2011-08-20 18:05:39 -05:00
Corey Frang
96e5c241e1
Dialog: Tabbing out of a modal dialog was possible because keypress doesn't fire for tabs everywhere, switched to keyup. Added Unit Test - Caught by @DomenicDenicola - Fixes #3123 - Tabbing stops in modal dialog
2011-08-19 06:03:59 -05:00
Scott González
19a9de7e66
Merge branch 'master' into core-1.6.1
...
Conflicts:
demos/menubar/default.html
tests/unit/autocomplete/autocomplete.html
tests/visual/effects/effects.all.html
ui/jquery.ui.menu.js
ui/jquery.ui.popup.js
2011-07-25 11:53:14 -04:00
Scott González
0dc4a48762
Dialog: Append the dialog to the body early to make sure styles from the classes get applied.
2011-07-12 09:16:22 -04:00
Scott González
da84672db8
.attr() -> .prop()
2011-06-08 17:02:57 -04:00
Scott González
6a5b21fda2
All: Moved version numbers into prototypes. Fixed #7436 - Widget: Store version numbers on instances.
2011-05-28 15:39:55 -04:00
Jay Merrifield
e34dbfeef0
Dialog: Removed the height() tinkering which stops the dialog from shrinking. Fixes #5916 - Dialog: shrinks on drag in IE in standards mode, worse in quirksmode.
2011-05-26 23:30:56 -04:00
David Murdoch
c7eae7b264
Dialog: Make close() a noop if the dialog is already closed. Fixes #7327 - Dialog box size and close animation bugs.
2011-05-26 19:29:11 -04:00
Jörn Zaefferer
1c193085e1
Merge remote branch 'kborchers/bug_3623'
2011-05-18 17:07:02 +02:00
Scott González
a0f16a00b9
Dialog: Reduce old overlay dimensions to 0x0 to avoid sizing issues. Fixes #5637 - Dialog: Dimensions of reused overlay may cause scrollbars.
2011-05-18 09:34:50 -04:00
kborchers
331c4602a9
Dialog: Create modal overlay after dialog is shown and check scrollHeight and offsetHeight in all IE versions. Fixed #4995 - Modal Dialog's overlay dissapears in IE when content is tall
2011-05-12 15:14:58 -05:00
kborchers
29b36bb409
Dialog: Changed IE6 overlay width adjustment to apply to all IE versions. Fixed #3623 - Opening a Modal Dialog shows a horizontal scroll bar
2011-05-12 13:31:15 -05:00
Kato Kazuyoshi
27f943bf36
Dialog: 'NO-BREAK SPACE' (U+00A0) is not 'SPACE' (U+0020).
2011-05-07 16:02:06 +09:00
Adam Baratz
51df02ee4e
Dialog: remove unneeded DOM manipulations. Fixed #7258 - optimize initialization.
2011-05-02 18:03:14 -04:00
Jay Merrifield
f9996682b5
Dialog: Before handling escape key presses, check if the default action has been prevented. Fixes #6966 - Pressing ESC on dialog when 2 dialogs are open closes both dialogs.
2011-03-08 09:42:10 -05:00
Douglas Neiner
15c97e0b76
Dialog: Added a class to dialog wrapper when it is currently displaying buttons, includes unit tests for changes. Fixed #7057 - An extra class is needed on the dialog wrapper to specify when a buttonset is showing
2011-03-03 09:37:16 -05:00
Scott González
3e370a4467
Dialog: Use ._focusable() and ._hoverable().
2011-01-24 21:58:40 -05:00
Scott González
6e0482a9cb
Updated copyright year.
2011-01-17 09:13:18 -05:00
Scott González
e0b52831fc
Updated widgets to use new methods from $.Widget.
2011-01-15 06:34:07 -05:00
Scott González
56c4c6aca9
Change destroy to _destroy and remove calls to $.Widget.prototype.destroy in widgets with simple destroy methods.
2011-01-14 17:11:22 -05:00
Scott González
04667b1518
Dialog: Fixed creation of close button in IE.
...
Thanks dkiselev.
2011-01-11 14:34:17 -05:00
Max Schnur
727d00dec8
Dialog: Modified close button binding to use event.preventDefault() instead of return false. Fixes #6766 - Dialog: Clicks on close button don't bubble.
2010-12-20 09:00:28 -05:00
Scott González
c614889b30
Dialog: Coding standards.
2010-12-17 19:53:22 -05:00
Scott González
ca0ac5a64f
All: Remove workaround for .offset() setter bug from older versions of jQuery.
2010-12-11 15:19:25 -05:00
Scott González
b42125af43
Dialog: Removed handling of deprecated beforeclose option. Fixes #5100 - Dialog: remove deprecated dialog option beforeclose.
2010-12-10 14:31:36 -05:00
Scott González
0e15f573d6
Revert "Dialog: Moved the default value for the position.of option inside the _position() method to avoid a bug in jQuery 1.3.2. Fixes #6030 - ui.dialog with jQuery 1.3.2 causes RangeError."
...
This reverts commit 22671ad4f8
2010-12-10 13:42:29 -05:00
Scott González
22671ad4f8
Dialog: Moved the default value for the position.of option inside the _position() method to avoid a bug in jQuery 1.3.2. Fixes #6030 - ui.dialog with jQuery 1.3.2 causes RangeError.
...
This should be reverted in jQuery UI 1.9.
2010-12-08 12:36:19 -05:00
Scott González
b9e34f726a
Dialog: Don't hide the dialog in _size if it started visible. Fixes #6717 - Dialog: Adding a button makes the dialog disappear in IE6.
2010-12-03 08:31:06 -05:00
jamiejag
8bb412dd4a
Dialog: Ensure dialogs have a z-index when calculating the max z-index. Fixex #5955 - Dialog: Closing UI dialog when z-index is not defined in any .ui-dialog class, causes NaN to be used as Z-index, throwing an error. Fixes #4652 - Dialog: Event loss in subsequent dialog calls (FF3).
2010-11-19 09:02:01 -05:00
Scott González
c2139fc2e6
Dialog: Added some missing semicolons.
2010-11-12 12:57:34 -05:00
Jay Merrifield
dfb3544297
Dialog: Make sure the overlay instance still exists before trying to remove it. Fixes #6645 - Dialog: Missing element not found check in overlay code.
2010-11-12 08:16:41 -05:00
Scott González
302728bd87
Dialog: Fixed logic for mimicking minHeight. Fixes #6150 - Dialog height:auto does not work in IE6.
2010-10-05 16:20:43 -04:00
John Firebaugh
e66cdfcf59
Dialog: Don't change DOM position on open. Fixes #6137 - dialog('open') causes form elements to reset on IE7.
2010-10-04 09:18:46 -04:00
Scott González
c090802cc1
Revert "Dialog: Don't change DOM position on open. Fixes #6137 - dialog('open') causes form elements to reset on IE7."
...
This reverts commit 67b1db14c9
2010-10-04 09:18:21 -04:00
Scott González
67b1db14c9
Dialog: Don't change DOM position on open. Fixes #6137 - dialog('open') causes form elements to reset on IE7.
2010-10-04 09:15:40 -04:00
Scott González
d7670b9407
Dialog: Don't pass props to jQuery when creating buttons.
...
Thanks jitter.
2010-10-01 11:19:24 -04:00
Scott González
cd7f10d480
Dialog: Set the type on buttons. Fixes #6128 - Dialog: Buttons are not type="button".
2010-09-30 10:17:52 -07:00
Scott González
e8e3168a39
Dialog: Batch size-related option settings.
2010-09-27 15:15:20 -04:00
Scott González
98a98a05d1
Dialog: Don't call draggable.destroy if we're not currently draggable. Fixes #6069 - DIALOG windows 1.8.5 draggapble problem.
2010-09-20 09:16:29 -04:00
Scott González
52e543a637
Dialog: If the browser doesn't support minHeight, use height to set the minHeight. Fixes #6027 - Dialog: minHeight isn't properly handled on init in IE6.
2010-09-07 09:33:09 -04:00
Scott González
de02aa34a8
Dialog: Set the _isOpen flag before triggering the open event. Fixes #6012 - Dialog: _isOpen flag should be set before triggering open event.
2010-09-02 08:35:40 -04:00
Scott González
95a34593f9
Dialog: Added additional syntax for creating buttons. Fixes #4344 - Dialog: Enhanced Button Option.
2010-08-31 10:17:53 -04:00
Scott González
79ee6f0d7b
Dialog: When using the title attribute, update the title option. Fixes #5877 - Dialog: when using the title attribute, the title option should be updated.
2010-08-27 18:02:11 -04:00
Scott González
af9864dcc4
Dialog: Don't return true when we don't want to cancel events. Fixes #3523 - Dialog: onclick return value ignored.
2010-08-27 16:49:07 -04:00
Ziling Zhao
c5770c0e84
Dialog: modified so that minWidth is respected. Fixes #5531 - dialog width should be at least minWidth on creation.
2010-07-30 15:14:48 -04:00
Scott González
58ae7ce2fd
Revert "Use pushStack in widget method. Fixes #5732 - make the widget method maintain the stack"
...
This reverts commit ea58cd5ac0
2010-07-30 12:38:18 -04:00
jzaefferer
ea58cd5ac0
Use pushStack in widget method. Fixes #5732 - make the widget method maintain the stack
2010-07-30 14:26:58 +02:00
Scott González
61e0aeac7e
Dialog: Wrap buttons in a div so we can float the div instead of the individual buttons. Fixes #4529 - dialog buttons are accessed in wrong order using tab.
2010-07-29 20:56:28 -04:00
Scott González
70c4857cc5
Revert "Dialog: Don't set specific dimensions on the overlay - let it expand based on 100% dimensions. Fixes #3623 - Opening a Modal Dialog shows a horizontal scroll bar."
...
This reverts commit b548d34e14
2010-07-21 08:01:06 -04:00
Scott González
b548d34e14
Dialog: Don't set specific dimensions on the overlay - let it expand based on 100% dimensions. Fixes #3623 - Opening a Modal Dialog shows a horizontal scroll bar.
2010-07-20 22:05:05 -04:00
Scott González
64d90b4a71
Dialog: Adjusted logic for finding the first tabbable element. Fixes #5767 - On open, the first tabbable element inside the dialog was never being focused in favor of the dialog container.
2010-07-16 16:57:46 -04:00
Scott González
4ad7154bee
Dialog: Fixed whitespace.
2010-07-16 08:55:03 -04:00
Ben Hollis
6de9a5368c
Dialog: allow setting position with ui.position arguments. Fixes #5459 - Dialog: expose .position() API
2010-07-14 16:29:28 -04:00
Scott González
8a5d4ca321
All: Added http://jqueryui.com/about to header comments.
2010-07-14 15:45:45 -04:00
Scott González
2c7a9e9ff3
Dialog: Verify that we get a string back from .attr( "title" ) before using the return value. Fixes #5742 - Form field with name="title" moved to title area.
2010-07-14 15:28:01 -04:00
Scott González
21aad10e6a
All: Define a local undefined variable inside the main closure.
2010-07-13 09:57:58 -04:00
Jon Palmer
f560862666
Dialog: add resize call when changing button options for correct height adjustment. Fixes remaining issues in #4846 - Setting Dialog height shorter after init hides button pane
2010-07-11 06:42:46 +08:00
Scott González
536ae6189b
Updated copyright headers to make it clear that you can choose between MIT and GPLv2. Also added a link to http://jquery.org/license .
2010-07-09 09:01:04 -04:00
Scott González
b297b3fa6a
Fixed size calculations for dialogs.
...
Fixes #5392 - Dialog explicit height doesn't match given value from set option.
2010-03-25 21:58:08 -04:00
Scott González
596d1ef581
Dialog: Use .height(0) instead of .hide(0) when determining the size of the non-content area of a dialog.
...
Partial fix for #5392 - Dialog explicit height doesn't match given value from set option.
2010-03-22 07:53:34 -04:00
Richard Worth
aa6fb14854
Dialog: quiet JSLint
2010-03-12 01:10:57 +00:00
Richard Worth
7898303437
dialog: corrected typo in ui.position property for drag events. Updated unit tests tracking fix of #5291
2010-03-11 20:48:21 +00:00
Jörn Zaefferer
d3a8c96428
Filter properties to forward to dialog events on resize and drag etc. - fix for #5291
2010-03-05 17:56:34 +00:00
Jörn Zaefferer
eaeb580d82
Pass through resizable and draggable ui objects in dialog - partial fix for #5291
2010-03-05 17:47:06 +00:00
Scott González
eb93c743de
Dialog: Fixed modal overlay instance tracking.
...
Fixes #5228 - $.inArray's parameter.
Fixes #5263 - Dialog Close Then Destroy Destroys Overlay Twice, Causes Exceptions Later.
2010-03-03 02:11:37 +00:00
Scott González
83b16f528f
Dialog: Use .height() to calculate height of dialog before drag.
...
Fixes #5221 - Buttons disappear after dragging dialog.
2010-02-24 17:16:02 +00:00
Brant Burnett
350853179f
Dialog: ESC key event was not being canceled after it was handled ( Fixed #4922 window.location.reload() doesn't work in dialog's close callback when it's triggered by ESC in Firefox)
2010-02-22 18:39:12 +00:00
Brant Burnett
e2202847c6
Dialog: Changed height measurement to hide content because IE quirks mode ignores height: 0 ( Fixed #4350 No Scrollbars in IE in Quirksmode)
2010-02-22 17:37:08 +00:00
Brant Burnett
53ab4fb5de
Dialog: Overlays are now cached for reuse with subsequent dialogs ( Fixed #5185 : .ui-widget-overlay CSS selector causes consistent large memory leak in IE)
2010-02-17 16:22:19 +00:00
Scott González
c9f30818af
Dialog: Update the internal flag for whether or not the dialog is open before triggering the close event.
...
Fixes #5184 - isOpen in dialogclose event is true.
2010-02-16 02:13:38 +00:00
Scott González
f2a9deb611
Dialog: Prevent the titlebar from displaying above the top of the document.
...
Fixes #5141 - Position of Dialog is off the page when viewport is smaller then dialog.
2010-02-06 02:02:03 +00:00
